archive/BookStackApp_BookStack
0
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-04-23 20:30:22 +00:00
Code Issues Projects Releases Wiki Activity

Prevented inadvertant logging during MFA flow

Browse source 
- Added StoppedAuthenticationException to dontReport list.
- Added test to cover.

Closes
This commit is contained in:
Dan Brown 2022-05-30 18:31:08 +01:00
parent 43cbab2822
commit 16e023985d
No known key found for this signature in database
GPG key ID: 46D9F943C24A2EF9
2 changed files with 11 additions and 0 deletions
app/Exceptions
Handler.php
tests/Auth
MfaVerificationTest.php

1
app/Exceptions/Handler.php
View file

@ -21,6 +21,7 @@ class Handler extends ExceptionHandler
*/ */
protected $dontReport = [ protected $dontReport = [
NotFoundException::class, NotFoundException::class,
StoppedAuthenticationException::class,
]; ];
/** /**

10
tests/Auth/MfaVerificationTest.php
View file

@ -241,6 +241,16 @@ class MfaVerificationTest extends TestCase
} }
} }
public function test_login_mfa_interception_does_not_log_error()
{
$logHandler = $this->withTestLogger();
[$user, $secret, $loginResp] = $this->startTotpLogin();
$loginResp->assertRedirect('/mfa/verify');
$this->assertFalse($logHandler->hasErrorRecords());
}
/** /**
* @return array<User, string, TestResponse> * @return array<User, string, TestResponse>
*/ */