From 6a5361d853eccda55eadb56ec249236cd4ab164e Mon Sep 17 00:00:00 2001 From: Tushar Nain <100490977+tusharnain4578@users.noreply.github.com> Date: Sat, 16 Sep 2023 14:00:08 +0530 Subject: [PATCH] Fixed : Comment notification settings are visible even if comments are disabled Added a UX condition to display comment notification settings, only if the user has enabled the comment notifications. --- .../users/preferences/notifications.blade.php | 30 ++++++++++--------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/resources/views/users/preferences/notifications.blade.php b/resources/views/users/preferences/notifications.blade.php index ae89c087e..9817aac4d 100644 --- a/resources/views/users/preferences/notifications.blade.php +++ b/resources/views/users/preferences/notifications.blade.php @@ -20,20 +20,22 @@ 'label' => trans('preferences.notifications_opt_own_page_changes'), ]) </div> - <div> - @include('form.toggle-switch', [ - 'name' => 'preferences[own-page-comments]', - 'value' => $preferences->notifyOnOwnPageComments(), - 'label' => trans('preferences.notifications_opt_own_page_comments'), - ]) - </div> - <div> - @include('form.toggle-switch', [ - 'name' => 'preferences[comment-replies]', - 'value' => $preferences->notifyOnCommentReplies(), - 'label' => trans('preferences.notifications_opt_comment_replies'), - ]) - </div> + @if (!setting('app-disable-comments')) + <div> + @include('form.toggle-switch', [ + 'name' => 'preferences[own-page-comments]', + 'value' => $preferences->notifyOnOwnPageComments(), + 'label' => trans('preferences.notifications_opt_own_page_comments'), + ]) + </div> + <div> + @include('form.toggle-switch', [ + 'name' => 'preferences[comment-replies]', + 'value' => $preferences->notifyOnCommentReplies(), + 'label' => trans('preferences.notifications_opt_comment_replies'), + ]) + </div> + @endif </div> <div class="mt-auto">