archive/BookStackApp_BookStack
0
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-05-02 23:40:04 +00:00
Code Issues Projects Releases Wiki Activity

Wrapped wysiwyg drawing change in editor transaction

Browse source 
To make the content changes made a undoable transaction that is picked
up as a change.
From my testing, should address
This commit is contained in:
Dan Brown 2022-09-05 15:06:47 +01:00
parent 2d7552aa09
commit b698bb0e07
No known key found for this signature in database
GPG key ID: 46D9F943C24A2EF9
1 changed files with 14 additions and 8 deletions

22
resources/js/wysiwyg/plugin-drawio.js
View file

@ -18,11 +18,13 @@ function showDrawingManager(mceEditor, selectedNode = null) {
// Show image manager // Show image manager
window.ImageManager.show(function (image) { window.ImageManager.show(function (image) {
if (selectedNode) { if (selectedNode) {
let imgElem = selectedNode.querySelector('img'); const imgElem = selectedNode.querySelector('img');
pageEditor.dom.setAttrib(imgElem, 'src', image.url); pageEditor.undoManager.transact(function () {
pageEditor.dom.setAttrib(selectedNode, 'drawio-diagram', image.id); pageEditor.dom.setAttrib(imgElem, 'src', image.url);
pageEditor.dom.setAttrib(selectedNode, 'drawio-diagram', image.id);
});
} else { } else {
let imgHTML = `<div drawio-diagram="${image.id}" contenteditable="false"><img src="${image.url}"></div>`; const imgHTML = `<div drawio-diagram="${image.id}" contenteditable="false"><img src="${image.url}"></div>`;
pageEditor.insertContent(imgHTML); pageEditor.insertContent(imgHTML);
} }
}, 'drawio'); }, 'drawio');
@ -53,8 +55,10 @@ async function updateContent(pngData) {
let imgElem = currentNode.querySelector('img'); let imgElem = currentNode.querySelector('img');
try { try {
const img = await DrawIO.upload(pngData, options.pageId); const img = await DrawIO.upload(pngData, options.pageId);
pageEditor.dom.setAttrib(imgElem, 'src', img.url); pageEditor.undoManager.transact(function () {
pageEditor.dom.setAttrib(currentNode, 'drawio-diagram', img.id); pageEditor.dom.setAttrib(imgElem, 'src', img.url);
pageEditor.dom.setAttrib(currentNode, 'drawio-diagram', img.id);
});
} catch (err) { } catch (err) {
handleUploadError(err); handleUploadError(err);
} }
@ -66,8 +70,10 @@ async function updateContent(pngData) {
DrawIO.close(); DrawIO.close();
try { try {
const img = await DrawIO.upload(pngData, options.pageId); const img = await DrawIO.upload(pngData, options.pageId);
pageEditor.dom.setAttrib(id, 'src', img.url); pageEditor.undoManager.transact(function () {
pageEditor.dom.get(id).parentNode.setAttribute('drawio-diagram', img.id); pageEditor.dom.setAttrib(id, 'src', img.url);
pageEditor.dom.get(id).parentNode.setAttribute('drawio-diagram', img.id);
});
} catch (err) { } catch (err) {
pageEditor.dom.remove(id); pageEditor.dom.remove(id);
handleUploadError(err); handleUploadError(err);