From dce6a8295469f6860fa32b00f85c522d315a74a9 Mon Sep 17 00:00:00 2001
From: Dan Brown <ssddanbrown@googlemail.com>
Date: Tue, 20 Sep 2022 12:52:44 +0100
Subject: [PATCH] Added reason, if existing, into SAML acs error
Closes #3731
---
app/Auth/Access/Saml2Service.php | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/app/Auth/Access/Saml2Service.php b/app/Auth/Access/Saml2Service.php
index f5d0cd7cc..b0bf39995 100644
--- a/app/Auth/Access/Saml2Service.php
+++ b/app/Auth/Access/Saml2Service.php
@@ -109,9 +109,10 @@ class Saml2Service
$errors = $toolkit->getErrors();
if (!empty($errors)) {
- throw new Error(
- 'Invalid ACS Response: ' . implode(', ', $errors)
- );
+ $reason = $toolkit->getLastErrorReason();
+ $message = 'Invalid ACS Response; Errors: ' . implode(', ', $errors);
+ $message .= $reason ? "; Reason: {$reason}" : '';
+ throw new Error($message);
}
if (!$toolkit->isAuthenticated()) {