Remove now obsolete Check.prepare_badge_key()

cc: #1100

hc/api/models.py

@@ -382,12 +382,6 @@ class Check(models.Model):
         code_half = self.code.hex[:16]
         return hashlib.sha1(code_half.encode()).hexdigest()
 
-    def prepare_badge_key(self) -> uuid.UUID:
-        if not self.badge_key:
-            self.badge_key = uuid.uuid4()
-            Check.objects.filter(id=self.id).update(badge_key=self.badge_key)
-        return self.badge_key
-
     def to_dict(self, *, readonly: bool = False, v: int = 3) -> CheckDict:
         with_started = v == 1
         result: CheckDict = {

hc/api/tests/test_check_badge.py

@@ -12,12 +12,11 @@ class CheckBadgeTestCase(BaseTestCase):
     def setUp(self) -> None:
         super().setUp()
         self.check = Check.objects.create(project=self.project, name="foobar")
-        badge_key = self.check.prepare_badge_key()
 
-        self.svg_url = f"/b/2/{badge_key}.svg"
-        self.json_url = f"/b/2/{badge_key}.json"
-        self.with_late_url = f"/b/3/{badge_key}.json"
-        self.shields_url = f"/b/2/{badge_key}.shields"
+        self.svg_url = f"/b/2/{self.check.badge_key}.svg"
+        self.json_url = f"/b/2/{self.check.badge_key}.json"
+        self.with_late_url = f"/b/3/{self.check.badge_key}.json"
+        self.shields_url = f"/b/2/{self.check.badge_key}.shields"
 
     def test_it_handles_bad_badge_key(self) -> None:
         r = self.client.get("/b/2/869fe06a-a604-4140-b15a-118637c25f3e.svg")

hc/front/tests/test_badges.py

@@ -15,7 +15,6 @@ class BadgesTestCase(BaseTestCase):
         self.project.save()
 
         self.check = Check.objects.create(project=self.project, tags="foo a-B_1  baz@")
-        self.check.prepare_badge_key()
 
         self.url = f"/projects/{self.project.code}/badges/"
 

hc/front/views.py

@@ -1163,7 +1163,7 @@ def badges(request: AuthenticatedHttpRequest, code: UUID) -> HttpResponse:
         elif form.cleaned_data["target"] == "check":
             check = project.check_set.get(code=form.cleaned_data["check"])
             url = absolute_reverse(
-                "hc-badge-check", args=[states, check.prepare_badge_key(), fmt]
+                "hc-badge-check", args=[states, check.badge_key, fmt]
             )
             label = check.name_then_code()