archive/healthchecks_healthchecks
0
0
Fork 0
mirror of https://github.com/healthchecks/healthchecks.git synced 2025-04-07 14:15:34 +00:00
Code Issues Projects Releases Wiki Activity

Update rocketchat integration to give up db connection before network IO

Browse source
This commit is contained in:
Pēteris Caune 2025-03-28 14:12:56 +02:00
parent 81623f067a
commit ffd40c7c3c
No known key found for this signature in database
GPG key ID: E28D7679E9A9EDE2
2 changed files with 4 additions and 0 deletions

1
hc/api/tests/test_notify_rocketchat.py
View file

@ -10,6 +10,7 @@ from hc.api.models import Channel, Check, Flip, Notification, Ping
from hc.test import BaseTestCase from hc.test import BaseTestCase
@patch("hc.api.transports.close_old_connections", Mock())
class NotifyRocketChatTestCase(BaseTestCase): class NotifyRocketChatTestCase(BaseTestCase):
def setUp(self) -> None: def setUp(self) -> None:
super().setUp() super().setUp()

3
hc/api/transports.py
View file

@ -808,6 +808,9 @@ class RocketChat(HttpTransport):
def notify(self, flip: Flip, notification: Notification) -> None: def notify(self, flip: Flip, notification: Notification) -> None:
if not settings.ROCKETCHAT_ENABLED: if not settings.ROCKETCHAT_ENABLED:
raise TransportError("Rocket.Chat notifications are not enabled.") raise TransportError("Rocket.Chat notifications are not enabled.")
# Give up database connection before potentially long network IO:
close_old_connections()
self.post(self.channel.value, json=self.payload(flip)) self.post(self.channel.value, json=self.payload(flip))