mirror of
https://github.com/mumble-voip/mumble.git
synced 2025-02-05 05:19:56 +00:00
7271bcaf05
In a Qt application, the QApplication object should be the first QObject that is created. However, the `Meta` class used to have a static member called `mp`, which means that this member gets initialized _before_ main() runs and therefore before the QApplication is created. This has caused an "Invalid nullptr in QObject::connect" warning somewhere in Qt's internals (since the move to Qt 6). The impact of this warning is unclear at this point. This commit makes the mp parameter a std::unique_ptr that gets explicitly initialized in the main function (more or less right after the QApplication object is created). This guarantees that the MetaParams object does not get created before the QApplication object, fixing the observed warning. It is worth noting that we do have a couple of other static QObject variables in the main translation unit, but these seem to be inconsequential (at least they don't seem to trigger a similar warning). Fixes #6669 |
||
|---|---|---|
| .. | ||
| commitMessage | ||
| backportTranslations.py | ||
| create_source_archive.py | ||
| generate-ApplicationPalette-class.py | ||
| generate-ffdhe.py | ||
| generate-mumble_qt-qrc.py | ||
| generate_changelog.py | ||
| generate_cmake_options_docs.py | ||
| generate_configure_cmake_script.py | ||
| generate_flag_qrc.py | ||
| generate_license_header.py | ||
| generate_mumble_ico.py | ||
| generateIceWrapper.py | ||
| mumble-build-number.py | ||
| mumble-version.py | ||
| runClangFormat.sh | ||
| sign_macOS.py | ||
| updatetranslations.py | ||