From 3f1a1bd55eabb63f8365ed1072241f468efffe41 Mon Sep 17 00:00:00 2001
From: Ilya Mashchenko <ilya@netdata.cloud>
Date: Fri, 27 Dec 2024 20:08:33 +0200
Subject: [PATCH] fix(netdata-updater.sh): ensure tmpdir-path argument is
always passed (#19289)
---
packaging/installer/netdata-updater.sh | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/packaging/installer/netdata-updater.sh b/packaging/installer/netdata-updater.sh
index 342f3f62f0..2879d394da 100755
--- a/packaging/installer/netdata-updater.sh
+++ b/packaging/installer/netdata-updater.sh
@@ -586,11 +586,13 @@ self_update() {
if _safe_download "https://raw.githubusercontent.com/netdata/netdata/master/packaging/installer/netdata-updater.sh" ./netdata-updater.sh; then
chmod +x ./netdata-updater.sh || exit 1
export ENVIRONMENT_FILE="${ENVIRONMENT_FILE}"
- force_update=""
- [ "$NETDATA_FORCE_UPDATE" = "1" ] && force_update="--force-update"
- interactive=""
- [ "$INTERACTIVE" = "0" ] && interactive="--non-interactive"
- exec ./netdata-updater.sh --not-running-from-cron --no-updater-self-update "$force_update" "$interactive" --tmpdir-path "$(pwd)"
+
+ cmd="./netdata-updater.sh --not-running-from-cron --no-updater-self-update"
+ [ "$NETDATA_FORCE_UPDATE" = "1" ] && cmd="$cmd --force-update"
+ [ "$INTERACTIVE" = "0" ] && cmd="$cmd --non-interactive"
+ cmd="$cmd --tmpdir-path $(pwd)"
+
+ exec $cmd
else
error "Failed to download newest version of updater script, continuing with current version."
fi