archive/netdata_netdata
0
0
Fork 0
mirror of https://github.com/netdata/netdata.git synced 2025-04-13 17:19:11 +00:00
Code Issues Projects Releases Wiki Activity

nd_poll() prefers sending data vs receiving data - in an attempt to dequeue as soon as possible

Browse source
This commit is contained in:
Costa Tsaousis 2024-12-09 18:12:26 +02:00
parent 4930f24a52
commit 51539a97da
No known key found for this signature in database
GPG key ID: 3A4F28E963D28A1F
1 changed files with 27 additions and 1 deletions

28
src/libnetdata/socket/nd-poll.c
View file

@ -58,7 +58,7 @@ static inline bool nd_poll_get_next_event(nd_poll_t *ndpl, nd_poll_result_t *res
.data = ndpl->ev[i].data.ptr,
};
if (ndpl->ev[i].events & EPOLLIN)
if (ndpl->ev[i].events & (EPOLLIN|EPOLLPRI))
result->events |= ND_POLL_READ;
if (ndpl->ev[i].events & EPOLLOUT)
@ -78,6 +78,29 @@ static inline bool nd_poll_get_next_event(nd_poll_t *ndpl, nd_poll_result_t *res
return false;
}
static inline int epoll_event_priority(const struct epoll_event *ev) {
// Write-only events
if (ev->events == EPOLLOUT) return 1;
// Mixed read and write
if (ev->events & EPOLLOUT) return 2;
// Read-only events
if (ev->events & (EPOLLIN | EPOLLPRI)) return 3;
// Errors or hangups (rare, but the first priority)
if (ev->events & (EPOLLERR | EPOLLHUP)) return 0;
// Default case: Lowest priority
return 4;
}
static int epoll_event_priority_cmp(const void *a, const void *b) {
const struct epoll_event *ev1 = (const struct epoll_event *)a;
const struct epoll_event *ev2 = (const struct epoll_event *)b;
return epoll_event_priority(ev1) - epoll_event_priority(ev2);
}
// Wait for events
int nd_poll_wait(nd_poll_t *ndpl, int timeout_ms, nd_poll_result_t *result) {
if(nd_poll_get_next_event(ndpl, result))
@ -104,6 +127,9 @@ int nd_poll_wait(nd_poll_t *ndpl, int timeout_ms, nd_poll_result_t *result) {
return -1;
}
if(n > 1)
qsort(ndpl->ev, n, sizeof(struct epoll_event), epoll_event_priority_cmp);
ndpl->used = n;
if (nd_poll_get_next_event(ndpl, result))
return 1;