0
0
Fork 0
mirror of https://github.com/netdata/netdata.git synced 2025-04-17 11:12:42 +00:00

chore(go.d.plugin): remove duplicate logging in init/check ()

This commit is contained in:
Ilya Mashchenko 2024-11-06 17:06:36 +02:00 committed by GitHub
parent 2d7caee566
commit 8f0401ac3b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
116 changed files with 310 additions and 548 deletions
src/go/plugin/go.d/modules
activemq
adaptecraid
ap
apache
apcupsd
beanstalk
bind
boinc
cassandra
ceph
chrony
clickhouse
cockroachdb
consul
coredns
couchbase
couchdb
dmcache
dnsdist
dnsmasq
dnsmasq_dhcp
dnsquery
docker
docker_engine
dockerhub
dovecot
elasticsearch
envoy
exim
fail2ban
filecheck
fluentd
freeradius
gearman
geth
haproxy
hddtemp
hpssa
httpcheck
icecast
intelgpu
ipfs
isc_dhcpd
k8s_kubelet
k8s_kubeproxy
k8s_state
litespeed
logind
logstash
lvm
megacli
memcached
mongodb
monit
mysql
nginx
nginxplus
nginxunit
nginxvts
nsd
ntpd
nvidia_smi
nvme
openldap
openvpn
openvpn_status_log
pgbouncer
phpfpm
pihole
pika
ping
portcheck
postfix
postgres
powerdns
powerdns_recursor
prometheus
proxysql
pulsar
puppet
rabbitmq
redis
rethinkdb
riakkv
rspamd
samba
scaleio
sensors
smartctl
snmp
squid
squidlog
storcli
supervisord
systemdunits
tengine
testrandom
tomcat
tor

View file

@ -5,6 +5,7 @@ package activemq
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/pkg/matcher"
@ -75,28 +76,24 @@ func (a *ActiveMQ) Configuration() any {
func (a *ActiveMQ) Init() error {
if err := a.validateConfig(); err != nil {
a.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
qf, err := a.initQueuesFiler()
if err != nil {
a.Error(err)
return err
return fmt.Errorf("init queues filer: %v", err)
}
a.queuesFilter = qf
tf, err := a.initTopicsFilter()
if err != nil {
a.Error(err)
return err
return fmt.Errorf("init topics filter: %v", err)
}
a.topicsFilter = tf
client, err := web.NewHTTPClient(a.ClientConfig)
if err != nil {
a.Error(err)
return err
return fmt.Errorf("create http client: %v", err)
}
a.apiClient = newAPIClient(client, a.RequestConfig, a.Webadmin)
@ -107,7 +104,6 @@ func (a *ActiveMQ) Init() error {
func (a *ActiveMQ) Check() error {
mx, err := a.collect()
if err != nil {
a.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -7,6 +7,7 @@ package adaptecraid
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -68,8 +69,7 @@ func (a *AdaptecRaid) Configuration() any {
func (a *AdaptecRaid) Init() error {
arcconfExec, err := a.initArcconfCliExec()
if err != nil {
a.Errorf("arcconf exec initialization: %v", err)
return err
return fmt.Errorf("arcconf exec initialization: %v", err)
}
a.exec = arcconfExec
@ -79,7 +79,6 @@ func (a *AdaptecRaid) Init() error {
func (a *AdaptecRaid) Check() error {
mx, err := a.collect()
if err != nil {
a.Error(err)
return err
}

View file

@ -7,6 +7,7 @@ package ap
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -67,14 +68,12 @@ func (a *AP) Configuration() any {
func (a *AP) Init() error {
if err := a.validateConfig(); err != nil {
a.Errorf("config validation: %s", err)
return err
return fmt.Errorf("config validation: %s", err)
}
iw, err := a.initIwExec()
if err != nil {
a.Errorf("iw dev exec initialization: %v", err)
return err
return fmt.Errorf("iw exec initialization: %v", err)
}
a.exec = iw
@ -84,7 +83,6 @@ func (a *AP) Init() error {
func (a *AP) Check() error {
mx, err := a.collect()
if err != nil {
a.Error(err)
return err
}

View file

@ -5,6 +5,7 @@ package apache
import (
_ "embed"
"errors"
"fmt"
"net/http"
"sync"
"time"
@ -64,14 +65,12 @@ func (a *Apache) Configuration() any {
func (a *Apache) Init() error {
if err := a.validateConfig(); err != nil {
a.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
httpClient, err := a.initHTTPClient()
if err != nil {
a.Errorf("init HTTP client: %v", err)
return err
return fmt.Errorf("init HTTP client: %v", err)
}
a.httpClient = httpClient
@ -84,7 +83,6 @@ func (a *Apache) Init() error {
func (a *Apache) Check() error {
mx, err := a.collect()
if err != nil {
a.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -55,8 +55,7 @@ func (a *Apcupsd) Configuration() any {
func (a *Apcupsd) Init() error {
if a.Address == "" {
a.Error("config: 'address' not set")
return errors.New("address not set")
return errors.New("config: 'address' not set")
}
return nil
@ -65,7 +64,6 @@ func (a *Apcupsd) Init() error {
func (a *Apcupsd) Check() error {
mx, err := a.collect()
if err != nil {
a.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -85,7 +85,6 @@ func (b *Beanstalk) Init() error {
func (b *Beanstalk) Check() error {
mx, err := b.collect()
if err != nil {
b.Error(err)
return err
}

View file

@ -5,6 +5,7 @@ package bind
import (
_ "embed"
"errors"
"fmt"
"net/http"
"time"
@ -71,14 +72,12 @@ func (b *Bind) Configuration() any {
func (b *Bind) Init() error {
if err := b.validateConfig(); err != nil {
b.Errorf("config verification: %v", err)
return err
return fmt.Errorf("config verification: %v", err)
}
pvm, err := b.initPermitViewMatcher()
if err != nil {
b.Error(err)
return err
return fmt.Errorf("init permit view matcher: %v", err)
}
if pvm != nil {
b.permitView = pvm
@ -86,15 +85,13 @@ func (b *Bind) Init() error {
httpClient, err := web.NewHTTPClient(b.ClientConfig)
if err != nil {
b.Errorf("creating http client : %v", err)
return err
return fmt.Errorf("creating http client : %v", err)
}
b.httpClient = httpClient
bindClient, err := b.initBindApiClient(httpClient)
if err != nil {
b.Error(err)
return err
return fmt.Errorf("init bind api client: %v", err)
}
b.bindAPIClient = bindClient
@ -104,7 +101,6 @@ func (b *Bind) Init() error {
func (b *Bind) Check() error {
mx, err := b.collect()
if err != nil {
b.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -57,8 +57,7 @@ func (b *Boinc) Configuration() any {
func (b *Boinc) Init() error {
if b.Address == "" {
b.Error("config: 'address' not set")
return errors.New("address not set")
return errors.New("config: 'address' not set")
}
return nil
@ -67,7 +66,6 @@ func (b *Boinc) Init() error {
func (b *Boinc) Check() error {
mx, err := b.collect()
if err != nil {
b.Error(err)
return err
}

View file

@ -5,6 +5,7 @@ package cassandra
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -69,14 +70,12 @@ func (c *Cassandra) Configuration() any {
func (c *Cassandra) Init() error {
if err := c.validateConfig(); err != nil {
c.Errorf("error on validating config: %v", err)
return err
return fmt.Errorf("error on validating config: %v", err)
}
prom, err := c.initPrometheusClient()
if err != nil {
c.Errorf("error on init prometheus client: %v", err)
return err
return fmt.Errorf("error on init prometheus client: %v", err)
}
c.prom = prom
@ -86,7 +85,6 @@ func (c *Cassandra) Init() error {
func (c *Cassandra) Check() error {
mx, err := c.collect()
if err != nil {
c.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -84,7 +84,7 @@ func (c *Ceph) Init() error {
httpClient, err := web.NewHTTPClient(c.ClientConfig)
if err != nil {
return err
return fmt.Errorf("create http client: %v", err)
}
c.httpClient = httpClient
@ -94,7 +94,6 @@ func (c *Ceph) Init() error {
func (c *Ceph) Check() error {
mx, err := c.collect()
if err != nil {
c.Error(err)
return err
}

View file

@ -5,6 +5,7 @@ package chrony
import (
_ "embed"
"errors"
"fmt"
"sync"
"time"
@ -60,8 +61,7 @@ func (c *Chrony) Configuration() any {
func (c *Chrony) Init() error {
if err := c.validateConfig(); err != nil {
c.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
var err error
@ -75,7 +75,6 @@ func (c *Chrony) Init() error {
func (c *Chrony) Check() error {
mx, err := c.collect()
if err != nil {
c.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package clickhouse
import (
_ "embed"
"errors"
"fmt"
"net/http"
"time"
@ -69,14 +70,12 @@ func (c *ClickHouse) Configuration() any {
func (c *ClickHouse) Init() error {
if err := c.validateConfig(); err != nil {
c.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
httpClient, err := c.initHTTPClient()
if err != nil {
c.Errorf("init HTTP client: %v", err)
return err
return fmt.Errorf("init HTTP client: %v", err)
}
c.httpClient = httpClient
@ -89,7 +88,6 @@ func (c *ClickHouse) Init() error {
func (c *ClickHouse) Check() error {
mx, err := c.collect()
if err != nil {
c.Error(err)
return err
}

View file

@ -5,6 +5,7 @@ package cockroachdb
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -67,14 +68,12 @@ func (c *CockroachDB) Configuration() any {
func (c *CockroachDB) Init() error {
if err := c.validateConfig(); err != nil {
c.Errorf("error on validating config: %v", err)
return err
return fmt.Errorf("error on validating config: %v", err)
}
prom, err := c.initPrometheusClient()
if err != nil {
c.Error(err)
return err
return fmt.Errorf("error on initializing prometheus client: %v", err)
}
c.prom = prom
@ -89,7 +88,6 @@ func (c *CockroachDB) Init() error {
func (c *CockroachDB) Check() error {
mx, err := c.collect()
if err != nil {
c.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package consul
import (
_ "embed"
"errors"
"fmt"
"net/http"
"sync"
"time"
@ -80,21 +81,18 @@ func (c *Consul) Configuration() any {
func (c *Consul) Init() error {
if err := c.validateConfig(); err != nil {
c.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
httpClient, err := c.initHTTPClient()
if err != nil {
c.Errorf("init HTTP client: %v", err)
return err
return fmt.Errorf("init HTTP client: %v", err)
}
c.httpClient = httpClient
prom, err := c.initPrometheusClient(httpClient)
if err != nil {
c.Errorf("init Prometheus client: %v", err)
return err
return fmt.Errorf("init Prometheus client: %v", err)
}
c.prom = prom
@ -104,7 +102,6 @@ func (c *Consul) Init() error {
func (c *Consul) Check() error {
mx, err := c.collect()
if err != nil {
c.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package coredns
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/pkg/matcher"
@ -75,14 +76,12 @@ func (cd *CoreDNS) Configuration() any {
func (cd *CoreDNS) Init() error {
if err := cd.validateConfig(); err != nil {
cd.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
sm, err := cd.initPerServerMatcher()
if err != nil {
cd.Error(err)
return err
return fmt.Errorf("init per_server_stats: %v", err)
}
if sm != nil {
cd.perServerMatcher = sm
@ -90,8 +89,7 @@ func (cd *CoreDNS) Init() error {
zm, err := cd.initPerZoneMatcher()
if err != nil {
cd.Error(err)
return err
return fmt.Errorf("init per_zone_stats: %v", err)
}
if zm != nil {
cd.perZoneMatcher = zm
@ -99,8 +97,7 @@ func (cd *CoreDNS) Init() error {
prom, err := cd.initPrometheusClient()
if err != nil {
cd.Error(err)
return err
return fmt.Errorf("init prometheus client: %v", err)
}
cd.prom = prom
@ -110,7 +107,6 @@ func (cd *CoreDNS) Init() error {
func (cd *CoreDNS) Check() error {
mx, err := cd.collect()
if err != nil {
cd.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package couchbase
import (
_ "embed"
"errors"
"fmt"
"net/http"
"time"
@ -65,21 +66,18 @@ func (cb *Couchbase) Configuration() any {
func (cb *Couchbase) Init() error {
err := cb.validateConfig()
if err != nil {
cb.Errorf("check configuration: %v", err)
return err
return fmt.Errorf("check configuration: %v", err)
}
httpClient, err := cb.initHTTPClient()
if err != nil {
cb.Errorf("init HTTP client: %v", err)
return err
return fmt.Errorf("init HTTP client: %v", err)
}
cb.httpClient = httpClient
charts, err := cb.initCharts()
if err != nil {
cb.Errorf("init charts: %v", err)
return err
return fmt.Errorf("init charts: %v", err)
}
cb.charts = charts
@ -89,7 +87,6 @@ func (cb *Couchbase) Init() error {
func (cb *Couchbase) Check() error {
mx, err := cb.collect()
if err != nil {
cb.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package couchdb
import (
_ "embed"
"errors"
"fmt"
"net/http"
"strings"
"time"
@ -69,23 +70,20 @@ func (cdb *CouchDB) Configuration() any {
func (cdb *CouchDB) Init() error {
err := cdb.validateConfig()
if err != nil {
cdb.Errorf("check configuration: %v", err)
return err
return fmt.Errorf("check configuration: %v", err)
}
cdb.databases = strings.Fields(cdb.Config.Databases)
httpClient, err := cdb.initHTTPClient()
if err != nil {
cdb.Errorf("init HTTP client: %v", err)
return err
return fmt.Errorf("init HTTP client: %v", err)
}
cdb.httpClient = httpClient
charts, err := cdb.initCharts()
if err != nil {
cdb.Errorf("init charts: %v", err)
return err
return fmt.Errorf("init charts: %v", err)
}
cdb.charts = charts
@ -94,13 +92,11 @@ func (cdb *CouchDB) Init() error {
func (cdb *CouchDB) Check() error {
if err := cdb.pingCouchDB(); err != nil {
cdb.Error(err)
return err
}
mx, err := cdb.collect()
if err != nil {
cdb.Error(err)
return err
}

View file

@ -7,6 +7,7 @@ package dmcache
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -65,8 +66,7 @@ func (c *DmCache) Configuration() any {
func (c *DmCache) Init() error {
dmsetup, err := c.initDmsetupCLI()
if err != nil {
c.Errorf("dmsetup exec initialization: %v", err)
return err
return fmt.Errorf("dmsetup exec initialization: %v", err)
}
c.exec = dmsetup
@ -76,7 +76,6 @@ func (c *DmCache) Init() error {
func (c *DmCache) Check() error {
mx, err := c.collect()
if err != nil {
c.Error(err)
return err
}

View file

@ -5,6 +5,7 @@ package dnsdist
import (
_ "embed"
"errors"
"fmt"
"net/http"
"time"
@ -63,21 +64,18 @@ func (d *DNSdist) Configuration() any {
func (d *DNSdist) Init() error {
err := d.validateConfig()
if err != nil {
d.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
client, err := d.initHTTPClient()
if err != nil {
d.Errorf("init HTTP client: %v", err)
return err
return fmt.Errorf("init HTTP client: %v", err)
}
d.httpClient = client
cs, err := d.initCharts()
if err != nil {
d.Errorf("init charts: %v", err)
return err
return fmt.Errorf("init charts: %v", err)
}
d.charts = cs
@ -87,7 +85,6 @@ func (d *DNSdist) Init() error {
func (d *DNSdist) Check() error {
mx, err := d.collect()
if err != nil {
d.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package dnsmasq
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -70,21 +71,18 @@ func (d *Dnsmasq) Configuration() any {
func (d *Dnsmasq) Init() error {
err := d.validateConfig()
if err != nil {
d.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
client, err := d.initDNSClient()
if err != nil {
d.Errorf("init DNS client: %v", err)
return err
return fmt.Errorf("init DNS client: %v", err)
}
d.dnsClient = client
charts, err := d.initCharts()
if err != nil {
d.Errorf("init charts: %v", err)
return err
return fmt.Errorf("init charts: %v", err)
}
d.charts = charts
@ -94,7 +92,6 @@ func (d *Dnsmasq) Init() error {
func (d *Dnsmasq) Check() error {
mx, err := d.collect()
if err != nil {
d.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -7,6 +7,7 @@ package dnsmasq_dhcp
import (
_ "embed"
"errors"
"fmt"
"net"
"time"
@ -69,12 +70,10 @@ func (d *DnsmasqDHCP) Configuration() any {
func (d *DnsmasqDHCP) Init() error {
if err := d.validateConfig(); err != nil {
d.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
if err := d.checkLeasesPath(); err != nil {
d.Errorf("leases path check: %v", err)
return err
return fmt.Errorf("leases path check: %v", err)
}
return nil
@ -83,7 +82,6 @@ func (d *DnsmasqDHCP) Init() error {
func (d *DnsmasqDHCP) Check() error {
mx, err := d.collect()
if err != nil {
d.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -4,6 +4,7 @@ package dnsquery
import (
_ "embed"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -77,21 +78,18 @@ func (d *DNSQuery) Configuration() any {
func (d *DNSQuery) Init() error {
if err := d.verifyConfig(); err != nil {
d.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
rt, err := d.initRecordTypes()
if err != nil {
d.Errorf("init record type: %v", err)
return err
return fmt.Errorf("init record type: %v", err)
}
d.recordTypes = rt
charts, err := d.initCharts()
if err != nil {
d.Errorf("init charts: %v", err)
return err
return fmt.Errorf("init charts: %v", err)
}
d.charts = charts

View file

@ -90,7 +90,6 @@ func (d *Docker) Init() error {
func (d *Docker) Check() error {
mx, err := d.collect()
if err != nil {
d.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package docker_engine
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -60,14 +61,12 @@ func (de *DockerEngine) Configuration() any {
func (de *DockerEngine) Init() error {
if err := de.validateConfig(); err != nil {
de.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
prom, err := de.initPrometheusClient()
if err != nil {
de.Error(err)
return err
return fmt.Errorf("init prometheus client: %v", err)
}
de.prom = prom
@ -77,7 +76,6 @@ func (de *DockerEngine) Init() error {
func (de *DockerEngine) Check() error {
mx, err := de.collect()
if err != nil {
de.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package dockerhub
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -60,14 +61,12 @@ func (dh *DockerHub) Configuration() any {
func (dh *DockerHub) Init() error {
if err := dh.validateConfig(); err != nil {
dh.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
client, err := dh.initApiClient()
if err != nil {
dh.Error(err)
return err
return fmt.Errorf("init api client: %v", err)
}
dh.client = client
@ -77,7 +76,6 @@ func (dh *DockerHub) Init() error {
func (dh *DockerHub) Check() error {
mx, err := dh.collect()
if err != nil {
dh.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -55,8 +55,7 @@ func (d *Dovecot) Configuration() any {
func (d *Dovecot) Init() error {
if d.Address == "" {
d.Error("config: 'address' not set")
return errors.New("address not set")
return errors.New("config: 'address' not set")
}
return nil
@ -65,7 +64,6 @@ func (d *Dovecot) Init() error {
func (d *Dovecot) Check() error {
mx, err := d.collect()
if err != nil {
d.Error(err)
return err
}

View file

@ -5,6 +5,7 @@ package elasticsearch
import (
_ "embed"
"errors"
"fmt"
"net/http"
"sync"
"time"
@ -87,14 +88,12 @@ func (es *Elasticsearch) Configuration() any {
func (es *Elasticsearch) Init() error {
err := es.validateConfig()
if err != nil {
es.Errorf("check configuration: %v", err)
return err
return fmt.Errorf("check configuration: %v", err)
}
httpClient, err := es.initHTTPClient()
if err != nil {
es.Errorf("init HTTP client: %v", err)
return err
return fmt.Errorf("init HTTP client: %v", err)
}
es.httpClient = httpClient
@ -104,7 +103,6 @@ func (es *Elasticsearch) Init() error {
func (es *Elasticsearch) Check() error {
mx, err := es.collect()
if err != nil {
es.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package envoy
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -75,14 +76,12 @@ func (e *Envoy) Configuration() any {
func (e *Envoy) Init() error {
if err := e.validateConfig(); err != nil {
e.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
prom, err := e.initPrometheusClient()
if err != nil {
e.Errorf("init Prometheus client: %v", err)
return err
return fmt.Errorf("init Prometheus client: %v", err)
}
e.prom = prom
@ -92,7 +91,6 @@ func (e *Envoy) Init() error {
func (e *Envoy) Check() error {
mx, err := e.collect()
if err != nil {
e.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package exim
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -55,8 +56,7 @@ func (e *Exim) Configuration() any {
func (e *Exim) Init() error {
exim, err := e.initEximExec()
if err != nil {
e.Errorf("exim exec initialization: %v", err)
return err
return fmt.Errorf("exim exec initialization: %v", err)
}
e.exec = exim
@ -66,7 +66,6 @@ func (e *Exim) Init() error {
func (e *Exim) Check() error {
mx, err := e.collect()
if err != nil {
e.Error(err)
return err
}

View file

@ -7,6 +7,7 @@ package fail2ban
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -72,8 +73,7 @@ func (f *Fail2Ban) Configuration() any {
func (f *Fail2Ban) Init() error {
f2bClientExec, err := f.initFail2banClientCliExec()
if err != nil {
f.Errorf("fail2ban-client exec initialization: %v", err)
return err
return fmt.Errorf("fail2ban-client exec initialization: %v", err)
}
f.exec = f2bClientExec
@ -83,7 +83,6 @@ func (f *Fail2Ban) Init() error {
func (f *Fail2Ban) Check() error {
mx, err := f.collect()
if err != nil {
f.Error(err)
return err
}

View file

@ -4,6 +4,7 @@ package filecheck
import (
_ "embed"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/pkg/matcher"
@ -80,21 +81,18 @@ func (f *Filecheck) Configuration() any {
func (f *Filecheck) Init() error {
err := f.validateConfig()
if err != nil {
f.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
ff, err := f.initFilesFilter()
if err != nil {
f.Errorf("files filter initialization: %v", err)
return err
return fmt.Errorf("files filter initialization: %v", err)
}
f.filesFilter = ff
df, err := f.initDirsFilter()
if err != nil {
f.Errorf("dirs filter initialization: %v", err)
return err
return fmt.Errorf("dirs filter initialization: %v", err)
}
f.dirsFilter = df

View file

@ -5,6 +5,7 @@ package fluentd
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/pkg/matcher"
@ -64,21 +65,18 @@ func (f *Fluentd) Configuration() any {
func (f *Fluentd) Init() error {
if err := f.validateConfig(); err != nil {
f.Error(err)
return err
return fmt.Errorf("invalid config: %v", err)
}
pm, err := f.initPermitPluginMatcher()
if err != nil {
f.Error(err)
return err
return fmt.Errorf("init permit_plugin_id: %v", err)
}
f.permitPlugin = pm
client, err := f.initApiClient()
if err != nil {
f.Error(err)
return err
return fmt.Errorf("init api client: %v", err)
}
f.apiClient = client
@ -91,7 +89,6 @@ func (f *Fluentd) Init() error {
func (f *Fluentd) Check() error {
mx, err := f.collect()
if err != nil {
f.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package freeradius
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -60,8 +61,7 @@ func (f *FreeRADIUS) Configuration() any {
func (f *FreeRADIUS) Init() error {
if err := f.validateConfig(); err != nil {
f.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
f.client = api.New(api.Config{
@ -77,7 +77,6 @@ func (f *FreeRADIUS) Init() error {
func (f *FreeRADIUS) Check() error {
mx, err := f.collect()
if err != nil {
f.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -60,8 +60,7 @@ func (g *Gearman) Configuration() any {
func (g *Gearman) Init() error {
if g.Address == "" {
g.Error("config: 'address' not set")
return errors.New("address not set")
return errors.New("config: 'address' not set")
}
return nil
@ -70,7 +69,6 @@ func (g *Gearman) Init() error {
func (g *Gearman) Check() error {
mx, err := g.collect()
if err != nil {
g.Error(err)
return err
}

View file

@ -5,6 +5,7 @@ package geth
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -60,14 +61,12 @@ func (g *Geth) Configuration() any {
func (g *Geth) Init() error {
if err := g.validateConfig(); err != nil {
g.Errorf("error on validating config: %g", err)
return err
return fmt.Errorf("error on validating config: %g", err)
}
prom, err := g.initPrometheusClient()
if err != nil {
g.Error(err)
return err
return fmt.Errorf("error on initializing prometheus client: %g", err)
}
g.prom = prom
@ -77,7 +76,6 @@ func (g *Geth) Init() error {
func (g *Geth) Check() error {
mx, err := g.collect()
if err != nil {
g.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package haproxy
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -66,14 +67,12 @@ func (h *Haproxy) Configuration() any {
func (h *Haproxy) Init() error {
if err := h.validateConfig(); err != nil {
h.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
prom, err := h.initPrometheusClient()
if err != nil {
h.Errorf("prometheus client initialization: %v", err)
return err
return fmt.Errorf("prometheus client initialization: %v", err)
}
h.prom = prom
@ -83,7 +82,6 @@ func (h *Haproxy) Init() error {
func (h *Haproxy) Check() error {
mx, err := h.collect()
if err != nil {
h.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package hddtemp
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -58,8 +59,7 @@ func (h *HddTemp) Configuration() any {
func (h *HddTemp) Init() error {
if h.Address == "" {
h.Error("config: 'address' not set")
return errors.New("address not set")
return fmt.Errorf("config: 'address' not set")
}
h.conn = newHddTempConn(h.Config)
@ -70,7 +70,6 @@ func (h *HddTemp) Init() error {
func (h *HddTemp) Check() error {
mx, err := h.collect()
if err != nil {
h.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package hpssa
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -67,12 +68,11 @@ func (h *Hpssa) Configuration() any {
}
func (h *Hpssa) Init() error {
ssacliExec, err := h.initSsacliExec()
ssacli, err := h.initSsacliExec()
if err != nil {
h.Errorf("ssacli exec initialization: %v", err)
return err
return fmt.Errorf("ssacli exec initialization: %v", err)
}
h.exec = ssacliExec
h.exec = ssacli
return nil
}
@ -80,7 +80,6 @@ func (h *Hpssa) Init() error {
func (h *Hpssa) Check() error {
mx, err := h.collect()
if err != nil {
h.Error(err)
return err
}

View file

@ -5,6 +5,7 @@ package httpcheck
import (
_ "embed"
"errors"
"fmt"
"net/http"
"regexp"
"time"
@ -81,30 +82,26 @@ func (hc *HTTPCheck) Configuration() any {
func (hc *HTTPCheck) Init() error {
if err := hc.validateConfig(); err != nil {
hc.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
hc.charts = hc.initCharts()
httpClient, err := hc.initHTTPClient()
if err != nil {
hc.Errorf("init HTTP client: %v", err)
return err
return fmt.Errorf("init HTTP client: %v", err)
}
hc.httpClient = httpClient
re, err := hc.initResponseMatchRegexp()
if err != nil {
hc.Errorf("init response match regexp: %v", err)
return err
return fmt.Errorf("init response match regexp: %v", err)
}
hc.reResponse = re
hm, err := hc.initHeaderMatch()
if err != nil {
hc.Errorf("init header match: %v", err)
return err
return fmt.Errorf("init header match: %v", err)
}
hc.headerMatch = hm
@ -125,7 +122,6 @@ func (hc *HTTPCheck) Init() error {
func (hc *HTTPCheck) Check() error {
mx, err := hc.collect()
if err != nil {
hc.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package icecast
import (
_ "embed"
"errors"
"fmt"
"net/http"
"time"
@ -64,14 +65,12 @@ func (ic *Icecast) Configuration() any {
func (ic *Icecast) Init() error {
if ic.URL == "" {
ic.Error("URL not set")
return errors.New("url not set")
}
client, err := web.NewHTTPClient(ic.ClientConfig)
if err != nil {
ic.Error(err)
return err
return fmt.Errorf("creating http client: %w", err)
}
ic.httpClient = client
@ -84,7 +83,6 @@ func (ic *Icecast) Init() error {
func (ic *Icecast) Check() error {
mx, err := ic.collect()
if err != nil {
ic.Error(err)
return err
}

View file

@ -5,7 +5,7 @@ package intelgpu
import (
_ "embed"
"errors"
"fmt"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
)
@ -58,8 +58,7 @@ func (ig *IntelGPU) Configuration() any {
func (ig *IntelGPU) Init() error {
topExec, err := ig.initIntelGPUTopExec()
if err != nil {
ig.Error(err)
return err
return fmt.Errorf("init intelgpu top exec: %v", err)
}
ig.exec = topExec
@ -70,7 +69,6 @@ func (ig *IntelGPU) Init() error {
func (ig *IntelGPU) Check() error {
mx, err := ig.collect()
if err != nil {
ig.Error(err)
return err
}

View file

@ -5,6 +5,7 @@ package ipfs
import (
_ "embed"
"errors"
"fmt"
"net/http"
"time"
@ -65,14 +66,12 @@ func (ip *IPFS) Configuration() any {
func (ip *IPFS) Init() error {
if ip.URL == "" {
ip.Error("URL not set")
return errors.New("url not set")
}
client, err := web.NewHTTPClient(ip.ClientConfig)
if err != nil {
ip.Error(err)
return err
return fmt.Errorf("http client init: %w", err)
}
ip.httpClient = client
@ -94,7 +93,6 @@ func (ip *IPFS) Init() error {
func (ip *IPFS) Check() error {
mx, err := ip.collect()
if err != nil {
ip.Error(err)
return err
}

View file

@ -7,6 +7,7 @@ package isc_dhcpd
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -67,21 +68,18 @@ func (d *DHCPd) Configuration() any {
func (d *DHCPd) Init() error {
err := d.validateConfig()
if err != nil {
d.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
pools, err := d.initPools()
if err != nil {
d.Errorf("ip pools init: %v", err)
return err
return fmt.Errorf("ip pools init: %v", err)
}
d.pools = pools
charts, err := d.initCharts(pools)
if err != nil {
d.Errorf("charts init: %v", err)
return err
return fmt.Errorf("charts init: %v", err)
}
d.charts = charts
@ -94,7 +92,6 @@ func (d *DHCPd) Init() error {
func (d *DHCPd) Check() error {
mx, err := d.collect()
if err != nil {
d.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package k8s_kubelet
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -71,14 +72,12 @@ func (k *Kubelet) Configuration() any {
func (k *Kubelet) Init() error {
if err := k.validateConfig(); err != nil {
k.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
prom, err := k.initPrometheusClient()
if err != nil {
k.Error(err)
return err
return fmt.Errorf("init prometheus client: %v", err)
}
k.prom = prom
@ -92,7 +91,6 @@ func (k *Kubelet) Init() error {
func (k *Kubelet) Check() error {
mx, err := k.collect()
if err != nil {
k.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package k8s_kubeproxy
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -64,14 +65,12 @@ func (kp *KubeProxy) Configuration() any {
func (kp *KubeProxy) Init() error {
if err := kp.validateConfig(); err != nil {
kp.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
prom, err := kp.initPrometheusClient()
if err != nil {
kp.Error(err)
return err
return fmt.Errorf("init prometheus client: %v", err)
}
kp.prom = prom
@ -81,7 +80,6 @@ func (kp *KubeProxy) Init() error {
func (kp *KubeProxy) Check() error {
mx, err := kp.collect()
if err != nil {
kp.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -80,8 +80,7 @@ func (ks *KubeState) Configuration() any {
func (ks *KubeState) Init() error {
client, err := ks.initClient()
if err != nil {
ks.Errorf("client initialization: %v", err)
return err
return fmt.Errorf("init k8s client: %v", err)
}
ks.client = client
@ -94,15 +93,12 @@ func (ks *KubeState) Init() error {
func (ks *KubeState) Check() error {
if ks.client == nil || ks.discoverer == nil {
ks.Error("not initialized job")
return errors.New("not initialized")
}
ver, err := ks.client.Discovery().ServerVersion()
if err != nil {
err := fmt.Errorf("failed to connect to K8s API server: %v", err)
ks.Error(err)
return err
return fmt.Errorf("failed to connect to K8s API server: %v", err)
}
ks.Infof("successfully connected to the Kubernetes API server '%s'", ver)

View file

@ -64,7 +64,6 @@ func (l *Litespeed) Init() error {
func (l *Litespeed) Check() error {
mx, err := l.collect()
if err != nil {
l.Error(err)
return err
}

View file

@ -65,7 +65,6 @@ func (l *Logind) Init() error {
func (l *Logind) Check() error {
mx, err := l.collect()
if err != nil {
l.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package logstash
import (
_ "embed"
"errors"
"fmt"
"net/http"
"time"
@ -63,14 +64,12 @@ func (l *Logstash) Configuration() any {
func (l *Logstash) Init() error {
if l.URL == "" {
l.Error("config validation: 'url' cannot be empty")
return errors.New("url not set")
return errors.New("config: 'url' cannot be empty")
}
httpClient, err := web.NewHTTPClient(l.ClientConfig)
if err != nil {
l.Errorf("init HTTP client: %v", err)
return err
return fmt.Errorf("init HTTP client: %v", err)
}
l.httpClient = httpClient
@ -83,7 +82,6 @@ func (l *Logstash) Init() error {
func (l *Logstash) Check() error {
mx, err := l.collect()
if err != nil {
l.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -13,6 +13,10 @@ import (
"github.com/netdata/netdata/go/plugins/logger"
)
type lvmCLI interface {
lvsReportJson() ([]byte, error)
}
func newLVMCLIExec(ndsudoPath string, timeout time.Duration, log *logger.Logger) *lvmCLIExec {
return &lvmCLIExec{
Logger: log,

View file

@ -7,6 +7,7 @@ package lvm
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -42,21 +43,16 @@ type Config struct {
Timeout confopt.Duration `yaml:"timeout,omitempty" json:"timeout"`
}
type (
LVM struct {
module.Base
Config `yaml:",inline" json:""`
type LVM struct {
module.Base
Config `yaml:",inline" json:""`
charts *module.Charts
charts *module.Charts
exec lvmCLI
exec lvmCLI
lvmThinPools map[string]bool
}
lvmCLI interface {
lvsReportJson() ([]byte, error)
}
)
lvmThinPools map[string]bool
}
func (l *LVM) Configuration() any {
return l.Config
@ -65,8 +61,7 @@ func (l *LVM) Configuration() any {
func (l *LVM) Init() error {
lvmExec, err := l.initLVMCLIExec()
if err != nil {
l.Errorf("lvm exec initialization: %v", err)
return err
return fmt.Errorf("init lvm exec: %v", err)
}
l.exec = lvmExec
@ -76,7 +71,6 @@ func (l *LVM) Init() error {
func (l *LVM) Check() error {
mx, err := l.collect()
if err != nil {
l.Error(err)
return err
}

View file

@ -7,6 +7,7 @@ package megacli
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -70,8 +71,7 @@ func (m *MegaCli) Configuration() any {
func (m *MegaCli) Init() error {
lvmExec, err := m.initMegaCliExec()
if err != nil {
m.Errorf("megacli exec initialization: %v", err)
return err
return fmt.Errorf("init megacli exec: %v", err)
}
m.exec = lvmExec
@ -81,7 +81,6 @@ func (m *MegaCli) Init() error {
func (m *MegaCli) Check() error {
mx, err := m.collect()
if err != nil {
m.Error(err)
return err
}

View file

@ -62,8 +62,7 @@ func (m *Memcached) Configuration() any {
func (m *Memcached) Init() error {
if m.Address == "" {
m.Error("config: 'address' not set")
return errors.New("address not set")
return errors.New("config: 'address' not set")
}
return nil
@ -72,7 +71,6 @@ func (m *Memcached) Init() error {
func (m *Memcached) Check() error {
mx, err := m.collect()
if err != nil {
m.Error(err)
return err
}

View file

@ -5,6 +5,7 @@ package mongo
import (
_ "embed"
"errors"
"fmt"
"sync"
"time"
@ -76,13 +77,11 @@ func (m *Mongo) Configuration() any {
func (m *Mongo) Init() error {
if err := m.verifyConfig(); err != nil {
m.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
if err := m.initDatabaseSelector(); err != nil {
m.Errorf("init database selector: %v", err)
return err
return fmt.Errorf("init database selector: %v", err)
}
return nil
@ -91,7 +90,6 @@ func (m *Mongo) Init() error {
func (m *Mongo) Check() error {
mx, err := m.collect()
if err != nil {
m.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package monit
import (
_ "embed"
"errors"
"fmt"
"net/http"
"time"
@ -65,14 +66,12 @@ func (m *Monit) Configuration() any {
func (m *Monit) Init() error {
if m.URL == "" {
m.Error("config: monit url is required but not set")
return errors.New("config: missing URL")
return fmt.Errorf("config: monit url is required but not set")
}
httpClient, err := web.NewHTTPClient(m.ClientConfig)
if err != nil {
m.Errorf("init HTTP client: %v", err)
return err
return fmt.Errorf("init HTTP client: %v", err)
}
m.httpClient = httpClient
@ -85,7 +84,6 @@ func (m *Monit) Init() error {
func (m *Monit) Check() error {
mx, err := m.collect()
if err != nil {
m.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -6,6 +6,7 @@ import (
"database/sql"
_ "embed"
"errors"
"fmt"
"strings"
"sync"
"time"
@ -105,24 +106,21 @@ func (m *MySQL) Init() error {
if m.MyCNF != "" {
dsn, err := dsnFromFile(m.MyCNF)
if err != nil {
m.Error(err)
return err
}
m.DSN = dsn
}
if m.DSN == "" {
m.Error("dsn not set")
return errors.New("dsn not set")
return errors.New("config: dsn not set")
}
cfg, err := mysql.ParseDSN(m.DSN)
if err != nil {
m.Errorf("error on parsing DSN: %v", err)
return err
return fmt.Errorf("error on parsing DSN: %v", err)
}
cfg.Passwd = strings.Repeat("*", len(cfg.Passwd))
cfg.Passwd = strings.Repeat("x", len(cfg.Passwd))
m.safeDSN = cfg.FormatDSN()
m.Debugf("using DSN [%s]", m.DSN)
@ -133,7 +131,6 @@ func (m *MySQL) Init() error {
func (m *MySQL) Check() error {
mx, err := m.collect()
if err != nil {
m.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -79,7 +79,6 @@ func (n *Nginx) Init() error {
func (n *Nginx) Check() error {
mx, err := n.collect()
if err != nil {
n.Error(err)
return err
}

View file

@ -5,6 +5,7 @@ package nginxplus
import (
_ "embed"
"errors"
"fmt"
"net/http"
"time"
@ -80,14 +81,12 @@ func (n *NginxPlus) Configuration() any {
func (n *NginxPlus) Init() error {
if n.URL == "" {
n.Error("config validation: 'url' can not be empty'")
return errors.New("url not set")
return errors.New("config: 'url' can not be empty'")
}
client, err := web.NewHTTPClient(n.ClientConfig)
if err != nil {
n.Errorf("init HTTP client: %v", err)
return err
return fmt.Errorf("init HTTP client: %v", err)
}
n.httpClient = client
@ -97,7 +96,6 @@ func (n *NginxPlus) Init() error {
func (n *NginxPlus) Check() error {
mx, err := n.collect()
if err != nil {
n.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -79,7 +79,6 @@ func (n *NginxUnit) Init() error {
func (n *NginxUnit) Check() error {
mx, err := n.collect()
if err != nil {
n.Error(err)
return err
}

View file

@ -5,6 +5,7 @@ package nginxvts
import (
_ "embed"
"errors"
"fmt"
"net/http"
"time"
@ -70,20 +71,18 @@ func (vts *NginxVTS) Cleanup() {
func (vts *NginxVTS) Init() error {
err := vts.validateConfig()
if err != nil {
vts.Errorf("check configuration: %v", err)
return err
return fmt.Errorf("config: %v", err)
}
httpClient, err := vts.initHTTPClient()
if err != nil {
vts.Errorf("init HTTP client: %v", err)
return fmt.Errorf("init HTTP client: %v", err)
}
vts.httpClient = httpClient
charts, err := vts.initCharts()
if err != nil {
vts.Errorf("init charts: %v", err)
return err
return fmt.Errorf("init charts: %v", err)
}
vts.charts = charts
@ -93,7 +92,6 @@ func (vts *NginxVTS) Init() error {
func (vts *NginxVTS) Check() error {
mx, err := vts.collect()
if err != nil {
vts.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -7,6 +7,7 @@ package nsd
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -57,8 +58,7 @@ func (n *Nsd) Configuration() any {
func (n *Nsd) Init() error {
nsdControl, err := n.initNsdControlExec()
if err != nil {
n.Errorf("nsd-control exec initialization: %v", err)
return err
return fmt.Errorf("nsd-control exec initialization: %v", err)
}
n.exec = nsdControl
@ -68,7 +68,6 @@ func (n *Nsd) Init() error {
func (n *Nsd) Check() error {
mx, err := n.collect()
if err != nil {
n.Error(err)
return err
}

View file

@ -75,14 +75,12 @@ func (n *NTPd) Configuration() any {
func (n *NTPd) Init() error {
if n.Address == "" {
n.Error("config validation: 'address' can not be empty")
return errors.New("address not set")
return errors.New("config: 'address' can not be empty")
}
txt := "0.0.0.0 127.0.0.0/8"
r, err := iprange.ParseRanges(txt)
if err != nil {
n.Errorf("error on parsing ip range '%s': %v", txt, err)
return fmt.Errorf("error on parsing ip range '%s': %v", txt, err)
}
@ -94,7 +92,6 @@ func (n *NTPd) Init() error {
func (n *NTPd) Check() error {
mx, err := n.collect()
if err != nil {
n.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -67,7 +67,6 @@ func (nv *NvidiaSmi) Init() error {
if nv.exec == nil {
smi, err := nv.initNvidiaSmiExec()
if err != nil {
nv.Error(err)
return err
}
nv.exec = smi
@ -79,7 +78,6 @@ func (nv *NvidiaSmi) Init() error {
func (nv *NvidiaSmi) Check() error {
mx, err := nv.collect()
if err != nil {
nv.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -7,6 +7,7 @@ package nvme
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -72,8 +73,7 @@ func (n *NVMe) Configuration() any {
func (n *NVMe) Init() error {
nvmeExec, err := n.initNVMeCLIExec()
if err != nil {
n.Errorf("init nvme-cli exec: %v", err)
return err
return fmt.Errorf("init nvme-cli exec: %v", err)
}
n.exec = nvmeExec
@ -83,7 +83,6 @@ func (n *NVMe) Init() error {
func (n *NVMe) Check() error {
mx, err := n.collect()
if err != nil {
n.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -77,7 +77,6 @@ func (l *OpenLDAP) Init() error {
func (l *OpenLDAP) Check() error {
mx, err := l.collect()
if err != nil {
l.Error(err)
return err
}

View file

@ -69,13 +69,11 @@ func (o *OpenVPN) Configuration() any {
func (o *OpenVPN) Init() error {
if err := o.validateConfig(); err != nil {
o.Error(err)
return err
}
m, err := o.initPerUserMatcher()
if err != nil {
o.Error(err)
return err
}
o.perUserMatcher = m
@ -89,14 +87,12 @@ func (o *OpenVPN) Init() error {
func (o *OpenVPN) Check() error {
if err := o.client.Connect(); err != nil {
o.Error(err)
return err
}
defer func() { _ = o.client.Disconnect() }()
ver, err := o.client.Version()
if err != nil {
o.Error(err)
o.Cleanup()
return err
}

View file

@ -5,6 +5,7 @@ package openvpn_status_log
import (
_ "embed"
"errors"
"fmt"
"github.com/netdata/netdata/go/plugins/pkg/matcher"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -53,14 +54,12 @@ func (o *OpenVPNStatusLog) Configuration() any {
func (o *OpenVPNStatusLog) Init() error {
if err := o.validateConfig(); err != nil {
o.Errorf("error on validating config: %v", err)
return err
return fmt.Errorf("error on validating config: %v", err)
}
m, err := o.initPerUserStatsMatcher()
if err != nil {
o.Errorf("error on creating 'per_user_stats' matcher: %v", err)
return err
return fmt.Errorf("error on creating 'per_user_stats' matcher: %v", err)
}
if m != nil {
o.perUserMatcher = m
@ -72,7 +71,6 @@ func (o *OpenVPNStatusLog) Init() error {
func (o *OpenVPNStatusLog) Check() error {
mx, err := o.collect()
if err != nil {
o.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -6,6 +6,7 @@ import (
"database/sql"
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -69,8 +70,7 @@ func (p *PgBouncer) Configuration() any {
func (p *PgBouncer) Init() error {
err := p.validateConfig()
if err != nil {
p.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
return nil
@ -79,7 +79,6 @@ func (p *PgBouncer) Init() error {
func (p *PgBouncer) Check() error {
mx, err := p.collect()
if err != nil {
p.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package phpfpm
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -61,8 +62,7 @@ func (p *Phpfpm) Configuration() any {
func (p *Phpfpm) Init() error {
c, err := p.initClient()
if err != nil {
p.Errorf("init client: %v", err)
return err
return fmt.Errorf("init client: %v", err)
}
p.client = c
@ -72,7 +72,6 @@ func (p *Phpfpm) Init() error {
func (p *Phpfpm) Check() error {
mx, err := p.collect()
if err != nil {
p.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package pihole
import (
_ "embed"
"errors"
"fmt"
"net/http"
"sync"
"time"
@ -73,14 +74,12 @@ func (p *Pihole) Configuration() any {
func (p *Pihole) Init() error {
if err := p.validateConfig(); err != nil {
p.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
httpClient, err := p.initHTTPClient()
if err != nil {
p.Errorf("init http client: %v", err)
return err
return fmt.Errorf("init http client: %v", err)
}
p.httpClient = httpClient
@ -97,7 +96,6 @@ func (p *Pihole) Init() error {
func (p *Pihole) Check() error {
mx, err := p.collect()
if err != nil {
p.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -6,6 +6,7 @@ import (
"context"
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -73,21 +74,18 @@ func (p *Pika) Configuration() any {
func (p *Pika) Init() error {
err := p.validateConfig()
if err != nil {
p.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
pdb, err := p.initRedisClient()
if err != nil {
p.Errorf("init redis client: %v", err)
return err
return fmt.Errorf("init redis client: %v", err)
}
p.pdb = pdb
charts, err := p.initCharts()
if err != nil {
p.Errorf("init charts: %v", err)
return err
return fmt.Errorf("init charts: %v", err)
}
p.charts = charts
@ -97,7 +95,6 @@ func (p *Pika) Init() error {
func (p *Pika) Check() error {
mx, err := p.collect()
if err != nil {
p.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package ping
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/logger"
@ -77,14 +78,12 @@ func (p *Ping) Configuration() any {
func (p *Ping) Init() error {
err := p.validateConfig()
if err != nil {
p.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
pr, err := p.initProber()
if err != nil {
p.Errorf("init prober: %v", err)
return err
return fmt.Errorf("init prober: %v", err)
}
p.prober = pr

View file

@ -5,6 +5,7 @@ package portcheck
import (
_ "embed"
"errors"
"fmt"
"net"
"time"
@ -74,8 +75,7 @@ func (pc *PortCheck) Configuration() any {
func (pc *PortCheck) Init() error {
if err := pc.validateConfig(); err != nil {
pc.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
pc.tcpPorts, pc.udpPorts = pc.initPorts()

View file

@ -5,6 +5,7 @@ package postfix
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -61,14 +62,12 @@ func (p *Postfix) Configuration() any {
func (p *Postfix) Init() error {
if err := p.validateConfig(); err != nil {
p.Errorf("config validation: %s", err)
return err
return fmt.Errorf("config validation: %s", err)
}
pq, err := p.initPostqueueExec()
if err != nil {
p.Errorf("postqueue exec initialization: %v", err)
return err
return fmt.Errorf("postqueue exec initialization: %v", err)
}
p.exec = pq
@ -78,7 +77,6 @@ func (p *Postfix) Init() error {
func (p *Postfix) Check() error {
mx, err := p.collect()
if err != nil {
p.Error(err)
return err
}

View file

@ -6,6 +6,7 @@ import (
"database/sql"
_ "embed"
"errors"
"fmt"
"sync"
"time"
@ -105,14 +106,12 @@ func (p *Postgres) Configuration() any {
func (p *Postgres) Init() error {
err := p.validateConfig()
if err != nil {
p.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
sr, err := p.initDBSelector()
if err != nil {
p.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
p.dbSr = sr
@ -125,7 +124,6 @@ func (p *Postgres) Init() error {
func (p *Postgres) Check() error {
mx, err := p.collect()
if err != nil {
p.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package powerdns
import (
_ "embed"
"errors"
"fmt"
"net/http"
"time"
@ -60,21 +61,18 @@ func (ns *AuthoritativeNS) Configuration() any {
func (ns *AuthoritativeNS) Init() error {
err := ns.validateConfig()
if err != nil {
ns.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
client, err := ns.initHTTPClient()
if err != nil {
ns.Errorf("init HTTP client: %v", err)
return err
return fmt.Errorf("init HTTP client: %v", err)
}
ns.httpClient = client
cs, err := ns.initCharts()
if err != nil {
ns.Errorf("init charts: %v", err)
return err
return fmt.Errorf("init charts: %v", err)
}
ns.charts = cs
@ -84,7 +82,6 @@ func (ns *AuthoritativeNS) Init() error {
func (ns *AuthoritativeNS) Check() error {
mx, err := ns.collect()
if err != nil {
ns.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package powerdns_recursor
import (
_ "embed"
"errors"
"fmt"
"net/http"
"time"
@ -60,21 +61,18 @@ func (r *Recursor) Configuration() any {
func (r *Recursor) Init() error {
err := r.validateConfig()
if err != nil {
r.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
client, err := r.initHTTPClient()
if err != nil {
r.Errorf("init HTTP client: %v", err)
return err
return fmt.Errorf("init HTTP client: %v", err)
}
r.httpClient = client
cs, err := r.initCharts()
if err != nil {
r.Errorf("init charts: %v", err)
return err
return fmt.Errorf("init charts: %v", err)
}
r.charts = cs
@ -84,7 +82,6 @@ func (r *Recursor) Init() error {
func (r *Recursor) Check() error {
mx, err := r.collect()
if err != nil {
r.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package prometheus
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/pkg/matcher"
@ -83,28 +84,24 @@ func (p *Prometheus) Configuration() any {
func (p *Prometheus) Init() error {
if err := p.validateConfig(); err != nil {
p.Errorf("validating config: %v", err)
return err
return fmt.Errorf("validating config: %v", err)
}
prom, err := p.initPrometheusClient()
if err != nil {
p.Errorf("init prometheus client: %v", err)
return err
return fmt.Errorf("init prometheus client: %v", err)
}
p.prom = prom
m, err := p.initFallbackTypeMatcher(p.FallbackType.Counter)
if err != nil {
p.Errorf("init counter fallback type matcher: %v", err)
return err
return fmt.Errorf("init counter fallback type matcher: %v", err)
}
p.fallbackType.counter = m
m, err = p.initFallbackTypeMatcher(p.FallbackType.Gauge)
if err != nil {
p.Errorf("init counter fallback type matcher: %v", err)
return err
return fmt.Errorf("init counter fallback type matcher: %v", err)
}
p.fallbackType.gauge = m
@ -114,7 +111,6 @@ func (p *Prometheus) Init() error {
func (p *Prometheus) Check() error {
mx, err := p.collect()
if err != nil {
p.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -67,7 +67,6 @@ func (p *ProxySQL) Configuration() any {
func (p *ProxySQL) Init() error {
if p.DSN == "" {
p.Error("dsn not set")
return errors.New("dsn not set")
}
@ -79,7 +78,6 @@ func (p *ProxySQL) Init() error {
func (p *ProxySQL) Check() error {
mx, err := p.collect()
if err != nil {
p.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package pulsar
import (
_ "embed"
"errors"
"fmt"
"sync"
"time"
@ -82,21 +83,18 @@ func (p *Pulsar) Configuration() any {
func (p *Pulsar) Init() error {
if err := p.validateConfig(); err != nil {
p.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
prom, err := p.initPrometheusClient()
if err != nil {
p.Error(err)
return err
return fmt.Errorf("init prometheus client: %v", err)
}
p.prom = prom
m, err := p.initTopicFilerMatcher()
if err != nil {
p.Error(err)
return err
return fmt.Errorf("init topic filer: %v", err)
}
p.topicFilter = m
@ -106,7 +104,6 @@ func (p *Pulsar) Init() error {
func (p *Pulsar) Check() error {
mx, err := p.collect()
if err != nil {
p.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package puppet
import (
_ "embed"
"errors"
"fmt"
"net/http"
"time"
@ -60,14 +61,12 @@ func (p *Puppet) Configuration() any {
func (p *Puppet) Init() error {
if p.URL == "" {
p.Error("URL not set")
return errors.New("url not set")
}
client, err := web.NewHTTPClient(p.ClientConfig)
if err != nil {
p.Error(err)
return err
return fmt.Errorf("create http client: %v", err)
}
p.httpClient = client
@ -80,7 +79,6 @@ func (p *Puppet) Init() error {
func (p *Puppet) Check() error {
mx, err := p.collect()
if err != nil {
p.Error(err)
return err
}

View file

@ -5,6 +5,7 @@ package rabbitmq
import (
_ "embed"
"errors"
"fmt"
"net/http"
"time"
@ -75,14 +76,12 @@ func (r *RabbitMQ) Configuration() any {
func (r *RabbitMQ) Init() error {
if r.URL == "" {
r.Error("'url' can not be empty")
return errors.New("url not set")
return errors.New("config: url not set")
}
client, err := web.NewHTTPClient(r.ClientConfig)
if err != nil {
r.Errorf("init HTTP client: %v", err)
return err
return fmt.Errorf("init HTTP client: %v", err)
}
r.httpClient = client
@ -95,7 +94,6 @@ func (r *RabbitMQ) Init() error {
func (r *RabbitMQ) Check() error {
mx, err := r.collect()
if err != nil {
r.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -6,6 +6,7 @@ import (
"context"
_ "embed"
"errors"
"fmt"
"sync"
"time"
@ -86,21 +87,18 @@ func (r *Redis) Configuration() any {
func (r *Redis) Init() error {
err := r.validateConfig()
if err != nil {
r.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
rdb, err := r.initRedisClient()
if err != nil {
r.Errorf("init redis client: %v", err)
return err
return fmt.Errorf("init redis client: %v", err)
}
r.rdb = rdb
charts, err := r.initCharts()
if err != nil {
r.Errorf("init charts: %v", err)
return err
return fmt.Errorf("init charts: %v", err)
}
r.charts = charts
@ -110,7 +108,6 @@ func (r *Redis) Init() error {
func (r *Redis) Check() error {
mx, err := r.collect()
if err != nil {
r.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -63,8 +63,7 @@ func (r *Rethinkdb) Configuration() any {
func (r *Rethinkdb) Init() error {
if r.Address == "" {
r.Error("address is not set")
return errors.New("address is not set")
return errors.New("config: address is not set")
}
return nil
}
@ -72,7 +71,6 @@ func (r *Rethinkdb) Init() error {
func (r *Rethinkdb) Check() error {
mx, err := r.collect()
if err != nil {
r.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package riakkv
import (
_ "embed"
"errors"
"fmt"
"net/http"
"sync"
"time"
@ -70,14 +71,12 @@ func (r *RiakKv) Configuration() any {
func (r *RiakKv) Init() error {
if r.URL == "" {
r.Errorf("url required but not set")
return errors.New("url not set")
return errors.New("config: url not set")
}
httpClient, err := web.NewHTTPClient(r.ClientConfig)
if err != nil {
r.Errorf("init HTTP client: %v", err)
return err
return fmt.Errorf("init HTTP client: %v", err)
}
r.httpClient = httpClient
@ -90,7 +89,6 @@ func (r *RiakKv) Init() error {
func (r *RiakKv) Check() error {
mx, err := r.collect()
if err != nil {
r.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -5,6 +5,7 @@ package rspamd
import (
_ "embed"
"errors"
"fmt"
"net/http"
"time"
@ -60,14 +61,12 @@ func (r *Rspamd) Configuration() any {
func (r *Rspamd) Init() error {
if r.URL == "" {
r.Error("URL not set")
return errors.New("url not set")
return errors.New("config: url not set")
}
client, err := web.NewHTTPClient(r.ClientConfig)
if err != nil {
r.Error(err)
return err
return fmt.Errorf("create http client: %v", err)
}
r.httpClient = client
@ -80,7 +79,6 @@ func (r *Rspamd) Init() error {
func (r *Rspamd) Check() error {
mx, err := r.collect()
if err != nil {
r.Error(err)
return err
}

View file

@ -5,6 +5,7 @@ package samba
import (
_ "embed"
"errors"
"fmt"
"sync"
"time"
@ -58,8 +59,7 @@ func (s *Samba) Configuration() any {
func (s *Samba) Init() error {
smbStatus, err := s.initSmbStatusBinary()
if err != nil {
s.Errorf("smbstatus exec initialization: %v", err)
return err
return fmt.Errorf("smbstatus exec initialization: %v", err)
}
s.exec = smbStatus
@ -69,7 +69,6 @@ func (s *Samba) Init() error {
func (s *Samba) Check() error {
mx, err := s.collect()
if err != nil {
s.Error(err)
return err
}

View file

@ -5,6 +5,7 @@ package scaleio
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -72,14 +73,12 @@ func (s *ScaleIO) Configuration() any {
func (s *ScaleIO) Init() error {
if s.Username == "" || s.Password == "" {
s.Error("username and password aren't set")
return errors.New("username and password aren't set")
return errors.New("config: username and password aren't set")
}
c, err := client.New(s.ClientConfig, s.RequestConfig)
if err != nil {
s.Errorf("error on creating ScaleIO client: %v", err)
return err
return fmt.Errorf("error on creating ScaleIO client: %v", err)
}
s.client = c
@ -91,12 +90,10 @@ func (s *ScaleIO) Init() error {
func (s *ScaleIO) Check() error {
if err := s.client.Login(); err != nil {
s.Error(err)
return err
}
mx, err := s.collect()
if err != nil {
s.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -76,7 +76,6 @@ func (s *Sensors) Init() error {
func (s *Sensors) Check() error {
mx, err := s.collect()
if err != nil {
s.Error(err)
return err
}

View file

@ -7,6 +7,7 @@ package smartctl
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/pkg/matcher"
@ -95,21 +96,18 @@ func (s *Smartctl) Configuration() any {
func (s *Smartctl) Init() error {
if err := s.validateConfig(); err != nil {
s.Errorf("config validation error: %s", err)
return err
return fmt.Errorf("config validation: %s", err)
}
sr, err := s.initDeviceSelector()
if err != nil {
s.Errorf("device selector initialization: %v", err)
return err
return fmt.Errorf("device selector initialization: %v", err)
}
s.deviceSr = sr
smartctlExec, err := s.initSmartctlCli()
if err != nil {
s.Errorf("smartctl exec initialization: %v", err)
return err
return fmt.Errorf("smartctl exec initialization: %v", err)
}
s.exec = smartctlExec
@ -119,7 +117,6 @@ func (s *Smartctl) Init() error {
func (s *Smartctl) Check() error {
mx, err := s.collect()
if err != nil {
s.Error(err)
return err
}

View file

@ -5,6 +5,7 @@ package snmp
import (
_ "embed"
"errors"
"fmt"
"github.com/netdata/netdata/go/plugins/pkg/matcher"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -85,35 +86,30 @@ func (s *SNMP) Configuration() any {
func (s *SNMP) Init() error {
err := s.validateConfig()
if err != nil {
s.Errorf("config validation failed: %v", err)
return err
return fmt.Errorf("config validation failed: %v", err)
}
snmpClient, err := s.initSNMPClient()
if err != nil {
s.Errorf("failed to initialize SNMP client: %v", err)
return err
return fmt.Errorf("failed to initialize SNMP client: %v", err)
}
err = snmpClient.Connect()
if err != nil {
s.Errorf("SNMP client connection failed: %v", err)
return err
return fmt.Errorf("SNMP client connection failed: %v", err)
}
s.snmpClient = snmpClient
byName, byType, err := s.initNetIfaceFilters()
if err != nil {
s.Errorf("failed to initialize network interface filters: %v", err)
return err
return fmt.Errorf("failed to initialize network interface filters: %v", err)
}
s.netIfaceFilterByName = byName
s.netIfaceFilterByType = byType
charts, err := newUserInputCharts(s.ChartsInput)
if err != nil {
s.Errorf("failed to create user charts: %v", err)
return err
return fmt.Errorf("failed to create user charts: %v", err)
}
s.charts = charts
@ -125,7 +121,6 @@ func (s *SNMP) Init() error {
func (s *SNMP) Check() error {
mx, err := s.collect()
if err != nil {
s.Error(err)
return err
}

View file

@ -5,6 +5,7 @@ package squid
import (
_ "embed"
"errors"
"fmt"
"net/http"
"time"
@ -60,14 +61,12 @@ func (s *Squid) Configuration() any {
func (s *Squid) Init() error {
if s.URL == "" {
s.Error("URL not set")
return errors.New("url not set")
return errors.New("config: url not set")
}
client, err := web.NewHTTPClient(s.ClientConfig)
if err != nil {
s.Error(err)
return err
return fmt.Errorf("init http client: %w", err)
}
s.httpClient = client
@ -80,7 +79,6 @@ func (s *Squid) Init() error {
func (s *Squid) Check() error {
mx, err := s.collect()
if err != nil {
s.Error(err)
return err
}

View file

@ -4,6 +4,7 @@ package squidlog
import (
_ "embed"
"fmt"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
"github.com/netdata/netdata/go/plugins/plugin/go.d/pkg/logs"
@ -72,18 +73,15 @@ func (s *SquidLog) Init() error {
func (s *SquidLog) Check() error {
// Note: these inits are here to make auto-detection retry working
if err := s.createLogReader(); err != nil {
s.Warning("check failed: ", err)
return err
return fmt.Errorf("failed to create log reader: %v", err)
}
if err := s.createParser(); err != nil {
s.Warning("check failed: ", err)
return err
return fmt.Errorf("failed to create log parser: %v", err)
}
if err := s.createCharts(s.line); err != nil {
s.Warning("check failed: ", err)
return err
return fmt.Errorf("failed to create log charts: %v", err)
}
return nil

View file

@ -7,6 +7,7 @@ package storcli
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -70,8 +71,7 @@ func (s *StorCli) Configuration() any {
func (s *StorCli) Init() error {
storExec, err := s.initStorCliExec()
if err != nil {
s.Errorf("storcli exec initialization: %v", err)
return err
return fmt.Errorf("storcli exec initialization: %v", err)
}
s.exec = storExec
@ -81,7 +81,6 @@ func (s *StorCli) Init() error {
func (s *StorCli) Check() error {
mx, err := s.collect()
if err != nil {
s.Error(err)
return err
}

View file

@ -5,6 +5,7 @@ package supervisord
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -67,14 +68,12 @@ func (s *Supervisord) Configuration() any {
func (s *Supervisord) Init() error {
err := s.verifyConfig()
if err != nil {
s.Errorf("verify config: %v", err)
return err
return fmt.Errorf("verify config: %v", err)
}
client, err := s.initSupervisorClient()
if err != nil {
s.Errorf("init supervisord client: %v", err)
return err
return fmt.Errorf("init supervisord client: %v", err)
}
s.client = client
@ -84,7 +83,6 @@ func (s *Supervisord) Init() error {
func (s *Supervisord) Check() error {
mx, err := s.collect()
if err != nil {
s.Error(err)
return err
}
if len(mx) == 0 {

View file

@ -7,6 +7,7 @@ package systemdunits
import (
_ "embed"
"errors"
"fmt"
"time"
"github.com/netdata/netdata/go/plugins/pkg/matcher"
@ -84,14 +85,12 @@ func (s *SystemdUnits) Configuration() any {
func (s *SystemdUnits) Init() error {
if err := s.validateConfig(); err != nil {
s.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
sr, err := s.initUnitSelector()
if err != nil {
s.Errorf("init unit selector: %v", err)
return err
return fmt.Errorf("init unit selector: %v", err)
}
s.unitSr = sr
@ -106,7 +105,6 @@ func (s *SystemdUnits) Init() error {
func (s *SystemdUnits) Check() error {
mx, err := s.collect()
if err != nil {
s.Error(err)
return err
}

View file

@ -5,6 +5,7 @@ package tengine
import (
_ "embed"
"errors"
"fmt"
"net/http"
"time"
@ -60,14 +61,12 @@ func (t *Tengine) Configuration() any {
func (t *Tengine) Init() error {
if t.URL == "" {
t.Error("url not set")
return errors.New("url not set")
return errors.New("config: url not set")
}
httpClient, err := web.NewHTTPClient(t.ClientConfig)
if err != nil {
t.Errorf("error on creating http client : %v", err)
return err
return fmt.Errorf("error on creating http client : %v", err)
}
t.httpClient = httpClient
@ -80,7 +79,6 @@ func (t *Tengine) Init() error {
func (t *Tengine) Check() error {
mx, err := t.collect()
if err != nil {
t.Error(err)
return err
}

View file

@ -4,6 +4,7 @@ package testrandom
import (
_ "embed"
"fmt"
"math/rand"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@ -74,14 +75,12 @@ func (tr *TestRandom) Configuration() any {
func (tr *TestRandom) Init() error {
err := tr.validateConfig()
if err != nil {
tr.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
charts, err := tr.initCharts()
if err != nil {
tr.Errorf("charts init: %v", err)
return err
return fmt.Errorf("charts init: %v", err)
}
tr.charts = charts
return nil

View file

@ -5,6 +5,7 @@ package tomcat
import (
_ "embed"
"errors"
"fmt"
"net/http"
"time"
@ -65,14 +66,12 @@ func (t *Tomcat) Configuration() any {
func (t *Tomcat) Init() error {
if err := t.validateConfig(); err != nil {
t.Errorf("config validation: %v", err)
return err
return fmt.Errorf("config validation: %v", err)
}
httpClient, err := t.initHTTPClient()
if err != nil {
t.Errorf("init HTTP client: %v", err)
return err
return fmt.Errorf("init HTTP client: %v", err)
}
t.httpClient = httpClient
@ -86,7 +85,6 @@ func (t *Tomcat) Init() error {
func (t *Tomcat) Check() error {
mx, err := t.collect()
if err != nil {
t.Error(err)
return err
}

View file

@ -56,8 +56,7 @@ func (t *Tor) Configuration() any {
func (t *Tor) Init() error {
if t.Address == "" {
t.Error("config: 'address' not set")
return errors.New("address not set")
return errors.New("config: address not set")
}
return nil
@ -66,7 +65,6 @@ func (t *Tor) Init() error {
func (t *Tor) Check() error {
mx, err := t.collect()
if err != nil {
t.Error(err)
return err
}

Some files were not shown because too many files have changed in this diff Show more