archive/netdata_netdata
0
0
Fork 0
mirror of https://github.com/netdata/netdata.git synced 2025-04-28 14:42:31 +00:00
Code Issues Projects Releases Wiki Activity

Acquire datafile for deletion before calculating retention ()

Browse source 
Make sure datafile is acquired before update_metrics_first_time_s
This commit is contained in:
Stelios Fragkakis 2025-03-11 00:29:08 +02:00 • committed by GitHub
parent ec48ad55ef
commit 94ebd49f03
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions

6
src/database/engine/rrdengine.c
View file

@ -1218,9 +1218,6 @@ void datafile_delete(struct rrdengine_instance *ctx, struct rrdengine_datafile *
bool datafile_got_for_deletion = datafile_acquire_for_deletion(datafile, false);
if (update_retention)
update_metrics_first_time_s(ctx, datafile, datafile->next, worker);
while (!datafile_got_for_deletion) {
if(worker)
worker_is_busy(UV_EVENT_DBENGINE_DATAFILE_DELETE_WAIT);
@ -1239,6 +1236,9 @@ void datafile_delete(struct rrdengine_instance *ctx, struct rrdengine_datafile *
}
}
if (update_retention)
update_metrics_first_time_s(ctx, datafile, datafile->next, worker);
__atomic_add_fetch(&rrdeng_cache_efficiency_stats.datafile_deletion_started, 1, __ATOMIC_RELAXED);
netdata_log_info("DBENGINE: deleting data file '%s/"
DATAFILE_PREFIX RRDENG_FILE_NUMBER_PRINT_TMPL DATAFILE_EXTENSION