archive/netdata_netdata
0
0
Fork 0
mirror of https://github.com/netdata/netdata.git synced 2025-04-27 22:26:21 +00:00
Code Issues Projects Releases Wiki Activity

remove old obsolete check for excess data in request ()

Browse source
This commit is contained in:
Costa Tsaousis 2024-10-21 11:04:00 +03:00 • committed by GitHub
parent 87b3b9633b
commit 99c82c846a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 0 additions and 19 deletions

18
src/web/server/web_client.c
View file

@ -740,17 +740,6 @@ HTTP_VALIDATION http_request_validate(struct web_client *w) {
return HTTP_VALIDATION_NOT_SUPPORTED; return HTTP_VALIDATION_NOT_SUPPORTED;
} else if (!is_it_valid) { } else if (!is_it_valid) {
//Invalid request, we have more data after the end of message
char *check = strstr((char *)buffer_tostring(w->response.data), "\r\n\r\n");
if(check) {
check += 4;
if (*check) {
w->header_parse_tries = 0;
w->header_parse_last_size = 0;
web_client_disable_wait_receive(w);
return HTTP_VALIDATION_EXCESS_REQUEST_DATA;
}
}
web_client_enable_wait_receive(w); web_client_enable_wait_receive(w);
return HTTP_VALIDATION_INCOMPLETE; return HTTP_VALIDATION_INCOMPLETE;
} }
@ -1473,13 +1462,6 @@ void web_client_process_request_from_web_server(struct web_client *w) {
buffer_strcat(w->response.data, "Malformed URL...\r\n"); buffer_strcat(w->response.data, "Malformed URL...\r\n");
w->response.code = HTTP_RESP_BAD_REQUEST; w->response.code = HTTP_RESP_BAD_REQUEST;
break; break;
case HTTP_VALIDATION_EXCESS_REQUEST_DATA:
netdata_log_debug(D_WEB_CLIENT_ACCESS, "%llu: Excess data in request '%s'.", w->id, w->response.data->buffer);
buffer_flush(w->response.data);
buffer_strcat(w->response.data, "Excess data in request.\r\n");
w->response.code = HTTP_RESP_BAD_REQUEST;
break;
case HTTP_VALIDATION_TOO_MANY_READ_RETRIES: case HTTP_VALIDATION_TOO_MANY_READ_RETRIES:
netdata_log_debug(D_WEB_CLIENT_ACCESS, "%llu: Too many retries to read request '%s'.", w->id, w->response.data->buffer); netdata_log_debug(D_WEB_CLIENT_ACCESS, "%llu: Too many retries to read request '%s'.", w->id, w->response.data->buffer);

1
src/web/server/web_client.h
View file

@ -18,7 +18,6 @@ typedef enum __attribute__((packed)) {
HTTP_VALIDATION_OK, HTTP_VALIDATION_OK,
HTTP_VALIDATION_NOT_SUPPORTED, HTTP_VALIDATION_NOT_SUPPORTED,
HTTP_VALIDATION_TOO_MANY_READ_RETRIES, HTTP_VALIDATION_TOO_MANY_READ_RETRIES,
HTTP_VALIDATION_EXCESS_REQUEST_DATA,
HTTP_VALIDATION_MALFORMED_URL, HTTP_VALIDATION_MALFORMED_URL,
HTTP_VALIDATION_INCOMPLETE, HTTP_VALIDATION_INCOMPLETE,
HTTP_VALIDATION_REDIRECT HTTP_VALIDATION_REDIRECT