Move aclk/ under src/ (#16899)

* Move aclk/ under src/

* Update labeler

.github/labeler.yml

@@ -14,15 +14,15 @@ area/ACLK:
   - any:
       - changed-files:
           - any-glob-to-any-file:
-              - aclk/**
-              - database/sqlite/sqlite_aclk*
-              - mqtt_websockets
+              - src/aclk/**
+              - src/database/sqlite/sqlite_aclk*
+              - src/aclk/mqtt_websockets
 
 area/claim:
   - any:
       - changed-files:
           - any-glob-to-any-file:
-              - claim/*
+              - src/claim/*
 
 area/exporting:
   - any:
@@ -57,7 +57,7 @@ area/database:
   - any:
       - changed-files:
           - any-glob-to-any-file:
-              - database/**
+              - src/database/**
 
 area/docs:
   - any:
@@ -233,7 +233,7 @@ area/ml:
   - any:
       - changed-files:
           - any-glob-to-any-file:
-              - ml/**
+              - src/ml/**
 
 area/packaging:
   - any:
@@ -250,13 +250,13 @@ area/registry:
   - any:
       - changed-files:
           - any-glob-to-any-file:
-              - registry/**
+              - src/registry/**
 
 area/streaming:
   - any:
       - changed-files:
           - any-glob-to-any-file:
-              - streaming/**
+              - src/streaming/**
 
 area/tests:
   - any:

.gitmodules

@@ -1,5 +1,5 @@
 [submodule "aclk/aclk-schemas"]
-	path = aclk/aclk-schemas
+	path = src/aclk/aclk-schemas
 	url = https://github.com/netdata/aclk-schemas.git
 [submodule "ml/kmeans/dlib"]
 	path = src/ml/dlib

CMakeLists.txt

@@ -1150,17 +1150,17 @@ set(SPAWN_PLUGIN_FILES
 )
 
 set(ACLK_ALWAYS_BUILD
-        aclk/aclk_rrdhost_state.h
-        aclk/aclk_proxy.c
-        aclk/aclk_proxy.h
-        aclk/aclk.c
-        aclk/aclk.h
-        aclk/aclk_capas.c
-        aclk/aclk_capas.h
-        aclk/aclk_util.c
-        aclk/aclk_util.h
-        aclk/https_client.c
-        aclk/https_client.h
+        src/aclk/aclk_rrdhost_state.h
+        src/aclk/aclk_proxy.c
+        src/aclk/aclk_proxy.h
+        src/aclk/aclk.c
+        src/aclk/aclk.h
+        src/aclk/aclk_capas.c
+        src/aclk/aclk_capas.h
+        src/aclk/aclk_util.c
+        src/aclk/aclk_util.h
+        src/aclk/https_client.c
+        src/aclk/https_client.h
 )
 
 set(TIMEX_PLUGIN_FILES
@@ -1343,83 +1343,83 @@ elseif(FREEBSD)
 endif()
 
 set(MQTT_WEBSOCKETS_FILES
-        aclk/mqtt_websockets/mqtt_wss_client.c
-        aclk/mqtt_websockets/mqtt_wss_client.h
-        aclk/mqtt_websockets/mqtt_wss_log.c
-        aclk/mqtt_websockets/mqtt_wss_log.h
-        aclk/mqtt_websockets/ws_client.c
-        aclk/mqtt_websockets/ws_client.h
-        aclk/mqtt_websockets/mqtt_ng.c
-        aclk/mqtt_websockets/mqtt_ng.h
-        aclk/mqtt_websockets/common_public.c
-        aclk/mqtt_websockets/common_public.h
-        aclk/mqtt_websockets/common_internal.h
-        aclk/mqtt_websockets/c-rbuf/cringbuffer.c
-        aclk/mqtt_websockets/c-rbuf/cringbuffer.h
-        aclk/mqtt_websockets/c-rbuf/cringbuffer_internal.h
-        aclk/mqtt_websockets/c_rhash/c_rhash.c
-        aclk/mqtt_websockets/c_rhash/c_rhash.h
-        aclk/mqtt_websockets/c_rhash/c_rhash_internal.h
+        src/aclk/mqtt_websockets/mqtt_wss_client.c
+        src/aclk/mqtt_websockets/mqtt_wss_client.h
+        src/aclk/mqtt_websockets/mqtt_wss_log.c
+        src/aclk/mqtt_websockets/mqtt_wss_log.h
+        src/aclk/mqtt_websockets/ws_client.c
+        src/aclk/mqtt_websockets/ws_client.h
+        src/aclk/mqtt_websockets/mqtt_ng.c
+        src/aclk/mqtt_websockets/mqtt_ng.h
+        src/aclk/mqtt_websockets/common_public.c
+        src/aclk/mqtt_websockets/common_public.h
+        src/aclk/mqtt_websockets/common_internal.h
+        src/aclk/mqtt_websockets/c-rbuf/cringbuffer.c
+        src/aclk/mqtt_websockets/c-rbuf/cringbuffer.h
+        src/aclk/mqtt_websockets/c-rbuf/cringbuffer_internal.h
+        src/aclk/mqtt_websockets/c_rhash/c_rhash.c
+        src/aclk/mqtt_websockets/c_rhash/c_rhash.h
+        src/aclk/mqtt_websockets/c_rhash/c_rhash_internal.h
 )
 
 set(ACLK_PROTO_DEFS
-        aclk/aclk-schemas/proto/aclk/v1/lib.proto
-        aclk/aclk-schemas/proto/agent/v1/disconnect.proto
-        aclk/aclk-schemas/proto/agent/v1/connection.proto
-        aclk/aclk-schemas/proto/alarm/v1/config.proto
-        aclk/aclk-schemas/proto/alarm/v1/stream.proto
-        aclk/aclk-schemas/proto/nodeinstance/connection/v1/connection.proto
-        aclk/aclk-schemas/proto/nodeinstance/create/v1/creation.proto
-        aclk/aclk-schemas/proto/nodeinstance/info/v1/info.proto
-        aclk/aclk-schemas/proto/context/v1/context.proto
-        aclk/aclk-schemas/proto/context/v1/stream.proto
-        aclk/aclk-schemas/proto/agent/v1/cmds.proto
+        src/aclk/aclk-schemas/proto/aclk/v1/lib.proto
+        src/aclk/aclk-schemas/proto/agent/v1/disconnect.proto
+        src/aclk/aclk-schemas/proto/agent/v1/connection.proto
+        src/aclk/aclk-schemas/proto/alarm/v1/config.proto
+        src/aclk/aclk-schemas/proto/alarm/v1/stream.proto
+        src/aclk/aclk-schemas/proto/nodeinstance/connection/v1/connection.proto
+        src/aclk/aclk-schemas/proto/nodeinstance/create/v1/creation.proto
+        src/aclk/aclk-schemas/proto/nodeinstance/info/v1/info.proto
+        src/aclk/aclk-schemas/proto/context/v1/context.proto
+        src/aclk/aclk-schemas/proto/context/v1/stream.proto
+        src/aclk/aclk-schemas/proto/agent/v1/cmds.proto
 )
 
 set(ACLK_FILES
-        aclk/aclk_stats.c
-        aclk/aclk_stats.h
-        aclk/aclk_query.c
-        aclk/aclk_query.h
-        aclk/aclk_query_queue.c
-        aclk/aclk_query_queue.h
-        aclk/aclk_otp.c
-        aclk/aclk_otp.h
-        aclk/aclk_tx_msgs.c
-        aclk/aclk_tx_msgs.h
-        aclk/aclk_rx_msgs.c
-        aclk/aclk_rx_msgs.h
-        aclk/aclk_alarm_api.c
-        aclk/aclk_alarm_api.h
-        aclk/aclk_contexts_api.c
-        aclk/aclk_contexts_api.h
-        aclk/schema-wrappers/connection.cc
-        aclk/schema-wrappers/connection.h
-        aclk/schema-wrappers/node_connection.cc
-        aclk/schema-wrappers/node_connection.h
-        aclk/schema-wrappers/node_creation.cc
-        aclk/schema-wrappers/node_creation.h
-        aclk/schema-wrappers/alarm_stream.cc
-        aclk/schema-wrappers/alarm_stream.h
-        aclk/schema-wrappers/alarm_config.cc
-        aclk/schema-wrappers/alarm_config.h
-        aclk/schema-wrappers/node_info.cc
-        aclk/schema-wrappers/node_info.h
-        aclk/schema-wrappers/capability.cc
-        aclk/schema-wrappers/capability.h
-        aclk/schema-wrappers/proto_2_json.cc
-        aclk/schema-wrappers/proto_2_json.h
-        aclk/schema-wrappers/context_stream.cc
-        aclk/schema-wrappers/context_stream.h
-        aclk/schema-wrappers/context.cc
-        aclk/schema-wrappers/context.h
-        aclk/schema-wrappers/schema_wrappers.h
-        aclk/schema-wrappers/schema_wrapper_utils.cc
-        aclk/schema-wrappers/schema_wrapper_utils.h
-        aclk/schema-wrappers/agent_cmds.cc
-        aclk/schema-wrappers/agent_cmds.h
-        aclk/helpers/mqtt_wss_pal.h
-        aclk/helpers/ringbuffer_pal.h
+        src/aclk/aclk_stats.c
+        src/aclk/aclk_stats.h
+        src/aclk/aclk_query.c
+        src/aclk/aclk_query.h
+        src/aclk/aclk_query_queue.c
+        src/aclk/aclk_query_queue.h
+        src/aclk/aclk_otp.c
+        src/aclk/aclk_otp.h
+        src/aclk/aclk_tx_msgs.c
+        src/aclk/aclk_tx_msgs.h
+        src/aclk/aclk_rx_msgs.c
+        src/aclk/aclk_rx_msgs.h
+        src/aclk/aclk_alarm_api.c
+        src/aclk/aclk_alarm_api.h
+        src/aclk/aclk_contexts_api.c
+        src/aclk/aclk_contexts_api.h
+        src/aclk/schema-wrappers/connection.cc
+        src/aclk/schema-wrappers/connection.h
+        src/aclk/schema-wrappers/node_connection.cc
+        src/aclk/schema-wrappers/node_connection.h
+        src/aclk/schema-wrappers/node_creation.cc
+        src/aclk/schema-wrappers/node_creation.h
+        src/aclk/schema-wrappers/alarm_stream.cc
+        src/aclk/schema-wrappers/alarm_stream.h
+        src/aclk/schema-wrappers/alarm_config.cc
+        src/aclk/schema-wrappers/alarm_config.h
+        src/aclk/schema-wrappers/node_info.cc
+        src/aclk/schema-wrappers/node_info.h
+        src/aclk/schema-wrappers/capability.cc
+        src/aclk/schema-wrappers/capability.h
+        src/aclk/schema-wrappers/proto_2_json.cc
+        src/aclk/schema-wrappers/proto_2_json.h
+        src/aclk/schema-wrappers/context_stream.cc
+        src/aclk/schema-wrappers/context_stream.h
+        src/aclk/schema-wrappers/context.cc
+        src/aclk/schema-wrappers/context.h
+        src/aclk/schema-wrappers/schema_wrappers.h
+        src/aclk/schema-wrappers/schema_wrapper_utils.cc
+        src/aclk/schema-wrappers/schema_wrapper_utils.h
+        src/aclk/schema-wrappers/agent_cmds.cc
+        src/aclk/schema-wrappers/agent_cmds.h
+        src/aclk/helpers/mqtt_wss_pal.h
+        src/aclk/helpers/ringbuffer_pal.h
 )
 
 
@@ -1715,8 +1715,8 @@ if(ENABLE_ACLK)
         #
         # proto definitions
         #
-        protoc_generate_cpp("${CMAKE_SOURCE_DIR}/aclk/aclk-schemas"
-                            "${CMAKE_SOURCE_DIR}/aclk/aclk-schemas"
+        protoc_generate_cpp("${CMAKE_SOURCE_DIR}/src/aclk/aclk-schemas"
+                            "${CMAKE_SOURCE_DIR}/src/aclk/aclk-schemas"
                             ACLK_PROTO_BUILT_SRCS
                             ACLK_PROTO_BUILT_HDRS
                             ${ACLK_PROTO_DEFS})
@@ -2082,7 +2082,7 @@ target_compile_definitions(netdata PRIVATE
 
 target_include_directories(netdata PRIVATE
         "$<$<BOOL:${ENABLE_PROTOBUF}>:${PROTOBUF_INCLUDE_DIRS}>"
-        "$<$<BOOL:${ENABLE_ACLK}>:${CMAKE_SOURCE_DIR}/aclk/aclk-schemas>"
+        "$<$<BOOL:${ENABLE_ACLK}>:${CMAKE_SOURCE_DIR}/src/aclk/aclk-schemas>"
         "$<$<BOOL:${ENABLE_EXPORTER_MONGODB}>:${MONGOC_INCLUDE_DIRS}>"
         "$<$<BOOL:${ENABLE_EXPORTER_PROMETHEUS_REMOTE_WRITE}>:${SNAPPY_INCLUDE_DIRS}>"
 )

docs/category-overview-pages/deployment-strategies.md

@@ -77,7 +77,7 @@ An API key is a key created with `uuidgen` and is used for authentication and/or
 
 #### Child config
 
-As mentioned above, the recommendation is to not claim the Child to Cloud directly during your setup, avoiding establishing an [ACLK](https://github.com/netdata/netdata/blob/master/aclk/README.md) connection.
+As mentioned above, the recommendation is to not claim the Child to Cloud directly during your setup, avoiding establishing an [ACLK](https://github.com/netdata/netdata/blob/master/src/aclk/README.md) connection.
 
 To reduce the footprint of the Netdata Agent on your production system, some capabilities can be switched OFF on the Child and kept ON on the Parent. In this example, Machine Learning and Alerting are disabled in the Child, so that the Parent can take the load. We also use RAM instead of disk to store metrics with limited retention, covering temporary network issues.
 

docs/category-overview-pages/secure-nodes.md

@@ -47,7 +47,7 @@ This is the _recommended method for those who have connected their nodes to Netd
 metrics using the War Room Overview, Nodes tab, and Cloud dashboards.
 
 You can disable the local dashboard (and API) but retain the encrypted Agent-Cloud link 
-([ACLK](https://github.com/netdata/netdata/blob/master/aclk/README.md)) that
+([ACLK](https://github.com/netdata/netdata/blob/master/src/aclk/README.md)) that
 allows you to stream metrics on demand from your nodes via the Netdata Cloud interface. This change mitigates all
 concerns about revealing metrics and system design to the internet at large, while keeping all the functionality you
 need to view metrics and troubleshoot issues with Netdata Cloud.

docs/cloud/netdata-functions.md

@@ -63,14 +63,14 @@ Since these functions are able to execute routines on the node and due to the po
 concern is to ensure no sensitive information or disruptive actions are exposed through the Agent's API.
 
 With the communication between the Netdata Agent and Netdata Cloud being
-through [ACLK](https://github.com/netdata/netdata/blob/master/aclk/README.md) this
+through [ACLK](https://github.com/netdata/netdata/blob/master/src/aclk/README.md) this
 concern is addressed.
 
 ## Related Topics
 
 ### **Related Concepts**
 
-- [ACLK](https://github.com/netdata/netdata/blob/master/aclk/README.md)
+- [ACLK](https://github.com/netdata/netdata/blob/master/src/aclk/README.md)
 - [plugins.d](https://github.com/netdata/netdata/blob/master/collectors/plugins.d/README.md)
 
 ### Related Tasks

docs/contributing/style-guide.md

@@ -473,7 +473,7 @@ The following tables describe the standard spelling, capitalization, and usage o
 | **Netdata community forum** | The Discourse-powered forum for feature requests, Netdata Cloud technical support, and conversations about Netdata's monitoring and troubleshooting products.                                                                                                                                                                                                                                                         |
 | **node**                    | A system on which the Netdata Agent is installed. The system can be physical, virtual, in a Docker container, and more. Depending on your infrastructure, you may have one, dozens, or hundreds of nodes. Some nodes are _ephemeral_, in that they're created/destroyed automatically by an orchestrator service.                                                                                                     |
 | **Space**                   | The highest level container within Netdata Cloud for a user to organize their team members and nodes within their infrastructure. A Space likely represents an entire organization or a large team. <br /><br />_Space_ is always capitalized.                                                                                                                                                                        |
-| **unreachable node**        | A connected node with a disrupted [Agent-Cloud link](https://github.com/netdata/netdata/blob/master/aclk/README.md). Unreachable could mean the node no longer exists or is experiencing network connectivity issues with Cloud.                                                                                                                                                                                      |
+| **unreachable node**        | A connected node with a disrupted [Agent-Cloud link](https://github.com/netdata/netdata/blob/master/src/aclk/README.md). Unreachable could mean the node no longer exists or is experiencing network connectivity issues with Cloud.                                                                                                                                                                                      |
 | **visited node**            | A node which has had its Agent dashboard directly visited by a user. A list of these is maintained on a per-user basis.                                                                                                                                                                                                                                                                                               |
 | **War Room**                | A smaller grouping of nodes where users can view key metrics in real-time and monitor the health of many nodes with their alert status. War Rooms can be used to organize nodes in any way that makes sense for your infrastructure, such as by a service, purpose, physical location, and more.  <br /><br />_War Room_ is always capitalized.                                                                       |
 

docs/glossary.md

@@ -15,7 +15,7 @@ Use the alphabatized list below to find the answer to your single-term questions
 
 - [**Agent** or **Netdata Agent**](https://github.com/netdata/netdata/blob/master/packaging/installer/README.md): Netdata's distributed monitoring Agent collects thousands of metrics from systems, hardware, and applications with zero configuration. It runs permanently on all your physical/virtual servers, containers, cloud deployments, and edge/IoT devices.
 
-- [**Agent-cloud link** or **ACLK**](https://github.com/netdata/netdata/blob/master/aclk/README.md): The Agent-Cloud link (ACLK) is the mechanism responsible for securely connecting a Netdata Agent to your web browser through Netdata Cloud.
+- [**Agent-cloud link** or **ACLK**](https://github.com/netdata/netdata/blob/master/src/aclk/README.md): The Agent-Cloud link (ACLK) is the mechanism responsible for securely connecting a Netdata Agent to your web browser through Netdata Cloud.
 
 - [**Aggregate Function**](https://github.com/netdata/netdata/blob/master/docs/cloud/visualize/interact-new-charts.md#aggregate-functions-over-time): A function applied When the granularity of the data collected is higher than the plotted points on the chart.
 

src/aclk/mqtt_websockets/c-rbuf/cringbuffer.c

@@ -13,7 +13,7 @@
 // this allows user to use their own
 // custom memory allocation functions
 #ifdef RBUF_CUSTOM_MALLOC
-#include "ringbuffer_pal.h"
+#include "../../helpers/ringbuffer_pal.h"
 #else
 #define crbuf_malloc(...) malloc(__VA_ARGS__)
 #define crbuf_free(...) free(__VA_ARGS__)

src/aclk/mqtt_websockets/common_internal.h

@@ -6,7 +6,7 @@
 #include "endian_compat.h"
 
 #ifdef MQTT_WSS_CUSTOM_ALLOC
-#include "mqtt_wss_pal.h"
+#include "../helpers/mqtt_wss_pal.h"
 #else
 #define mw_malloc(...) malloc(__VA_ARGS__)
 #define mw_calloc(...) calloc(__VA_ARGS__)

src/claim/README.md

@@ -4,7 +4,7 @@ This page will guide you through connecting a Netdata Agent to Netdata Cloud sec
 
 You can securely connect a Netdata Agent, running on a distributed node, to Netdata Cloud. A Space's
 administrator creates a **claiming token**, which is used to add an Agent to their Space via the [Agent-Cloud link
-(ACLK)](https://github.com/netdata/netdata/blob/master/aclk/README.md).
+(ACLK)](https://github.com/netdata/netdata/blob/master/src/aclk/README.md).
 
 Are you just getting started with Netdata Cloud? You can find simplified instructions in the [Install Netdata documentation](https://github.com/netdata/netdata/blob/master/packaging/installer/README.md#get-started)
 
@@ -16,7 +16,7 @@ Netdata Cloud.
 > The connection process ensures no third party can add your node, and then view your node's metrics, in a Cloud account,
 > Space, or War Room that you did not authorize.
 
-By connecting a node, you opt-in to sending data from your Agent to Netdata Cloud via the [ACLK](https://github.com/netdata/netdata/blob/master/aclk/README.md). This
+By connecting a node, you opt-in to sending data from your Agent to Netdata Cloud via the [ACLK](https://github.com/netdata/netdata/blob/master/src/aclk/README.md). This
 data is encrypted by TLS while it is in transit. We use the RSA keypair created during the connection process to authenticate the
 identity of the Netdata Agent when it connects to the Cloud. While the data does flow through Netdata Cloud servers on its way
 from Agents to the browser, we do not store or log it.
@@ -337,7 +337,7 @@ you don't see the node in your Space after 60 seconds, see the [troubleshooting
 
 ### Troubleshooting
 
-If you're having trouble connecting a node, this may be because the [ACLK](https://github.com/netdata/netdata/blob/master/aclk/README.md) cannot connect to Cloud.
+If you're having trouble connecting a node, this may be because the [ACLK](https://github.com/netdata/netdata/blob/master/src/aclk/README.md) cannot connect to Cloud.
 
 With the Netdata Agent running, visit `http://NODE:19999/api/v1/info` in your browser, replacing `NODE` with the IP
 address or hostname of your Agent. The returned JSON contains four keys that will be helpful to diagnose any issues you
@@ -562,12 +562,12 @@ tool, and details about the files found in `cloud.d`.
 ### The `cloud.conf` file
 
 This section defines how and whether your Agent connects to Netdata Cloud
-using the [ACLK](https://github.com/netdata/netdata/blob/master/aclk/README.md).
+using the [ACLK](https://github.com/netdata/netdata/blob/master/src/aclk/README.md).
 
 | setting        | default                   | info                                                                                                                                   |
 |:-------------- |:------------------------- |:-------------------------------------------------------------------------------------------------------------------------------------- |
 | cloud base url | <https://app.netdata.cloud> | The URL for the Netdata Cloud web application. You should not change this. If you want to disable Cloud, change the `enabled` setting. |
-| enabled        | yes                       | The runtime option to disable the [Agent-Cloud link](https://github.com/netdata/netdata/blob/master/aclk/README.md) and prevent your Agent from connecting to Netdata Cloud.         |
+| enabled        | yes                       | The runtime option to disable the [Agent-Cloud link](https://github.com/netdata/netdata/blob/master/src/aclk/README.md) and prevent your Agent from connecting to Netdata Cloud.         |
 
 ### Claiming script
 

src/database/sqlite/sqlite_health.c

@@ -3,7 +3,7 @@
 #include "sqlite_health.h"
 #include "sqlite_functions.h"
 #include "sqlite_db_migration.h"
-#include "../../health/health_internals.h"
+#include "health/health_internals.h"
 
 #define MAX_HEALTH_SQL_SIZE 2048
 #define SQLITE3_BIND_STRING_OR_NULL(res, key, param)                                                                   \