Add Samba collector yaml (#15507)

collectors/python.d.plugin/samba/metadata.yaml

@@ -3,52 +3,123 @@ meta:
   module_name: samba
   monitored_instance:
     name: Samba
-    link: ''
+    link: https://www.samba.org/samba/
     categories:
-    - data-collection.storage-mount-points-and-filesystems
+      - data-collection.storage-mount-points-and-filesystems
-    icon_filename: 'samba.jpg'
+    icon_filename: "samba.jpg"
   related_resources:
     integrations:
       list: []
   info_provided_to_referring_integrations:
-    description: ''
+    description: ""
-  keywords: []
+  keywords:
+    - samba
+    - file sharing
   most_popular: false
 overview:
   data_collection:
-    metrics_description: 'Monitor Samba performance for optimal network file sharing operations. Netdata provides real-time insights and alerts for efficient file sharing.'
+    metrics_description: "This collector monitors the performance metrics of Samba file sharing."
-    method_description: ''
+    method_description: |
+      It is using the `smbstatus` command-line tool.
+
+      Executed commands:
+
+      - `sudo -n smbstatus -P`
   supported_platforms:
     include: []
     exclude: []
-  multi_instance: true
+  multi_instance: false
   additional_permissions:
-    description: ''
+    description: |
+      `smbstatus` is used, which can only be executed by `root`. It uses `sudo` and assumes that it is configured such that the `netdata` user can execute `smbstatus` as root without a password.
   default_behavior:
     auto_detection:
-      description: ''
+      description: "After all the permissions are satisfied, the `smbstatus -P` binary is executed."
     limits:
-      description: ''
+      description: ""
     performance_impact:
-      description: ''
+      description: ""
 setup:
   prerequisites:
-    list: []
+    list:
+      - title: Permissions and programs
+        description: |
+          To run the collector you need:
+
+          - `smbstatus` program
+          - `sudo` program
+          - `smbd` must be compiled with profiling enabled
+          - `smbd` must be started either with the `-P 1` option or inside `smb.conf` using `smbd profiling level`
+
+          The module uses `smbstatus`, which can only be executed by `root`. It uses `sudo` and assumes that it is configured such that the `netdata` user can execute `smbstatus` as root without a password.
+
+          - add to your `/etc/sudoers` file:
+
+            `which smbstatus` shows the full path to the binary.
+
+            ```bash
+            netdata ALL=(root)       NOPASSWD: /path/to/smbstatus
+            ```
+
+          - Reset Netdata's systemd unit [CapabilityBoundingSet](https://www.freedesktop.org/software/systemd/man/systemd.exec.html#Capabilities) (Linux distributions with systemd)
+
+            The default CapabilityBoundingSet doesn't allow using `sudo`, and is quite strict in general. Resetting is not optimal, but a next-best solution given the inability to execute `smbstatus` using `sudo`.
+
+
+            As the `root` user, do the following:
+
+            ```cmd
+            mkdir /etc/systemd/system/netdata.service.d
+            echo -e '[Service]\nCapabilityBoundingSet=~' | tee /etc/systemd/system/netdata.service.d/unset-capability-bounding-set.conf
+            systemctl daemon-reload
+            systemctl restart netdata.service
+            ```
   configuration:
     file:
-      name: ''
+      name: python.d/samba.conf
-      description: ''
     options:
-      description: ''
+      description: |
+        There are 2 sections:
+
+        * Global variables
+        * One or more JOBS that can define multiple different instances to monitor.
+
+        The following options can be defined globally: priority, penalty, autodetection_retry, update_every, but can also be defined per JOB to override the global values.
+
+        Additionally, the following collapsed table contains all the options that can be configured inside a JOB definition.
+
+        Every configuration JOB starts with a `job_name` value which will appear in the dashboard, unless a `name` parameter is specified.
       folding:
-        title: ''
+        title: "Config options"
         enabled: true
-      list: []
+      list:
+        - name: update_every
+          description: Sets the default data collection frequency.
+          default_value: 5
+          required: false
+        - name: priority
+          description: Controls the order of charts at the netdata dashboard.
+          default_value: 60000
+          required: false
+        - name: autodetection_retry
+          description: Sets the job re-check interval in seconds.
+          default_value: 0
+          required: false
+        - name: penalty
+          description: Indicates whether to apply penalty to update_every in case of failures.
+          default_value: yes
+          required: false
     examples:
       folding:
         enabled: true
-        title: ''
+        title: "Config"
-      list: []
+      list:
+        - name: Basic
+          description: A basic example configuration.
+          config: |
+            my_job_name:
+              name: my_name
+              update_every: 1
 troubleshooting:
   problems:
     list: []
@@ -60,64 +131,64 @@ metrics:
   description: ""
   availability: []
   scopes:
-  - name: global
+    - name: global
-    description: ""
+      description: "These metrics refer to the entire monitored application."
-    labels: []
+      labels: []
-    metrics:
+      metrics:
-    - name: syscall.rw
+        - name: syscall.rw
-      description: R/Ws
+          description: R/Ws
-      unit: "KiB/s"
+          unit: "KiB/s"
-      chart_type: area
+          chart_type: area
-      dimensions:
+          dimensions:
-      - name: sendfile
+            - name: sendfile
-      - name: recvfile
+            - name: recvfile
-    - name: smb2.rw
+        - name: smb2.rw
-      description: R/Ws
+          description: R/Ws
-      unit: "KiB/s"
+          unit: "KiB/s"
-      chart_type: area
+          chart_type: area
-      dimensions:
+          dimensions:
-      - name: readout
+            - name: readout
-      - name: writein
+            - name: writein
-      - name: readin
+            - name: readin
-      - name: writeout
+            - name: writeout
-    - name: smb2.create_close
+        - name: smb2.create_close
-      description: Create/Close
+          description: Create/Close
-      unit: "operations/s"
+          unit: "operations/s"
-      chart_type: line
+          chart_type: line
-      dimensions:
+          dimensions:
-      - name: create
+            - name: create
-      - name: close
+            - name: close
-    - name: smb2.get_set_info
+        - name: smb2.get_set_info
-      description: Info
+          description: Info
-      unit: "operations/s"
+          unit: "operations/s"
-      chart_type: line
+          chart_type: line
-      dimensions:
+          dimensions:
-      - name: getinfo
+            - name: getinfo
-      - name: setinfo
+            - name: setinfo
-    - name: smb2.find
+        - name: smb2.find
-      description: Find
+          description: Find
-      unit: "operations/s"
+          unit: "operations/s"
-      chart_type: line
+          chart_type: line
-      dimensions:
+          dimensions:
-      - name: find
+            - name: find
-    - name: smb2.notify
+        - name: smb2.notify
-      description: Notify
+          description: Notify
-      unit: "operations/s"
+          unit: "operations/s"
-      chart_type: line
+          chart_type: line
-      dimensions:
+          dimensions:
-      - name: notify
+            - name: notify
-    - name: smb2.sm_counters
+        - name: smb2.sm_counters
-      description: Lesser Ops
+          description: Lesser Ops
-      unit: "count"
+          unit: "count"
-      chart_type: stacked
+          chart_type: stacked
-      dimensions:
+          dimensions:
-      - name: tcon
+            - name: tcon
-      - name: negprot
+            - name: negprot
-      - name: tdis
+            - name: tdis
-      - name: cancel
+            - name: cancel
-      - name: logoff
+            - name: logoff
-      - name: flush
+            - name: flush
-      - name: lock
+            - name: lock
-      - name: keepalive
+            - name: keepalive
-      - name: break
+            - name: break
-      - name: sessetup
+            - name: sessetup