archive/netdata_netdata
0
0
Fork 0
mirror of https://github.com/netdata/netdata.git synced 2025-04-17 11:12:42 +00:00
Code Issues Projects Releases Wiki Activity

Free analytics data when analytics thread stops ()

Browse source 
* move analytics_free_data to when analytics thread stops

* only log hits if analytics is enabled
This commit is contained in:
Emmanuel Vasilakis 2021-09-28 17:52:47 +03:00 • committed by GitHub
parent d3c5ffab0d
commit ffc4c5dee0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions

9
daemon/analytics.c
View file

@ -150,7 +150,7 @@ void analytics_get_data(char *name, BUFFER *wb)
*/
void analytics_log_prometheus(void)
{
if (likely(analytics_data.prometheus_hits < ANALYTICS_MAX_PROMETHEUS_HITS)) {
if (netdata_anonymous_statistics_enabled == 1 && likely(analytics_data.prometheus_hits < ANALYTICS_MAX_PROMETHEUS_HITS)) {
analytics_data.prometheus_hits++;
char b[7];
snprintfz(b, 6, "%d", analytics_data.prometheus_hits);
@ -163,7 +163,7 @@ void analytics_log_prometheus(void)
*/
void analytics_log_shell(void)
{
if (likely(analytics_data.shell_hits < ANALYTICS_MAX_SHELL_HITS)) {
if (netdata_anonymous_statistics_enabled == 1 && likely(analytics_data.shell_hits < ANALYTICS_MAX_SHELL_HITS)) {
analytics_data.shell_hits++;
char b[7];
snprintfz(b, 6, "%d", analytics_data.shell_hits);
@ -176,7 +176,7 @@ void analytics_log_shell(void)
*/
void analytics_log_json(void)
{
if (likely(analytics_data.json_hits < ANALYTICS_MAX_JSON_HITS)) {
if (netdata_anonymous_statistics_enabled == 1 && likely(analytics_data.json_hits < ANALYTICS_MAX_JSON_HITS)) {
analytics_data.json_hits++;
char b[7];
snprintfz(b, 6, "%d", analytics_data.json_hits);
@ -189,7 +189,7 @@ void analytics_log_json(void)
*/
void analytics_log_dashboard(void)
{
if (likely(analytics_data.dashboard_hits < ANALYTICS_MAX_DASHBOARD_HITS)) {
if (netdata_anonymous_statistics_enabled == 1 && likely(analytics_data.dashboard_hits < ANALYTICS_MAX_DASHBOARD_HITS)) {
analytics_data.dashboard_hits++;
char b[7];
snprintfz(b, 6, "%d", analytics_data.dashboard_hits);
@ -589,6 +589,7 @@ void analytics_main_cleanup(void *ptr)
static_thread->enabled = NETDATA_MAIN_THREAD_EXITING;
debug(D_ANALYTICS, "Cleaning up...");
analytics_free_data();
static_thread->enabled = NETDATA_MAIN_THREAD_EXITED;
}

1
daemon/main.c
View file

@ -28,7 +28,6 @@ void netdata_cleanup_and_exit(int ret) {
info("EXIT: netdata prepares to exit with code %d...", ret);
send_statistics("EXIT", ret?"ERROR":"OK","-");
analytics_free_data();
char agent_crash_file[FILENAME_MAX + 1];
char agent_incomplete_shutdown_file[FILENAME_MAX + 1];