* attempt to create user/group using synology CLI tools.
* Update functions.sh
fix spellcheck warning
* Update functions.sh
improve support for Synology command synogroup
so it can add user to group keeping former members
* fix bug closing if too soon
* remove redundant test
* fix shellcheck warning
* use run to run synogroup
* add DSM support to remove user/group
* silence shellcheck warning: this needs to be expanded.
* fix: the variable has to be expanded.
* fix: parameter has to be expanded.
silence shellcheck warning
* Update packaging/installer/functions.sh
---------
Co-authored-by: Ilya Mashchenko <ilya@netdata.cloud>
* Update synology.md
My previous change was not correct.
Actually the kickstart install failed to create the netdata user and group, thus it has to be created manually
* update wording
---------
Co-authored-by: ilyam8 <ilya@netdata.cloud>
- Don’t blindly trust that the service manager actually shut down the
agent.
- Bump timeouts between each method of shutting down the agent to 30
seconds to make it more likely that the agent actually shuts down
before we try to shut it down a different way.
- Add logic to handle different possible locations for netdatacli pipe.
- On all RHEL versions, correctly pull the EPEL release package from
the Fedora project, since RHEL does not include it in their repos.
- On RHEL 9 and newer, as well as clones, enable the CodeReady Builder
repo, which is apparently required there to make EPEL work at all,
before installing EPEL.
* Add LTO support in CMake build system.
Internally, CMake calls LTO ‘Interprocedural Optimization’, and it
provides functionality for checking for support for this as well as
enabling it by default for targets. This leverages that support to
auto-detect LTO and enable it if it’s supported.
* Default to disabling LTO for Debug builds.
* Add handling for LTO to netdata installer code.
* Switch back to DISABLE_LTO as option name.
Using `ENABLE_LTO` leads to a possibility for confusion among users, as it
does behave in the most intuitive manner. Instead of ensuring that LTO
is used (and thus behaving like every other `ENABLE_*` option we have),
it allows the usage LTO if it’s supported. Thus a build with
`-DENABLE_LTO=True` may not actually be built with LTO.
By instead using `DISABLE_LTO`, the behavior matches up directly with
how most people are likely to interpret the meaning, because a build
with `-DDISABLE_LTO=True` will _never_ have LTO flags added to the
compiler/linker flags.
* Fix condition for determining default for DISABLE_LTO.
* Turn off LTO auto-detection in RPM package builds.
On pretty much all RPM platforms, the RPM build process itself will
correctly add the required compiler flags when building, so we don’t
actually need to auto-detect LTO support in CMake here.
Additionally, on at least some RPM platforms, CMake’s auto-detection
for LTO support actually breaks the build when used.
* Disable function and data sections when using LTO.
On at least some systems, `-fdata-sections` combined with LTO reliably
causes failures at link time with our code.
The final binary size on systems where the combination _works_ differs by
no more than a few KiB on average (tested on 64-bit x86 on Ubuntu 22.04,
Debian 12, Fedora 39, and Rocky Linux 9), so we’re not actually getting
almost any benefit out of using both with things as they are now, but
LTO gives us a meaasurable performance improvement that per-function and
per-data sections do not.
* Restructure in-line with current repo state.
* Disable LTO on Windows builds since it doesn’t work there.
* Fix compiler flag handling order.
* Switch LTO option name to USE_LTO for consistency with USE_MOLD.
* Query systemd for unit file paths on install/uninstall.
This makes our installation code more portable and more concise, and
should make the uninstallation code significantly more robust.
Also includes a number of other improvements to systemd handling and
updater handling in the uninstaller that should make it much more
thorough and reliable.
* Fix issues brought up in code review, and better support old systemd versions.
* Replace sed with AWK for readability.
* Fix uninstaller loop.
* Fix unit file detection in updater code.
- Account for Debian/Ubuntu still not including sbin directories in user
$PATH.
- Report an inability to detect netdatacli location instead of trying to
invoke an empty string when claiming.
Assorted systemd detection fixes:
- Properly scope `set -e` changes to only affect `systemctl
is-system-running` invocation.
- Skip checking for hard-coded unit file paths. Other paths may
technically be used for unit files instead of what we hard-code, and
the presence or abscence of any specific unit file path _does not_
reliably indicate the presence or abscence of systemd.
* Add option to updater to report status of auto-updates on the system.
* Improve systemd detection.
The _official_ way to check if a system is running systemd is to call
`systemctl is-system-running` and check the output. This adds that
checking to places where we are otherwise looking for systemd.
* Remove pointless subshell.
* updated copyright notices everywhere (I hope)
* Update makeself.lsm
* Update coverity-scan.sh
* make all newlines be linux, not windows
* remove copyright from all files (the take it from the repo), unless it is printed to users
