mirror of
https://github.com/netdata/netdata.git
synced 2025-04-06 06:25:32 +00:00

* sslstream: ACL parser It was noticed in the issue 6457 that the some ACLs were not parsing correctly when they were along SSL acl, this commit fixes this' * sslstream: remove comments This commit removes the comments that were present while I was testing the code * sslstream: Tests This commit adds ACL tests to check the Netdata response to them * sslstream: Tests Fix the extension to upload the files * sslstream: more tests In this commit I am bringing more tests, including the ssl tests' * sslstream: leading space Remove leading space from variable that was creating problem with shellcheck * sslstream: glob Remove special character from script * sslstream: Makefile The Makefile diretives were pointed to wrong files * sslstream: Missing stream encrypt This commit solves the problem of the stream not be encrypted, but it is not the final solution, because the parser made is incomplete. * sslstream: Finish encrypt channel This commit brings the step that I was missing, the complete encryptation in the communication between Master and Slave * sslstream: Fix argument in script After the latest tests, it was verified that two arguments given to a function inside the script were not correct, with this PR I am fixing this! * sslstream: Fix argument in info Instead to call a function to deliver an integer I was passing a size_t value. Only cmake showed this, but not in my clion! :/ * sslstream: Fix redirect When we were having different SSL configuration, the system were not applying the option for all * sslstream: Update documentation Our documentation was not clear about the rules according our code so I am updating the text to explain for the users * sslstream: Adjust script With this last commit, I am adjusting the tests to avoid false positive * sslstream: Missing elif The previous commit had a missing elif in the shell script * sslstream: Split ports Before this commit Netdata was having SSL as a global option, now it has as a real ACL. * sslstream: reduce context The stream variable will not be affected in the master side, it is only necessary on the slave side, so I am reducing the context of it * sslstream: Force SSL When the user has certificate and he does not set any SSL flag, it is necessary to append the SSL=force flag * sslstream: Default flag It is necessary to have a default flag when the SSL flags are not SET * sslstream: remove comments Remove comments from the scrip * sslstream: moving flag It is better the flag to be set inside socket instead everytime there is a new connection * sslstream: documentation Fix a sentence in the web/server/README.md
289 lines
8.4 KiB
C
289 lines
8.4 KiB
C
#include "../libnetdata.h"
|
|
|
|
#ifdef ENABLE_HTTPS
|
|
|
|
SSL_CTX *netdata_opentsdb_ctx=NULL;
|
|
SSL_CTX *netdata_client_ctx=NULL;
|
|
SSL_CTX *netdata_srv_ctx=NULL;
|
|
const char *security_key=NULL;
|
|
const char *security_cert=NULL;
|
|
int netdata_validate_server = NETDATA_SSL_VALID_CERTIFICATE;
|
|
|
|
/**
|
|
* Info Callback
|
|
*
|
|
* Function used as callback for the OpenSSL Library
|
|
*
|
|
* @param ssl a pointer to the SSL structure of the client
|
|
* @param where the variable with the flags set.
|
|
* @param ret the return of the caller
|
|
*/
|
|
static void security_info_callback(const SSL *ssl, int where, int ret __maybe_unused) {
|
|
(void)ssl;
|
|
if (where & SSL_CB_ALERT) {
|
|
debug(D_WEB_CLIENT,"SSL INFO CALLBACK %s %s", SSL_alert_type_string(ret), SSL_alert_desc_string_long(ret));
|
|
}
|
|
}
|
|
|
|
/**
|
|
* OpenSSL Library
|
|
*
|
|
* Starts the openssl library for the Netdata.
|
|
*/
|
|
void security_openssl_library()
|
|
{
|
|
#if OPENSSL_VERSION_NUMBER < 0x10100000L
|
|
# if (SSLEAY_VERSION_NUMBER >= 0x0907000L)
|
|
OPENSSL_config(NULL);
|
|
# endif
|
|
|
|
# if OPENSSL_API_COMPAT < 0x10100000L
|
|
SSL_load_error_strings();
|
|
# endif
|
|
|
|
SSL_library_init();
|
|
#else
|
|
if (OPENSSL_init_ssl(OPENSSL_INIT_LOAD_CONFIG, NULL) != 1) {
|
|
error("SSL library cannot be initialized.");
|
|
}
|
|
#endif
|
|
}
|
|
|
|
/**
|
|
* OpenSSL common options
|
|
*
|
|
* Clients and SERVER have common options, this function is responsible to set them in the context.
|
|
*
|
|
* @param ctx
|
|
*/
|
|
void security_openssl_common_options(SSL_CTX *ctx) {
|
|
#if OPENSSL_VERSION_NUMBER >= 0x10100000L
|
|
static char *ciphers = {"ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-SHA:!aNULL:!eNULL:!EXPORT:!DES:!RC4:!MD5:!PSK:!aECDH:!EDH-DSS-DES-CBC3-SHA:!EDH-RSA-DES-CBC3-SHA:!KRB5-DES-CBC3-SHA"};
|
|
#endif
|
|
#if OPENSSL_VERSION_NUMBER < 0x10100000L
|
|
SSL_CTX_set_options (ctx,SSL_OP_NO_SSLv2|SSL_OP_NO_SSLv3|SSL_OP_NO_COMPRESSION);
|
|
#else
|
|
SSL_CTX_set_min_proto_version(ctx, TLS1_2_VERSION);
|
|
//We are avoiding the TLS v1.3 for while, because Google Chrome
|
|
//is giving the message net::ERR_SSL_VERSION_INTERFERENCE with it.
|
|
SSL_CTX_set_max_proto_version(ctx, TLS1_2_VERSION);
|
|
#endif
|
|
SSL_CTX_set_mode(ctx, SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER);
|
|
|
|
#if OPENSSL_VERSION_NUMBER >= 0x10100000L
|
|
if (!SSL_CTX_set_cipher_list(ctx, ciphers)) {
|
|
error("SSL error. cannot set the cipher list");
|
|
}
|
|
#endif
|
|
}
|
|
|
|
/**
|
|
* Initialize Openssl Client
|
|
*
|
|
* Starts the client context with TLS 1.2.
|
|
*
|
|
* @return It returns the context on success or NULL otherwise
|
|
*/
|
|
static SSL_CTX * security_initialize_openssl_client() {
|
|
SSL_CTX *ctx;
|
|
#if OPENSSL_VERSION_NUMBER < 0x10100000L
|
|
ctx = SSL_CTX_new(SSLv23_client_method());
|
|
#else
|
|
ctx = SSL_CTX_new(TLS_client_method());
|
|
#endif
|
|
if(ctx) {
|
|
security_openssl_common_options(ctx);
|
|
}
|
|
|
|
return ctx;
|
|
}
|
|
|
|
/**
|
|
* Initialize OpenSSL server
|
|
*
|
|
* Starts the server context with TLS 1.2 and load the certificate.
|
|
*
|
|
* @return It returns the context on success or NULL otherwise
|
|
*/
|
|
static SSL_CTX * security_initialize_openssl_server() {
|
|
SSL_CTX *ctx;
|
|
char lerror[512];
|
|
static int netdata_id_context = 1;
|
|
|
|
//TO DO: Confirm the necessity to check return for other OPENSSL function
|
|
#if OPENSSL_VERSION_NUMBER < 0x10100000L
|
|
ctx = SSL_CTX_new(SSLv23_server_method());
|
|
if (!ctx) {
|
|
error("Cannot create a new SSL context, netdata won't encrypt communication");
|
|
return NULL;
|
|
}
|
|
|
|
SSL_CTX_use_certificate_file(ctx, security_cert, SSL_FILETYPE_PEM);
|
|
#else
|
|
ctx = SSL_CTX_new(TLS_server_method());
|
|
if (!ctx) {
|
|
error("Cannot create a new SSL context, netdata won't encrypt communication");
|
|
return NULL;
|
|
}
|
|
|
|
SSL_CTX_use_certificate_chain_file(ctx, security_cert);
|
|
#endif
|
|
security_openssl_common_options(ctx);
|
|
|
|
SSL_CTX_use_PrivateKey_file(ctx,security_key,SSL_FILETYPE_PEM);
|
|
|
|
if (!SSL_CTX_check_private_key(ctx)) {
|
|
ERR_error_string_n(ERR_get_error(),lerror,sizeof(lerror));
|
|
error("SSL cannot check the private key: %s",lerror);
|
|
SSL_CTX_free(ctx);
|
|
return NULL;
|
|
}
|
|
|
|
SSL_CTX_set_session_id_context(ctx,(void*)&netdata_id_context,(unsigned int)sizeof(netdata_id_context));
|
|
SSL_CTX_set_info_callback(ctx,security_info_callback);
|
|
|
|
#if (OPENSSL_VERSION_NUMBER < 0x00905100L)
|
|
SSL_CTX_set_verify_depth(ctx,1);
|
|
#endif
|
|
debug(D_WEB_CLIENT,"SSL GLOBAL CONTEXT STARTED\n");
|
|
|
|
return ctx;
|
|
}
|
|
|
|
/**
|
|
* Start SSL
|
|
*
|
|
* Call the correct function to start the SSL context.
|
|
*
|
|
* @param selector informs the context that must be initialized, the following list has the valid values:
|
|
* NETDATA_SSL_CONTEXT_SERVER - the server context
|
|
* NETDATA_SSL_CONTEXT_STREAMING - Starts the streaming context.
|
|
* NETDATA_SSL_CONTEXT_OPENTSDB - Starts the OpenTSDB contextv
|
|
*/
|
|
void security_start_ssl(int selector) {
|
|
switch (selector) {
|
|
case NETDATA_SSL_CONTEXT_SERVER: {
|
|
struct stat statbuf;
|
|
if (stat(security_key,&statbuf) || stat(security_cert,&statbuf)) {
|
|
info("To use encryption it is necessary to set \"ssl certificate\" and \"ssl key\" in [web] !\n");
|
|
return;
|
|
}
|
|
|
|
netdata_srv_ctx = security_initialize_openssl_server();
|
|
break;
|
|
}
|
|
case NETDATA_SSL_CONTEXT_STREAMING: {
|
|
netdata_client_ctx = security_initialize_openssl_client();
|
|
//This is necessary for the stream, because it is working sometimes with nonblock socket.
|
|
//It returns the bitmask afte to change, there is not any description of errors in the documentation
|
|
SSL_CTX_set_mode(netdata_client_ctx, SSL_MODE_ENABLE_PARTIAL_WRITE |SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER |SSL_MODE_AUTO_RETRY);
|
|
break;
|
|
}
|
|
case NETDATA_SSL_CONTEXT_OPENTSDB: {
|
|
netdata_opentsdb_ctx = security_initialize_openssl_client();
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
void security_clean_openssl() {
|
|
if (netdata_srv_ctx)
|
|
{
|
|
SSL_CTX_free(netdata_srv_ctx);
|
|
}
|
|
|
|
if (netdata_client_ctx)
|
|
{
|
|
SSL_CTX_free(netdata_client_ctx);
|
|
}
|
|
|
|
if ( netdata_opentsdb_ctx )
|
|
{
|
|
SSL_CTX_free(netdata_opentsdb_ctx);
|
|
}
|
|
|
|
#if OPENSSL_VERSION_NUMBER < 0x10100000L
|
|
ERR_free_strings();
|
|
#endif
|
|
}
|
|
|
|
/**
|
|
* Process accept
|
|
*
|
|
* Process the SSL handshake with the client case it is necessary.
|
|
*
|
|
* @param ssl is a pointer for the SSL structure
|
|
* @param msg is a copy of the first 8 bytes of the initial message received
|
|
*
|
|
* @return it returns 0 case it performs the handshake, 8 case it is clean connection
|
|
* and another integer power of 2 otherwise.
|
|
*/
|
|
int security_process_accept(SSL *ssl,int msg) {
|
|
int sock = SSL_get_fd(ssl);
|
|
int test;
|
|
if (msg > 0x17)
|
|
{
|
|
return NETDATA_SSL_NO_HANDSHAKE;
|
|
}
|
|
|
|
ERR_clear_error();
|
|
if ((test = SSL_accept(ssl)) <= 0) {
|
|
int sslerrno = SSL_get_error(ssl, test);
|
|
switch(sslerrno) {
|
|
case SSL_ERROR_WANT_READ:
|
|
{
|
|
error("SSL handshake did not finish and it wanna read on socket %d!", sock);
|
|
return NETDATA_SSL_WANT_READ;
|
|
}
|
|
case SSL_ERROR_WANT_WRITE:
|
|
{
|
|
error("SSL handshake did not finish and it wanna read on socket %d!", sock);
|
|
return NETDATA_SSL_WANT_WRITE;
|
|
}
|
|
case SSL_ERROR_NONE:
|
|
case SSL_ERROR_SSL:
|
|
case SSL_ERROR_SYSCALL:
|
|
default:
|
|
{
|
|
u_long err;
|
|
char buf[256];
|
|
int counter = 0;
|
|
while ((err = ERR_get_error()) != 0) {
|
|
ERR_error_string_n(err, buf, sizeof(buf));
|
|
info("%d SSL Handshake error (%s) on socket %d ", counter++, ERR_error_string((long)SSL_get_error(ssl, test), NULL), sock);
|
|
}
|
|
return NETDATA_SSL_NO_HANDSHAKE;
|
|
}
|
|
}
|
|
}
|
|
|
|
if (SSL_is_init_finished(ssl))
|
|
{
|
|
debug(D_WEB_CLIENT_ACCESS,"SSL Handshake finished %s errno %d on socket fd %d", ERR_error_string((long)SSL_get_error(ssl, test), NULL), errno, sock);
|
|
}
|
|
|
|
return NETDATA_SSL_HANDSHAKE_COMPLETE;
|
|
}
|
|
|
|
int security_test_certificate(SSL *ssl) {
|
|
X509* cert = SSL_get_peer_certificate(ssl);
|
|
int ret;
|
|
long status;
|
|
if (!cert) {
|
|
return -1;
|
|
}
|
|
|
|
status = SSL_get_verify_result(ssl);
|
|
if((X509_V_OK != status))
|
|
{
|
|
char error[512];
|
|
ERR_error_string_n(ERR_get_error(), error, sizeof(error));
|
|
error("SSL RFC4158 check: We have a invalid certificate, the tests result with %ld and message %s", status, error);
|
|
ret = -1;
|
|
} else {
|
|
ret = 0;
|
|
}
|
|
return ret;
|
|
}
|
|
|
|
#endif
|