mirror of
https://github.com/netdata/netdata.git
synced 2025-04-14 17:48:37 +00:00

* cleanup of logging - wip
* first working iteration
* add errno annotator
* replace old logging functions with netdata_logger()
* cleanup
* update error_limit
* fix remanining error_limit references
* work on fatal()
* started working on structured logs
* full cleanup
* default logging to files; fix all plugins initialization
* fix formatting of numbers
* cleanup and reorg
* fix coverity issues
* cleanup obsolete code
* fix formatting of numbers
* fix log rotation
* fix for older systems
* add detection of systemd journal via stderr
* finished on access.log
* remove left-over transport
* do not add empty fields to the logs
* journal get compact uuids; X-Transaction-ID header is added in web responses
* allow compiling on systems without memfd sealing
* added libnetdata/uuid directory
* move datetime formatters to libnetdata
* add missing files
* link the makefiles in libnetdata
* added uuid_parse_flexi() to parse UUIDs with and without hyphens; the web server now read X-Transaction-ID and uses it for functions and web responses
* added stream receiver, sender, proc plugin and pluginsd log stack
* iso8601 advanced usage; line_splitter module in libnetdata; code cleanup
* add message ids to streaming inbound and outbound connections
* cleanup line_splitter between lines to avoid logging garbage; when killing children, kill them with SIGABRT if internal checks is enabled
* send SIGABRT to external plugins only if we are not shutting down
* fix cross cleanup in pluginsd parser
* fatal when there is a stack error in logs
* compile netdata with -fexceptions
* do not kill external plugins with SIGABRT
* metasync info logs to debug level
* added severity to logs
* added json output; added options per log output; added documentation; fixed issues mentioned
* allow memfd only on linux
* moved journal low level functions to journal.c/h
* move health logs to daemon.log with proper priorities
* fixed a couple of bugs; health log in journal
* updated docs
* systemd-cat-native command to push structured logs to journal from the command line
* fix makefiles
* restored NETDATA_LOG_SEVERITY_LEVEL
* fix makefiles
* systemd-cat-native can also work as the logger of Netdata scripts
* do not require a socket to systemd-journal to log-as-netdata
* alarm notify logs in native format
* properly compare log ids
* fatals log alerts; alarm-notify.sh working
* fix overflow warning
* alarm-notify.sh now logs the request (command line)
* anotate external plugins logs with the function cmd they run
* added context, component and type to alarm-notify.sh; shell sanitization removes control character and characters that may be expanded by bash
* reformatted alarm-notify logs
* unify cgroup-network-helper.sh
* added quotes around params
* charts.d.plugin switched logging to journal native
* quotes for logfmt
* unify the status codes of streaming receivers and senders
* alarm-notify: dont log anything, if there is nothing to do
* all external plugins log to stderr when running outside netdata; alarm-notify now shows an error when notifications menthod are needed but are not available
* migrate cgroup-name.sh to new logging
* systemd-cat-native now supports messages with newlines
* socket.c logs use priority
* cleanup log field types
* inherit the systemd set INVOCATION_ID if found
* allow systemd-cat-native to send messages to a systemd-journal-remote URL
* log2journal command that can convert structured logs to journal export format
* various fixes and documentation of log2journal
* updated log2journal docs
* updated log2journal docs
* updated documentation of fields
* allow compiling without libcurl
* do not use socket as format string
* added version information to newly added tools
* updated documentation and help messages
* fix the namespace socket path
* print errno with error
* do not timeout
* updated docs
* updated docs
* updated docs
* log2journal updated docs and params
* when talking to a remote journal, systemd-cat-native batches the messages
* enable lz4 compression for systemd-cat-native when sending messages to a systemd-journal-remote
* Revert "enable lz4 compression for systemd-cat-native when sending messages to a systemd-journal-remote"
This reverts commit b079d53c11
.
* note about uncompressed traffic
* log2journal: code reorg and cleanup to make modular
* finished rewriting log2journal
* more comments
* rewriting rules support
* increased limits
* updated docs
* updated docs
* fix old log call
* use journal only when stderr is connected to journal
* update netdata.spec for libcurl, libpcre2 and log2journal
* pcre2-devel
* do not require pcre2 in centos < 8, amazonlinux < 2023, open suse
* log2journal only on systems pcre2 is available
* ignore log2journal in .gitignore
* avoid log2journal on centos 7, amazonlinux 2 and opensuse
* add pcre2-8 to static build
* undo last commit
* Bundle to static
Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud>
* Add build deps for deb packages
Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud>
* Add dependencies; build from source
Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud>
* Test build for amazon linux and centos expect to fail for suse
Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud>
* fix minor oversight
Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud>
* Reorg code
* Add the install from source (deps) as a TODO
* Not enable the build on suse ecosystem
Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud>
---------
Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud>
Co-authored-by: Tasos Katsoulas <tasos@netdata.cloud>
355 lines
14 KiB
C
355 lines
14 KiB
C
// SPDX-License-Identifier: GPL-3.0-or-later
|
|
|
|
#include "plugins_d.h"
|
|
#include "pluginsd_parser.h"
|
|
|
|
char *plugin_directories[PLUGINSD_MAX_DIRECTORIES] = { [0] = PLUGINS_DIR, };
|
|
struct plugind *pluginsd_root = NULL;
|
|
|
|
inline size_t pluginsd_initialize_plugin_directories()
|
|
{
|
|
char plugins_dirs[(FILENAME_MAX * 2) + 1];
|
|
static char *plugins_dir_list = NULL;
|
|
|
|
// Get the configuration entry
|
|
if (likely(!plugins_dir_list)) {
|
|
snprintfz(plugins_dirs, FILENAME_MAX * 2, "\"%s\" \"%s/custom-plugins.d\"", PLUGINS_DIR, CONFIG_DIR);
|
|
plugins_dir_list = strdupz(config_get(CONFIG_SECTION_DIRECTORIES, "plugins", plugins_dirs));
|
|
}
|
|
|
|
// Parse it and store it to plugin directories
|
|
return quoted_strings_splitter_config(plugins_dir_list, plugin_directories, PLUGINSD_MAX_DIRECTORIES);
|
|
}
|
|
|
|
static inline void plugin_set_disabled(struct plugind *cd) {
|
|
spinlock_lock(&cd->unsafe.spinlock);
|
|
cd->unsafe.enabled = false;
|
|
spinlock_unlock(&cd->unsafe.spinlock);
|
|
}
|
|
|
|
bool plugin_is_enabled(struct plugind *cd) {
|
|
spinlock_lock(&cd->unsafe.spinlock);
|
|
bool ret = cd->unsafe.enabled;
|
|
spinlock_unlock(&cd->unsafe.spinlock);
|
|
return ret;
|
|
}
|
|
|
|
static inline void plugin_set_running(struct plugind *cd) {
|
|
spinlock_lock(&cd->unsafe.spinlock);
|
|
cd->unsafe.running = true;
|
|
spinlock_unlock(&cd->unsafe.spinlock);
|
|
}
|
|
|
|
static inline bool plugin_is_running(struct plugind *cd) {
|
|
spinlock_lock(&cd->unsafe.spinlock);
|
|
bool ret = cd->unsafe.running;
|
|
spinlock_unlock(&cd->unsafe.spinlock);
|
|
return ret;
|
|
}
|
|
|
|
static void pluginsd_worker_thread_cleanup(void *arg) {
|
|
struct plugind *cd = (struct plugind *)arg;
|
|
|
|
worker_unregister();
|
|
|
|
spinlock_lock(&cd->unsafe.spinlock);
|
|
|
|
cd->unsafe.running = false;
|
|
cd->unsafe.thread = 0;
|
|
|
|
pid_t pid = cd->unsafe.pid;
|
|
cd->unsafe.pid = 0;
|
|
|
|
spinlock_unlock(&cd->unsafe.spinlock);
|
|
|
|
if (pid) {
|
|
siginfo_t info;
|
|
netdata_log_info("PLUGINSD: 'host:%s', killing data collection child process with pid %d",
|
|
rrdhost_hostname(cd->host), pid);
|
|
|
|
if (killpid(pid) != -1) {
|
|
netdata_log_info("PLUGINSD: 'host:%s', waiting for data collection child process pid %d to exit...",
|
|
rrdhost_hostname(cd->host), pid);
|
|
|
|
netdata_waitid(P_PID, (id_t)pid, &info, WEXITED);
|
|
}
|
|
}
|
|
}
|
|
|
|
#define SERIAL_FAILURES_THRESHOLD 10
|
|
static void pluginsd_worker_thread_handle_success(struct plugind *cd) {
|
|
if (likely(cd->successful_collections)) {
|
|
sleep((unsigned int)cd->update_every);
|
|
return;
|
|
}
|
|
|
|
if (likely(cd->serial_failures <= SERIAL_FAILURES_THRESHOLD)) {
|
|
netdata_log_info("PLUGINSD: 'host:%s', '%s' (pid %d) does not generate useful output but it reports success (exits with 0). %s.",
|
|
rrdhost_hostname(cd->host), cd->fullfilename, cd->unsafe.pid,
|
|
plugin_is_enabled(cd) ? "Waiting a bit before starting it again." : "Will not start it again - it is now disabled.");
|
|
|
|
sleep((unsigned int)(cd->update_every * 10));
|
|
return;
|
|
}
|
|
|
|
if (cd->serial_failures > SERIAL_FAILURES_THRESHOLD) {
|
|
netdata_log_error("PLUGINSD: 'host:'%s', '%s' (pid %d) does not generate useful output, "
|
|
"although it reports success (exits with 0)."
|
|
"We have tried to collect something %zu times - unsuccessfully. Disabling it.",
|
|
rrdhost_hostname(cd->host), cd->fullfilename, cd->unsafe.pid, cd->serial_failures);
|
|
plugin_set_disabled(cd);
|
|
return;
|
|
}
|
|
}
|
|
|
|
static void pluginsd_worker_thread_handle_error(struct plugind *cd, int worker_ret_code) {
|
|
if (worker_ret_code == -1) {
|
|
netdata_log_info("PLUGINSD: 'host:%s', '%s' (pid %d) was killed with SIGTERM. Disabling it.",
|
|
rrdhost_hostname(cd->host), cd->fullfilename, cd->unsafe.pid);
|
|
plugin_set_disabled(cd);
|
|
return;
|
|
}
|
|
|
|
if (!cd->successful_collections) {
|
|
netdata_log_error("PLUGINSD: 'host:%s', '%s' (pid %d) exited with error code %d and haven't collected any data. Disabling it.",
|
|
rrdhost_hostname(cd->host), cd->fullfilename, cd->unsafe.pid, worker_ret_code);
|
|
plugin_set_disabled(cd);
|
|
return;
|
|
}
|
|
|
|
if (cd->serial_failures <= SERIAL_FAILURES_THRESHOLD) {
|
|
netdata_log_error("PLUGINSD: 'host:%s', '%s' (pid %d) exited with error code %d, but has given useful output in the past (%zu times). %s",
|
|
rrdhost_hostname(cd->host), cd->fullfilename, cd->unsafe.pid, worker_ret_code, cd->successful_collections,
|
|
plugin_is_enabled(cd) ? "Waiting a bit before starting it again." : "Will not start it again - it is disabled.");
|
|
sleep((unsigned int)(cd->update_every * 10));
|
|
return;
|
|
}
|
|
|
|
if (cd->serial_failures > SERIAL_FAILURES_THRESHOLD) {
|
|
netdata_log_error("PLUGINSD: 'host:%s', '%s' (pid %d) exited with error code %d, but has given useful output in the past (%zu times)."
|
|
"We tried to restart it %zu times, but it failed to generate data. Disabling it.",
|
|
rrdhost_hostname(cd->host), cd->fullfilename, cd->unsafe.pid, worker_ret_code,
|
|
cd->successful_collections, cd->serial_failures);
|
|
plugin_set_disabled(cd);
|
|
return;
|
|
}
|
|
}
|
|
|
|
#undef SERIAL_FAILURES_THRESHOLD
|
|
|
|
static void *pluginsd_worker_thread(void *arg) {
|
|
worker_register("PLUGINSD");
|
|
|
|
netdata_thread_cleanup_push(pluginsd_worker_thread_cleanup, arg);
|
|
|
|
{
|
|
struct plugind *cd = (struct plugind *) arg;
|
|
plugin_set_running(cd);
|
|
|
|
size_t count = 0;
|
|
|
|
while(service_running(SERVICE_COLLECTORS)) {
|
|
FILE *fp_child_input = NULL;
|
|
FILE *fp_child_output = netdata_popen(cd->cmd, &cd->unsafe.pid, &fp_child_input);
|
|
|
|
if(unlikely(!fp_child_input || !fp_child_output)) {
|
|
netdata_log_error("PLUGINSD: 'host:%s', cannot popen(\"%s\", \"r\").",
|
|
rrdhost_hostname(cd->host), cd->cmd);
|
|
break;
|
|
}
|
|
|
|
nd_log(NDLS_DAEMON, NDLP_DEBUG,
|
|
"PLUGINSD: 'host:%s' connected to '%s' running on pid %d",
|
|
rrdhost_hostname(cd->host),
|
|
cd->fullfilename, cd->unsafe.pid);
|
|
|
|
const char *plugin = strrchr(cd->fullfilename, '/');
|
|
if(plugin)
|
|
plugin++;
|
|
else
|
|
plugin = cd->fullfilename;
|
|
|
|
char module[100];
|
|
snprintfz(module, sizeof(module), "plugins.d[%s]", plugin);
|
|
ND_LOG_STACK lgs[] = {
|
|
ND_LOG_FIELD_TXT(NDF_MODULE, module),
|
|
ND_LOG_FIELD_TXT(NDF_NIDL_NODE, rrdhost_hostname(cd->host)),
|
|
ND_LOG_FIELD_TXT(NDF_SRC_TRANSPORT, "pluginsd"),
|
|
ND_LOG_FIELD_END(),
|
|
};
|
|
ND_LOG_STACK_PUSH(lgs);
|
|
|
|
count = pluginsd_process(cd->host, cd, fp_child_input, fp_child_output, 0);
|
|
|
|
nd_log(NDLS_DAEMON, NDLP_DEBUG,
|
|
"PLUGINSD: 'host:%s', '%s' (pid %d) disconnected after %zu successful data collections (ENDs).",
|
|
rrdhost_hostname(cd->host), cd->fullfilename, cd->unsafe.pid, count);
|
|
|
|
killpid(cd->unsafe.pid);
|
|
|
|
int worker_ret_code = netdata_pclose(fp_child_input, fp_child_output, cd->unsafe.pid);
|
|
|
|
if(likely(worker_ret_code == 0))
|
|
pluginsd_worker_thread_handle_success(cd);
|
|
else
|
|
pluginsd_worker_thread_handle_error(cd, worker_ret_code);
|
|
|
|
cd->unsafe.pid = 0;
|
|
|
|
if(unlikely(!plugin_is_enabled(cd)))
|
|
break;
|
|
}
|
|
}
|
|
|
|
netdata_thread_cleanup_pop(1);
|
|
return NULL;
|
|
}
|
|
|
|
static void pluginsd_main_cleanup(void *data) {
|
|
struct netdata_static_thread *static_thread = (struct netdata_static_thread *)data;
|
|
static_thread->enabled = NETDATA_MAIN_THREAD_EXITING;
|
|
netdata_log_info("PLUGINSD: cleaning up...");
|
|
|
|
struct plugind *cd;
|
|
for (cd = pluginsd_root; cd; cd = cd->next) {
|
|
spinlock_lock(&cd->unsafe.spinlock);
|
|
if (cd->unsafe.enabled && cd->unsafe.running && cd->unsafe.thread != 0) {
|
|
netdata_log_info("PLUGINSD: 'host:%s', stopping plugin thread: %s",
|
|
rrdhost_hostname(cd->host), cd->id);
|
|
|
|
netdata_thread_cancel(cd->unsafe.thread);
|
|
}
|
|
spinlock_unlock(&cd->unsafe.spinlock);
|
|
}
|
|
|
|
netdata_log_info("PLUGINSD: cleanup completed.");
|
|
static_thread->enabled = NETDATA_MAIN_THREAD_EXITED;
|
|
|
|
worker_unregister();
|
|
}
|
|
|
|
void *pluginsd_main(void *ptr)
|
|
{
|
|
netdata_thread_cleanup_push(pluginsd_main_cleanup, ptr);
|
|
|
|
int automatic_run = config_get_boolean(CONFIG_SECTION_PLUGINS, "enable running new plugins", 1);
|
|
int scan_frequency = (int)config_get_number(CONFIG_SECTION_PLUGINS, "check for new plugins every", 60);
|
|
if (scan_frequency < 1)
|
|
scan_frequency = 1;
|
|
|
|
// disable some plugins by default
|
|
config_get_boolean(CONFIG_SECTION_PLUGINS, "slabinfo", CONFIG_BOOLEAN_NO);
|
|
// it crashes (both threads) on Alpine after we made it multi-threaded
|
|
// works with "--device /dev/ipmi0", but this is not default
|
|
// see https://github.com/netdata/netdata/pull/15564 for details
|
|
if (getenv("NETDATA_LISTENER_PORT"))
|
|
config_get_boolean(CONFIG_SECTION_PLUGINS, "freeipmi", CONFIG_BOOLEAN_NO);
|
|
|
|
// store the errno for each plugins directory
|
|
// so that we don't log broken directories on each loop
|
|
int directory_errors[PLUGINSD_MAX_DIRECTORIES] = { 0 };
|
|
|
|
while (service_running(SERVICE_COLLECTORS)) {
|
|
int idx;
|
|
const char *directory_name;
|
|
|
|
for (idx = 0; idx < PLUGINSD_MAX_DIRECTORIES && (directory_name = plugin_directories[idx]); idx++) {
|
|
if (unlikely(!service_running(SERVICE_COLLECTORS)))
|
|
break;
|
|
|
|
errno = 0;
|
|
DIR *dir = opendir(directory_name);
|
|
if (unlikely(!dir)) {
|
|
if (directory_errors[idx] != errno) {
|
|
directory_errors[idx] = errno;
|
|
netdata_log_error("cannot open plugins directory '%s'", directory_name);
|
|
}
|
|
continue;
|
|
}
|
|
|
|
struct dirent *file = NULL;
|
|
while (likely((file = readdir(dir)))) {
|
|
if (unlikely(!service_running(SERVICE_COLLECTORS)))
|
|
break;
|
|
|
|
netdata_log_debug(D_PLUGINSD, "examining file '%s'", file->d_name);
|
|
|
|
if (unlikely(strcmp(file->d_name, ".") == 0 || strcmp(file->d_name, "..") == 0))
|
|
continue;
|
|
|
|
int len = (int)strlen(file->d_name);
|
|
if (unlikely(len <= (int)PLUGINSD_FILE_SUFFIX_LEN))
|
|
continue;
|
|
if (unlikely(strcmp(PLUGINSD_FILE_SUFFIX, &file->d_name[len - (int)PLUGINSD_FILE_SUFFIX_LEN]) != 0)) {
|
|
netdata_log_debug(D_PLUGINSD, "file '%s' does not end in '%s'", file->d_name, PLUGINSD_FILE_SUFFIX);
|
|
continue;
|
|
}
|
|
|
|
char pluginname[CONFIG_MAX_NAME + 1];
|
|
snprintfz(pluginname, CONFIG_MAX_NAME, "%.*s", (int)(len - PLUGINSD_FILE_SUFFIX_LEN), file->d_name);
|
|
int enabled = config_get_boolean(CONFIG_SECTION_PLUGINS, pluginname, automatic_run);
|
|
|
|
if (unlikely(!enabled)) {
|
|
netdata_log_debug(D_PLUGINSD, "plugin '%s' is not enabled", file->d_name);
|
|
continue;
|
|
}
|
|
|
|
// check if it runs already
|
|
struct plugind *cd;
|
|
for (cd = pluginsd_root; cd; cd = cd->next)
|
|
if (unlikely(strcmp(cd->filename, file->d_name) == 0))
|
|
break;
|
|
|
|
if (likely(cd && plugin_is_running(cd))) {
|
|
netdata_log_debug(D_PLUGINSD, "plugin '%s' is already running", cd->filename);
|
|
continue;
|
|
}
|
|
|
|
// it is not running
|
|
// allocate a new one, or use the obsolete one
|
|
if (unlikely(!cd)) {
|
|
cd = callocz(sizeof(struct plugind), 1);
|
|
|
|
snprintfz(cd->id, CONFIG_MAX_NAME, "plugin:%s", pluginname);
|
|
|
|
strncpyz(cd->filename, file->d_name, FILENAME_MAX);
|
|
snprintfz(cd->fullfilename, FILENAME_MAX, "%s/%s", directory_name, cd->filename);
|
|
|
|
cd->host = localhost;
|
|
cd->unsafe.enabled = enabled;
|
|
cd->unsafe.running = false;
|
|
|
|
cd->update_every = (int)config_get_number(cd->id, "update every", localhost->rrd_update_every);
|
|
cd->started_t = now_realtime_sec();
|
|
|
|
char *def = "";
|
|
snprintfz(
|
|
cd->cmd, PLUGINSD_CMD_MAX, "exec %s %d %s", cd->fullfilename, cd->update_every,
|
|
config_get(cd->id, "command options", def));
|
|
|
|
// link it
|
|
DOUBLE_LINKED_LIST_PREPEND_ITEM_UNSAFE(pluginsd_root, cd, prev, next);
|
|
|
|
if (plugin_is_enabled(cd)) {
|
|
char tag[NETDATA_THREAD_TAG_MAX + 1];
|
|
snprintfz(tag, NETDATA_THREAD_TAG_MAX, "PD[%s]", pluginname);
|
|
|
|
// spawn a new thread for it
|
|
netdata_thread_create(&cd->unsafe.thread,
|
|
tag,
|
|
NETDATA_THREAD_OPTION_DEFAULT,
|
|
pluginsd_worker_thread,
|
|
cd);
|
|
}
|
|
}
|
|
}
|
|
|
|
closedir(dir);
|
|
}
|
|
|
|
sleep((unsigned int)scan_frequency);
|
|
}
|
|
|
|
netdata_thread_cleanup_pop(1);
|
|
return NULL;
|
|
}
|