mirror of
https://github.com/netdata/netdata.git
synced 2025-04-09 15:47:53 +00:00

* rrdset - in progress * rrdset optimal constructor; rrdset conflict * rrdset final touches * re-organization of rrdset object members * prevent use-after-free * dictionary dfe supports also counting of iterations * rrddim managed by dictionary * rrd.h cleanup * DICTIONARY_ITEM now is referencing actual dictionary items in the code * removed rrdset linked list * Revert "removed rrdset linked list" This reverts commit 690d6a588b4b99619c2c5e10f84e8f868ae6def5. * removed rrdset linked list * added comments * Switch chart uuid to static allocation in rrdset Remove unused functions * rrdset_archive() and friends... * always create rrdfamily * enable ml_free_dimension * rrddim_foreach done with dfe * most custom rrddim loops replaced with rrddim_foreach * removed accesses to rrddim->dimensions * removed locks that are no longer needed * rrdsetvar is now managed by the dictionary * set rrdset is rrdsetvar, fixes https://github.com/netdata/netdata/pull/13646#issuecomment-1242574853 * conflict callback of rrdsetvar now properly checks if it has to reset the variable * dictionary registered callbacks accept as first parameter the DICTIONARY_ITEM * dictionary dfe now uses internal counter to report; avoided excess variables defined with dfe * dictionary walkthrough callbacks get dictionary acquired items * dictionary reference counters that can be dupped from zero * added advanced functions for get and del * rrdvar managed by dictionaries * thread safety for rrdsetvar * faster rrdvar initialization * rrdvar string lengths should match in all add, del, get functions * rrdvar internals hidden from the rest of the world * rrdvar is now acquired throughout netdata * hide the internal structures of rrdsetvar * rrdsetvar is now acquired through out netdata * rrddimvar managed by dictionary; rrddimvar linked list removed; rrddimvar structures hidden from the rest of netdata * better error handling * dont create variables if not initialized for health * dont create variables if not initialized for health again * rrdfamily is now managed by dictionaries; references of it are acquired dictionary items * type checking on acquired objects * rrdcalc renaming of functions * type checking for rrdfamily_acquired * rrdcalc managed by dictionaries * rrdcalc double free fix * host rrdvars is always needed * attempt to fix deadlock 1 * attempt to fix deadlock 2 * Remove unused variable * attempt to fix deadlock 3 * snprintfz * rrdcalc index in rrdset fix * Stop storing active charts and computing chart hashes * Remove store active chart function * Remove compute chart hash function * Remove sql_store_chart_hash function * Remove store_active_dimension function * dictionary delayed destruction * formatting and cleanup * zero dictionary base on rrdsetvar * added internal error to log delayed destructions of dictionaries * typo in rrddimvar * added debugging info to dictionary * debug info * fix for rrdcalc keys being empty * remove forgotten unlock * remove deadlock * Switch to metadata version 5 and drop chart_hash chart_hash_map chart_active dimension_active v_chart_hash * SQL cosmetic changes * do not busy wait while destroying a referenced dictionary * remove deadlock * code cleanup; re-organization; * fast cleanup and flushing of dictionaries * number formatting fixes * do not delete configured alerts when archiving a chart * rrddim obsolete linked list management outside dictionaries * removed duplicate contexts call * fix crash when rrdfamily is not initialized * dont keep rrddimvar referenced * properly cleanup rrdvar * removed some locks * Do not attempt to cleanup chart_hash / chart_hash_map * rrdcalctemplate managed by dictionary * register callbacks on the right dictionary * removed some more locks * rrdcalc secondary index replaced with linked-list; rrdcalc labels updates are now executed by health thread * when looking up for an alarm look using both chart id and chart name * host initialization a bit more modular * init rrdlabels on host update * preparation for dictionary views * improved comment * unused variables without internal checks * service threads isolation and worker info * more worker info in service thread * thread cancelability debugging with internal checks * strings data races addressed; fixes https://github.com/netdata/netdata/issues/13647 * dictionary modularization * Remove unused SQL statement definition * unit-tested thread safety of dictionaries; removed data race conditions on dictionaries and strings; dictionaries now can detect if the caller is holds a write lock and automatically all the calls become their unsafe versions; all direct calls to unsafe version is eliminated * remove worker_is_idle() from the exit of service functions, because we lose the lock time between loops * rewritten dictionary to have 2 separate locks, one for indexing and another for traversal * Update collectors/cgroups.plugin/sys_fs_cgroup.c Co-authored-by: Vladimir Kobal <vlad@prokk.net> * Update collectors/cgroups.plugin/sys_fs_cgroup.c Co-authored-by: Vladimir Kobal <vlad@prokk.net> * Update collectors/proc.plugin/proc_net_dev.c Co-authored-by: Vladimir Kobal <vlad@prokk.net> * fix memory leak in rrdset cache_dir * minor dictionary changes * dont use index locks in single threaded * obsolete dict option * rrddim options and flags separation; rrdset_done() optimization to keep array of reference pointers to rrddim; * fix jump on uninitialized value in dictionary; remove double free of cache_dir * addressed codacy findings * removed debugging code * use the private refcount on dictionaries * make dictionary item desctructors work on dictionary destruction; strictier control on dictionary API; proper cleanup sequence on rrddim; * more dictionary statistics * global statistics about dictionary operations, memory, items, callbacks * dictionary support for views - missing the public API * removed warning about unused parameter * chart and context name for cloud * chart and context name for cloud, again * dictionary statistics fixed; first implementation of dictionary views - not currently used * only the master can globally delete an item * context needs netdata prefix * fix context and chart it of spins * fix for host variables when health is not enabled * run garbage collector on item insert too * Fix info message; remove extra "using" * update dict unittest for new placement of garbage collector * we need RRDHOST->rrdvars for maintaining custom host variables * Health initialization needs the host->host_uuid * split STRING to its own files; no code changes other than that * initialize health unconditionally * unit tests do not pollute the global scope with their variables * Skip initialization when creating archived hosts on startup. When a child connects it will initialize properly Co-authored-by: Stelios Fragkakis <52996999+stelfrag@users.noreply.github.com> Co-authored-by: Vladimir Kobal <vlad@prokk.net>
282 lines
9.6 KiB
C
282 lines
9.6 KiB
C
// SPDX-License-Identifier: GPL-3.0-or-later
|
|
|
|
#include "common.h"
|
|
|
|
/* Run service jobs every X seconds */
|
|
#define SERVICE_HEARTBEAT 10
|
|
|
|
#define WORKER_JOB_CHILD_CHART_OBSOLETION_CHECK 1
|
|
#define WORKER_JOB_CLEANUP_OBSOLETE_CHARTS 2
|
|
#define WORKER_JOB_ARCHIVE_CHART 3
|
|
#define WORKER_JOB_ARCHIVE_CHART_DIMENSIONS 4
|
|
#define WORKER_JOB_ARCHIVE_DIMENSION 5
|
|
#define WORKER_JOB_CLEANUP_ORPHAN_HOSTS 6
|
|
#define WORKER_JOB_CLEANUP_OBSOLETE_CHARTS_ON_HOSTS 7
|
|
#define WORKER_JOB_FREE_HOST 9
|
|
#define WORKER_JOB_SAVE_HOST_CHARTS 10
|
|
#define WORKER_JOB_DELETE_HOST_CHARTS 11
|
|
#define WORKER_JOB_FREE_CHART 12
|
|
#define WORKER_JOB_SAVE_CHART 13
|
|
#define WORKER_JOB_DELETE_CHART 14
|
|
#define WORKER_JOB_FREE_DIMENSION 15
|
|
|
|
static void svc_rrddim_obsolete_to_archive(RRDDIM *rd) {
|
|
RRDSET *st = rd->rrdset;
|
|
|
|
if(rrddim_flag_check(rd, RRDDIM_FLAG_ARCHIVED | RRDDIM_FLAG_ACLK) || !rrddim_flag_check(rd, RRDDIM_FLAG_OBSOLETE))
|
|
return;
|
|
|
|
worker_is_busy(WORKER_JOB_ARCHIVE_DIMENSION);
|
|
|
|
rrddim_flag_set(rd, RRDDIM_FLAG_ARCHIVED);
|
|
rrddim_flag_clear(rd, RRDDIM_FLAG_OBSOLETE);
|
|
|
|
const char *cache_filename = rrddim_cache_filename(rd);
|
|
if(cache_filename) {
|
|
info("Deleting dimension file '%s'.", cache_filename);
|
|
if (unlikely(unlink(cache_filename) == -1))
|
|
error("Cannot delete dimension file '%s'", cache_filename);
|
|
}
|
|
|
|
if (rd->rrd_memory_mode == RRD_MEMORY_MODE_DBENGINE) {
|
|
rrddimvar_delete_all(rd);
|
|
|
|
/* only a collector can mark a chart as obsolete, so we must remove the reference */
|
|
|
|
size_t tiers_available = 0, tiers_said_yes = 0;
|
|
for(int tier = 0; tier < storage_tiers ;tier++) {
|
|
if(rd->tiers[tier]) {
|
|
tiers_available++;
|
|
|
|
if(rd->tiers[tier]->collect_ops.finalize(rd->tiers[tier]->db_collection_handle))
|
|
tiers_said_yes++;
|
|
|
|
rd->tiers[tier]->db_collection_handle = NULL;
|
|
}
|
|
}
|
|
|
|
if (tiers_available == tiers_said_yes && tiers_said_yes) {
|
|
/* This metric has no data and no references */
|
|
delete_dimension_uuid(&rd->metric_uuid);
|
|
}
|
|
else {
|
|
/* Do not delete this dimension */
|
|
#ifdef ENABLE_ACLK
|
|
queue_dimension_to_aclk(rd, calc_dimension_liveness(rd, now_realtime_sec()));
|
|
#endif
|
|
return;
|
|
}
|
|
}
|
|
|
|
worker_is_busy(WORKER_JOB_FREE_DIMENSION);
|
|
rrddim_free(st, rd);
|
|
}
|
|
|
|
static void svc_rrdset_archive_obsolete_dimensions(RRDSET *st, bool all_dimensions) {
|
|
worker_is_busy(WORKER_JOB_ARCHIVE_CHART_DIMENSIONS);
|
|
|
|
RRDDIM *rd;
|
|
time_t now = now_realtime_sec();
|
|
|
|
dfe_start_reentrant(st->rrddim_root_index, rd) {
|
|
if(unlikely(
|
|
all_dimensions ||
|
|
(rrddim_flag_check(rd, RRDDIM_FLAG_OBSOLETE) && (rd->last_collected_time.tv_sec + rrdset_free_obsolete_time < now))
|
|
)) {
|
|
|
|
info("Removing obsolete dimension '%s' (%s) of '%s' (%s).", rrddim_name(rd), rrddim_id(rd), rrdset_name(st), rrdset_id(st));
|
|
svc_rrddim_obsolete_to_archive(rd);
|
|
|
|
}
|
|
}
|
|
dfe_done(rd);
|
|
}
|
|
|
|
static void svc_rrdset_obsolete_to_archive(RRDSET *st) {
|
|
worker_is_busy(WORKER_JOB_ARCHIVE_CHART);
|
|
|
|
rrdset_flag_set(st, RRDSET_FLAG_ARCHIVED);
|
|
rrdset_flag_clear(st, RRDSET_FLAG_OBSOLETE);
|
|
|
|
rrdcalc_unlink_all_rrdset_alerts(st);
|
|
|
|
svc_rrdset_archive_obsolete_dimensions(st, true);
|
|
|
|
rrdsetvar_release_and_delete_all(st);
|
|
|
|
// has to be run after all dimensions are archived - or use-after-free will occur
|
|
rrdvar_delete_all(st->rrdvars);
|
|
|
|
if(st->rrd_memory_mode != RRD_MEMORY_MODE_DBENGINE) {
|
|
if(rrdhost_flag_check(st->rrdhost, RRDHOST_FLAG_DELETE_OBSOLETE_CHARTS)) {
|
|
worker_is_busy(WORKER_JOB_DELETE_CHART);
|
|
rrdset_delete_files(st);
|
|
}
|
|
else {
|
|
worker_is_busy(WORKER_JOB_SAVE_CHART);
|
|
rrdset_save(st);
|
|
}
|
|
|
|
worker_is_busy(WORKER_JOB_FREE_CHART);
|
|
rrdset_free(st);
|
|
}
|
|
}
|
|
|
|
static void svc_rrdhost_cleanup_obsolete_charts(RRDHOST *host) {
|
|
worker_is_busy(WORKER_JOB_CLEANUP_OBSOLETE_CHARTS);
|
|
|
|
time_t now = now_realtime_sec();
|
|
RRDSET *st;
|
|
rrdset_foreach_reentrant(st, host) {
|
|
if(unlikely(rrdset_flag_check(st, RRDSET_FLAG_OBSOLETE)
|
|
&& st->last_accessed_time + rrdset_free_obsolete_time < now
|
|
&& st->last_updated.tv_sec + rrdset_free_obsolete_time < now
|
|
&& st->last_collected_time.tv_sec + rrdset_free_obsolete_time < now
|
|
)) {
|
|
svc_rrdset_obsolete_to_archive(st);
|
|
}
|
|
else if(rrdset_flag_check(st, RRDSET_FLAG_OBSOLETE_DIMENSIONS)) {
|
|
rrdset_flag_clear(st, RRDSET_FLAG_OBSOLETE_DIMENSIONS);
|
|
svc_rrdset_archive_obsolete_dimensions(st, false);
|
|
}
|
|
#ifdef ENABLE_ACLK
|
|
else
|
|
sql_check_chart_liveness(st);
|
|
#endif
|
|
}
|
|
rrdset_foreach_done(st);
|
|
}
|
|
|
|
static void svc_rrdset_check_obsoletion(RRDHOST *host) {
|
|
worker_is_busy(WORKER_JOB_CHILD_CHART_OBSOLETION_CHECK);
|
|
|
|
time_t last_entry_t;
|
|
RRDSET *st;
|
|
rrdset_foreach_read(st, host) {
|
|
last_entry_t = rrdset_last_entry_t(st);
|
|
|
|
if(last_entry_t && last_entry_t < host->senders_connect_time)
|
|
rrdset_is_obsolete(st);
|
|
|
|
}
|
|
rrdset_foreach_done(st);
|
|
}
|
|
|
|
static void svc_rrd_cleanup_obsolete_charts_from_all_hosts() {
|
|
worker_is_busy(WORKER_JOB_CLEANUP_OBSOLETE_CHARTS_ON_HOSTS);
|
|
|
|
rrd_rdlock();
|
|
|
|
RRDHOST *host;
|
|
rrdhost_foreach_read(host) {
|
|
|
|
if(rrdhost_flag_check(host, RRDHOST_FLAG_PENDING_OBSOLETE_CHARTS|RRDHOST_FLAG_PENDING_OBSOLETE_DIMENSIONS)) {
|
|
rrdhost_flag_clear(host, RRDHOST_FLAG_PENDING_OBSOLETE_CHARTS|RRDHOST_FLAG_PENDING_OBSOLETE_DIMENSIONS);
|
|
svc_rrdhost_cleanup_obsolete_charts(host);
|
|
}
|
|
|
|
if(host != localhost
|
|
&& host->trigger_chart_obsoletion_check
|
|
&& (
|
|
(
|
|
host->senders_last_chart_command
|
|
&& host->senders_last_chart_command + host->health_delay_up_to < now_realtime_sec()
|
|
)
|
|
|| (host->senders_connect_time + 300 < now_realtime_sec())
|
|
)
|
|
) {
|
|
svc_rrdset_check_obsoletion(host);
|
|
host->trigger_chart_obsoletion_check = 0;
|
|
|
|
}
|
|
}
|
|
|
|
rrd_unlock();
|
|
}
|
|
|
|
static void svc_rrdhost_cleanup_orphan_hosts(RRDHOST *protected_host) {
|
|
worker_is_busy(WORKER_JOB_CLEANUP_ORPHAN_HOSTS);
|
|
rrd_wrlock();
|
|
|
|
time_t now = now_realtime_sec();
|
|
|
|
RRDHOST *host;
|
|
|
|
restart_after_removal:
|
|
rrdhost_foreach_write(host) {
|
|
if(rrdhost_should_be_removed(host, protected_host, now)) {
|
|
info("Host '%s' with machine guid '%s' is obsolete - cleaning up.", rrdhost_hostname(host), host->machine_guid);
|
|
|
|
if (rrdhost_flag_check(host, RRDHOST_FLAG_DELETE_ORPHAN_HOST)
|
|
#ifdef ENABLE_DBENGINE
|
|
/* don't delete multi-host DB host files */
|
|
&& !(host->rrd_memory_mode == RRD_MEMORY_MODE_DBENGINE && is_storage_engine_shared(host->storage_instance[0]))
|
|
#endif
|
|
) {
|
|
worker_is_busy(WORKER_JOB_DELETE_HOST_CHARTS);
|
|
rrdhost_delete_charts(host);
|
|
}
|
|
else {
|
|
worker_is_busy(WORKER_JOB_SAVE_HOST_CHARTS);
|
|
rrdhost_save_charts(host);
|
|
}
|
|
|
|
worker_is_busy(WORKER_JOB_FREE_HOST);
|
|
rrdhost_free(host, 0);
|
|
goto restart_after_removal;
|
|
}
|
|
}
|
|
|
|
rrd_unlock();
|
|
}
|
|
|
|
static void service_main_cleanup(void *ptr)
|
|
{
|
|
struct netdata_static_thread *static_thread = (struct netdata_static_thread *)ptr;
|
|
static_thread->enabled = NETDATA_MAIN_THREAD_EXITING;
|
|
|
|
debug(D_SYSTEM, "Cleaning up...");
|
|
worker_unregister();
|
|
|
|
static_thread->enabled = NETDATA_MAIN_THREAD_EXITED;
|
|
}
|
|
|
|
/*
|
|
* The service thread.
|
|
*/
|
|
void *service_main(void *ptr)
|
|
{
|
|
worker_register("SERVICE");
|
|
worker_register_job_name(WORKER_JOB_CHILD_CHART_OBSOLETION_CHECK, "child chart obsoletion check");
|
|
worker_register_job_name(WORKER_JOB_CLEANUP_OBSOLETE_CHARTS, "cleanup obsolete charts");
|
|
worker_register_job_name(WORKER_JOB_ARCHIVE_CHART, "archive chart");
|
|
worker_register_job_name(WORKER_JOB_ARCHIVE_CHART_DIMENSIONS, "archive chart dimensions");
|
|
worker_register_job_name(WORKER_JOB_ARCHIVE_DIMENSION, "archive dimension");
|
|
worker_register_job_name(WORKER_JOB_CLEANUP_ORPHAN_HOSTS, "cleanup orphan hosts");
|
|
worker_register_job_name(WORKER_JOB_CLEANUP_OBSOLETE_CHARTS_ON_HOSTS, "cleanup obsolete charts on all hosts");
|
|
worker_register_job_name(WORKER_JOB_FREE_HOST, "free host");
|
|
worker_register_job_name(WORKER_JOB_SAVE_HOST_CHARTS, "save host charts");
|
|
worker_register_job_name(WORKER_JOB_DELETE_HOST_CHARTS, "delete host charts");
|
|
worker_register_job_name(WORKER_JOB_FREE_CHART, "free chart");
|
|
worker_register_job_name(WORKER_JOB_SAVE_CHART, "save chart");
|
|
worker_register_job_name(WORKER_JOB_DELETE_CHART, "delete chart");
|
|
worker_register_job_name(WORKER_JOB_FREE_DIMENSION, "free dimension");
|
|
|
|
netdata_thread_cleanup_push(service_main_cleanup, ptr);
|
|
heartbeat_t hb;
|
|
heartbeat_init(&hb);
|
|
usec_t step = USEC_PER_SEC * SERVICE_HEARTBEAT;
|
|
|
|
debug(D_SYSTEM, "Service thread starts");
|
|
|
|
while (!netdata_exit) {
|
|
worker_is_idle();
|
|
heartbeat_next(&hb, step);
|
|
|
|
svc_rrd_cleanup_obsolete_charts_from_all_hosts();
|
|
svc_rrdhost_cleanup_orphan_hosts(localhost);
|
|
}
|
|
|
|
netdata_thread_cleanup_pop(1);
|
|
return NULL;
|
|
}
|