mirror of
https://github.com/netdata/netdata.git
synced 2025-04-06 14:35:32 +00:00

* rrdset - in progress * rrdset optimal constructor; rrdset conflict * rrdset final touches * re-organization of rrdset object members * prevent use-after-free * dictionary dfe supports also counting of iterations * rrddim managed by dictionary * rrd.h cleanup * DICTIONARY_ITEM now is referencing actual dictionary items in the code * removed rrdset linked list * Revert "removed rrdset linked list" This reverts commit 690d6a588b4b99619c2c5e10f84e8f868ae6def5. * removed rrdset linked list * added comments * Switch chart uuid to static allocation in rrdset Remove unused functions * rrdset_archive() and friends... * always create rrdfamily * enable ml_free_dimension * rrddim_foreach done with dfe * most custom rrddim loops replaced with rrddim_foreach * removed accesses to rrddim->dimensions * removed locks that are no longer needed * rrdsetvar is now managed by the dictionary * set rrdset is rrdsetvar, fixes https://github.com/netdata/netdata/pull/13646#issuecomment-1242574853 * conflict callback of rrdsetvar now properly checks if it has to reset the variable * dictionary registered callbacks accept as first parameter the DICTIONARY_ITEM * dictionary dfe now uses internal counter to report; avoided excess variables defined with dfe * dictionary walkthrough callbacks get dictionary acquired items * dictionary reference counters that can be dupped from zero * added advanced functions for get and del * rrdvar managed by dictionaries * thread safety for rrdsetvar * faster rrdvar initialization * rrdvar string lengths should match in all add, del, get functions * rrdvar internals hidden from the rest of the world * rrdvar is now acquired throughout netdata * hide the internal structures of rrdsetvar * rrdsetvar is now acquired through out netdata * rrddimvar managed by dictionary; rrddimvar linked list removed; rrddimvar structures hidden from the rest of netdata * better error handling * dont create variables if not initialized for health * dont create variables if not initialized for health again * rrdfamily is now managed by dictionaries; references of it are acquired dictionary items * type checking on acquired objects * rrdcalc renaming of functions * type checking for rrdfamily_acquired * rrdcalc managed by dictionaries * rrdcalc double free fix * host rrdvars is always needed * attempt to fix deadlock 1 * attempt to fix deadlock 2 * Remove unused variable * attempt to fix deadlock 3 * snprintfz * rrdcalc index in rrdset fix * Stop storing active charts and computing chart hashes * Remove store active chart function * Remove compute chart hash function * Remove sql_store_chart_hash function * Remove store_active_dimension function * dictionary delayed destruction * formatting and cleanup * zero dictionary base on rrdsetvar * added internal error to log delayed destructions of dictionaries * typo in rrddimvar * added debugging info to dictionary * debug info * fix for rrdcalc keys being empty * remove forgotten unlock * remove deadlock * Switch to metadata version 5 and drop chart_hash chart_hash_map chart_active dimension_active v_chart_hash * SQL cosmetic changes * do not busy wait while destroying a referenced dictionary * remove deadlock * code cleanup; re-organization; * fast cleanup and flushing of dictionaries * number formatting fixes * do not delete configured alerts when archiving a chart * rrddim obsolete linked list management outside dictionaries * removed duplicate contexts call * fix crash when rrdfamily is not initialized * dont keep rrddimvar referenced * properly cleanup rrdvar * removed some locks * Do not attempt to cleanup chart_hash / chart_hash_map * rrdcalctemplate managed by dictionary * register callbacks on the right dictionary * removed some more locks * rrdcalc secondary index replaced with linked-list; rrdcalc labels updates are now executed by health thread * when looking up for an alarm look using both chart id and chart name * host initialization a bit more modular * init rrdlabels on host update * preparation for dictionary views * improved comment * unused variables without internal checks * service threads isolation and worker info * more worker info in service thread * thread cancelability debugging with internal checks * strings data races addressed; fixes https://github.com/netdata/netdata/issues/13647 * dictionary modularization * Remove unused SQL statement definition * unit-tested thread safety of dictionaries; removed data race conditions on dictionaries and strings; dictionaries now can detect if the caller is holds a write lock and automatically all the calls become their unsafe versions; all direct calls to unsafe version is eliminated * remove worker_is_idle() from the exit of service functions, because we lose the lock time between loops * rewritten dictionary to have 2 separate locks, one for indexing and another for traversal * Update collectors/cgroups.plugin/sys_fs_cgroup.c Co-authored-by: Vladimir Kobal <vlad@prokk.net> * Update collectors/cgroups.plugin/sys_fs_cgroup.c Co-authored-by: Vladimir Kobal <vlad@prokk.net> * Update collectors/proc.plugin/proc_net_dev.c Co-authored-by: Vladimir Kobal <vlad@prokk.net> * fix memory leak in rrdset cache_dir * minor dictionary changes * dont use index locks in single threaded * obsolete dict option * rrddim options and flags separation; rrdset_done() optimization to keep array of reference pointers to rrddim; * fix jump on uninitialized value in dictionary; remove double free of cache_dir * addressed codacy findings * removed debugging code * use the private refcount on dictionaries * make dictionary item desctructors work on dictionary destruction; strictier control on dictionary API; proper cleanup sequence on rrddim; * more dictionary statistics * global statistics about dictionary operations, memory, items, callbacks * dictionary support for views - missing the public API * removed warning about unused parameter * chart and context name for cloud * chart and context name for cloud, again * dictionary statistics fixed; first implementation of dictionary views - not currently used * only the master can globally delete an item * context needs netdata prefix * fix context and chart it of spins * fix for host variables when health is not enabled * run garbage collector on item insert too * Fix info message; remove extra "using" * update dict unittest for new placement of garbage collector * we need RRDHOST->rrdvars for maintaining custom host variables * Health initialization needs the host->host_uuid * split STRING to its own files; no code changes other than that * initialize health unconditionally * unit tests do not pollute the global scope with their variables * Skip initialization when creating archived hosts on startup. When a child connects it will initialize properly Co-authored-by: Stelios Fragkakis <52996999+stelfrag@users.noreply.github.com> Co-authored-by: Vladimir Kobal <vlad@prokk.net>
222 lines
8.2 KiB
C
222 lines
8.2 KiB
C
// SPDX-License-Identifier: GPL-3.0-or-later
|
|
|
|
#include "rrddim_mem.h"
|
|
|
|
// ----------------------------------------------------------------------------
|
|
// RRDDIM legacy data collection functions
|
|
|
|
STORAGE_METRIC_HANDLE *rrddim_metric_init(RRDDIM *rd, STORAGE_INSTANCE *db_instance __maybe_unused) {
|
|
return (STORAGE_METRIC_HANDLE *)rd;
|
|
}
|
|
|
|
void rrddim_metric_free(STORAGE_METRIC_HANDLE *db_metric_handle __maybe_unused) {
|
|
;
|
|
}
|
|
|
|
STORAGE_COLLECT_HANDLE *rrddim_collect_init(STORAGE_METRIC_HANDLE *db_metric_handle) {
|
|
RRDDIM *rd = (RRDDIM *)db_metric_handle;
|
|
rd->db[rd->rrdset->current_entry] = pack_storage_number(NAN, SN_FLAG_NONE);
|
|
struct mem_collect_handle *ch = calloc(1, sizeof(struct mem_collect_handle));
|
|
ch->rd = rd;
|
|
return (STORAGE_COLLECT_HANDLE *)ch;
|
|
}
|
|
|
|
void rrddim_collect_store_metric(STORAGE_COLLECT_HANDLE *collection_handle, usec_t point_in_time, NETDATA_DOUBLE number,
|
|
NETDATA_DOUBLE min_value,
|
|
NETDATA_DOUBLE max_value,
|
|
uint16_t count,
|
|
uint16_t anomaly_count,
|
|
SN_FLAGS flags)
|
|
{
|
|
UNUSED(point_in_time);
|
|
UNUSED(min_value);
|
|
UNUSED(max_value);
|
|
UNUSED(count);
|
|
UNUSED(anomaly_count);
|
|
|
|
struct mem_collect_handle *ch = (struct mem_collect_handle *)collection_handle;
|
|
RRDDIM *rd = ch->rd;
|
|
rd->db[rd->rrdset->current_entry] = pack_storage_number(number, flags);
|
|
}
|
|
|
|
void rrddim_store_metric_flush(STORAGE_COLLECT_HANDLE *collection_handle) {
|
|
struct mem_collect_handle *ch = (struct mem_collect_handle *)collection_handle;
|
|
RRDDIM *rd = ch->rd;
|
|
memset(rd->db, 0, rd->rrdset->entries * sizeof(storage_number));
|
|
}
|
|
|
|
int rrddim_collect_finalize(STORAGE_COLLECT_HANDLE *collection_handle) {
|
|
free(collection_handle);
|
|
return 0;
|
|
}
|
|
|
|
// ----------------------------------------------------------------------------
|
|
|
|
// get the total duration in seconds of the round robin database
|
|
#define rrddim_duration(st) (( (time_t)(rd)->rrdset->counter >= (time_t)(rd)->rrdset->entries ? (time_t)(rd)->rrdset->entries : (time_t)(rd)->rrdset->counter ) * (time_t)(rd)->rrdset->update_every)
|
|
|
|
// get the last slot updated in the round robin database
|
|
#define rrddim_last_slot(rd) ((size_t)(((rd)->rrdset->current_entry == 0) ? (rd)->rrdset->entries - 1 : (rd)->rrdset->current_entry - 1))
|
|
|
|
// return the slot that has the oldest value
|
|
#define rrddim_first_slot(rd) ((size_t)((rd)->rrdset->counter >= (size_t)(rd)->rrdset->entries ? (rd)->rrdset->current_entry : 0))
|
|
|
|
// get the slot of the round robin database, for the given timestamp (t)
|
|
// it always returns a valid slot, although may not be for the time requested if the time is outside the round robin database
|
|
// only valid when not using dbengine
|
|
static inline size_t rrddim_time2slot(RRDDIM *rd, time_t t) {
|
|
size_t ret = 0;
|
|
time_t last_entry_t = rrddim_query_latest_time((STORAGE_METRIC_HANDLE *)rd);
|
|
time_t first_entry_t = rrddim_query_oldest_time((STORAGE_METRIC_HANDLE *)rd);
|
|
size_t entries = rd->rrdset->entries;
|
|
size_t first_slot = rrddim_first_slot(rd);
|
|
size_t last_slot = rrddim_last_slot(rd);
|
|
size_t update_every = rd->rrdset->update_every;
|
|
|
|
if(t >= last_entry_t) {
|
|
// the requested time is after the last entry we have
|
|
ret = last_slot;
|
|
}
|
|
else {
|
|
if(t <= first_entry_t) {
|
|
// the requested time is before the first entry we have
|
|
ret = first_slot;
|
|
}
|
|
else {
|
|
if(last_slot >= (size_t)((last_entry_t - t) / update_every))
|
|
ret = last_slot - ((last_entry_t - t) / update_every);
|
|
else
|
|
ret = last_slot - ((last_entry_t - t) / update_every) + entries;
|
|
}
|
|
}
|
|
|
|
if(unlikely(ret >= entries)) {
|
|
error("INTERNAL ERROR: rrddim_time2slot() on %s returns values outside entries", rrddim_name(rd));
|
|
ret = entries - 1;
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
// get the timestamp of a specific slot in the round robin database
|
|
// only valid when not using dbengine
|
|
static inline time_t rrddim_slot2time(RRDDIM *rd, size_t slot) {
|
|
time_t ret;
|
|
time_t last_entry_t = rrddim_query_latest_time((STORAGE_METRIC_HANDLE *)rd);
|
|
time_t first_entry_t = rrddim_query_oldest_time((STORAGE_METRIC_HANDLE *)rd);
|
|
size_t entries = rd->rrdset->entries;
|
|
size_t last_slot = rrddim_last_slot(rd);
|
|
size_t update_every = rd->rrdset->update_every;
|
|
|
|
if(slot >= entries) {
|
|
error("INTERNAL ERROR: caller of rrddim_slot2time() gives invalid slot %zu", slot);
|
|
slot = entries - 1;
|
|
}
|
|
|
|
if(slot > last_slot)
|
|
ret = last_entry_t - (time_t)(update_every * (last_slot - slot + entries));
|
|
else
|
|
ret = last_entry_t - (time_t)(update_every * (last_slot - slot));
|
|
|
|
if(unlikely(ret < first_entry_t)) {
|
|
error("INTERNAL ERROR: rrddim_slot2time() on %s returns time too far in the past", rrddim_name(rd));
|
|
ret = first_entry_t;
|
|
}
|
|
|
|
if(unlikely(ret > last_entry_t)) {
|
|
error("INTERNAL ERROR: rrddim_slot2time() on %s returns time into the future", rrddim_name(rd));
|
|
ret = last_entry_t;
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
// ----------------------------------------------------------------------------
|
|
// RRDDIM legacy database query functions
|
|
|
|
void rrddim_query_init(STORAGE_METRIC_HANDLE *db_metric_handle, struct rrddim_query_handle *handle, time_t start_time, time_t end_time, TIER_QUERY_FETCH tier_query_fetch_type) {
|
|
UNUSED(tier_query_fetch_type);
|
|
|
|
RRDDIM *rd = (RRDDIM *)db_metric_handle;
|
|
|
|
handle->rd = rd;
|
|
handle->start_time = start_time;
|
|
handle->end_time = end_time;
|
|
struct mem_query_handle* h = calloc(1, sizeof(struct mem_query_handle));
|
|
h->slot = rrddim_time2slot(rd, start_time);
|
|
h->last_slot = rrddim_time2slot(rd, end_time);
|
|
h->dt = rd->rrdset->update_every;
|
|
|
|
h->next_timestamp = start_time;
|
|
h->slot_timestamp = rrddim_slot2time(rd, h->slot);
|
|
h->last_timestamp = rrddim_slot2time(rd, h->last_slot);
|
|
|
|
// info("RRDDIM QUERY INIT: start %ld, end %ld, next %ld, first %ld, last %ld, dt %ld", start_time, end_time, h->next_timestamp, h->slot_timestamp, h->last_timestamp, h->dt);
|
|
|
|
handle->handle = (STORAGE_QUERY_HANDLE *)h;
|
|
}
|
|
|
|
// Returns the metric and sets its timestamp into current_time
|
|
// IT IS REQUIRED TO **ALWAYS** SET ALL RETURN VALUES (current_time, end_time, flags)
|
|
// IT IS REQUIRED TO **ALWAYS** KEEP TRACK OF TIME, EVEN OUTSIDE THE DATABASE BOUNDARIES
|
|
STORAGE_POINT rrddim_query_next_metric(struct rrddim_query_handle *handle) {
|
|
RRDDIM *rd = handle->rd;
|
|
struct mem_query_handle* h = (struct mem_query_handle*)handle->handle;
|
|
size_t entries = rd->rrdset->entries;
|
|
size_t slot = h->slot;
|
|
|
|
STORAGE_POINT sp;
|
|
sp.count = 1;
|
|
|
|
time_t this_timestamp = h->next_timestamp;
|
|
h->next_timestamp += h->dt;
|
|
|
|
// set this timestamp for our caller
|
|
sp.start_time = this_timestamp - h->dt;
|
|
sp.end_time = this_timestamp;
|
|
|
|
if(unlikely(this_timestamp < h->slot_timestamp)) {
|
|
storage_point_empty(sp, sp.start_time, sp.end_time);
|
|
return sp;
|
|
}
|
|
|
|
if(unlikely(this_timestamp > h->last_timestamp)) {
|
|
storage_point_empty(sp, sp.start_time, sp.end_time);
|
|
return sp;
|
|
}
|
|
|
|
storage_number n = rd->db[slot++];
|
|
if(unlikely(slot >= entries)) slot = 0;
|
|
|
|
h->slot = slot;
|
|
h->slot_timestamp += h->dt;
|
|
|
|
sp.anomaly_count = is_storage_number_anomalous(n) ? 1 : 0;
|
|
sp.flags = (n & SN_USER_FLAGS);
|
|
sp.min = sp.max = sp.sum = unpack_storage_number(n);
|
|
|
|
return sp;
|
|
}
|
|
|
|
int rrddim_query_is_finished(struct rrddim_query_handle *handle) {
|
|
struct mem_query_handle* h = (struct mem_query_handle*)handle->handle;
|
|
return (h->next_timestamp > handle->end_time);
|
|
}
|
|
|
|
void rrddim_query_finalize(struct rrddim_query_handle *handle) {
|
|
#ifdef NETDATA_INTERNAL_CHECKS
|
|
if(!rrddim_query_is_finished(handle))
|
|
error("QUERY: query for chart '%s' dimension '%s' has been stopped unfinished", rrdset_id(handle->rd->rrdset), rrddim_name(handle->rd));
|
|
#endif
|
|
freez(handle->handle);
|
|
}
|
|
|
|
time_t rrddim_query_latest_time(STORAGE_METRIC_HANDLE *db_metric_handle) {
|
|
RRDDIM *rd = (RRDDIM *)db_metric_handle;
|
|
return rd->rrdset->last_updated.tv_sec;
|
|
}
|
|
|
|
time_t rrddim_query_oldest_time(STORAGE_METRIC_HANDLE *db_metric_handle) {
|
|
RRDDIM *rd = (RRDDIM *)db_metric_handle;
|
|
return (time_t)(rd->rrdset->last_updated.tv_sec - rrddim_duration(rd));
|
|
}
|