mirror of
https://github.com/netdata/netdata.git
synced 2025-04-06 06:25:32 +00:00

* rrdset - in progress * rrdset optimal constructor; rrdset conflict * rrdset final touches * re-organization of rrdset object members * prevent use-after-free * dictionary dfe supports also counting of iterations * rrddim managed by dictionary * rrd.h cleanup * DICTIONARY_ITEM now is referencing actual dictionary items in the code * removed rrdset linked list * Revert "removed rrdset linked list" This reverts commit 690d6a588b4b99619c2c5e10f84e8f868ae6def5. * removed rrdset linked list * added comments * Switch chart uuid to static allocation in rrdset Remove unused functions * rrdset_archive() and friends... * always create rrdfamily * enable ml_free_dimension * rrddim_foreach done with dfe * most custom rrddim loops replaced with rrddim_foreach * removed accesses to rrddim->dimensions * removed locks that are no longer needed * rrdsetvar is now managed by the dictionary * set rrdset is rrdsetvar, fixes https://github.com/netdata/netdata/pull/13646#issuecomment-1242574853 * conflict callback of rrdsetvar now properly checks if it has to reset the variable * dictionary registered callbacks accept as first parameter the DICTIONARY_ITEM * dictionary dfe now uses internal counter to report; avoided excess variables defined with dfe * dictionary walkthrough callbacks get dictionary acquired items * dictionary reference counters that can be dupped from zero * added advanced functions for get and del * rrdvar managed by dictionaries * thread safety for rrdsetvar * faster rrdvar initialization * rrdvar string lengths should match in all add, del, get functions * rrdvar internals hidden from the rest of the world * rrdvar is now acquired throughout netdata * hide the internal structures of rrdsetvar * rrdsetvar is now acquired through out netdata * rrddimvar managed by dictionary; rrddimvar linked list removed; rrddimvar structures hidden from the rest of netdata * better error handling * dont create variables if not initialized for health * dont create variables if not initialized for health again * rrdfamily is now managed by dictionaries; references of it are acquired dictionary items * type checking on acquired objects * rrdcalc renaming of functions * type checking for rrdfamily_acquired * rrdcalc managed by dictionaries * rrdcalc double free fix * host rrdvars is always needed * attempt to fix deadlock 1 * attempt to fix deadlock 2 * Remove unused variable * attempt to fix deadlock 3 * snprintfz * rrdcalc index in rrdset fix * Stop storing active charts and computing chart hashes * Remove store active chart function * Remove compute chart hash function * Remove sql_store_chart_hash function * Remove store_active_dimension function * dictionary delayed destruction * formatting and cleanup * zero dictionary base on rrdsetvar * added internal error to log delayed destructions of dictionaries * typo in rrddimvar * added debugging info to dictionary * debug info * fix for rrdcalc keys being empty * remove forgotten unlock * remove deadlock * Switch to metadata version 5 and drop chart_hash chart_hash_map chart_active dimension_active v_chart_hash * SQL cosmetic changes * do not busy wait while destroying a referenced dictionary * remove deadlock * code cleanup; re-organization; * fast cleanup and flushing of dictionaries * number formatting fixes * do not delete configured alerts when archiving a chart * rrddim obsolete linked list management outside dictionaries * removed duplicate contexts call * fix crash when rrdfamily is not initialized * dont keep rrddimvar referenced * properly cleanup rrdvar * removed some locks * Do not attempt to cleanup chart_hash / chart_hash_map * rrdcalctemplate managed by dictionary * register callbacks on the right dictionary * removed some more locks * rrdcalc secondary index replaced with linked-list; rrdcalc labels updates are now executed by health thread * when looking up for an alarm look using both chart id and chart name * host initialization a bit more modular * init rrdlabels on host update * preparation for dictionary views * improved comment * unused variables without internal checks * service threads isolation and worker info * more worker info in service thread * thread cancelability debugging with internal checks * strings data races addressed; fixes https://github.com/netdata/netdata/issues/13647 * dictionary modularization * Remove unused SQL statement definition * unit-tested thread safety of dictionaries; removed data race conditions on dictionaries and strings; dictionaries now can detect if the caller is holds a write lock and automatically all the calls become their unsafe versions; all direct calls to unsafe version is eliminated * remove worker_is_idle() from the exit of service functions, because we lose the lock time between loops * rewritten dictionary to have 2 separate locks, one for indexing and another for traversal * Update collectors/cgroups.plugin/sys_fs_cgroup.c Co-authored-by: Vladimir Kobal <vlad@prokk.net> * Update collectors/cgroups.plugin/sys_fs_cgroup.c Co-authored-by: Vladimir Kobal <vlad@prokk.net> * Update collectors/proc.plugin/proc_net_dev.c Co-authored-by: Vladimir Kobal <vlad@prokk.net> * fix memory leak in rrdset cache_dir * minor dictionary changes * dont use index locks in single threaded * obsolete dict option * rrddim options and flags separation; rrdset_done() optimization to keep array of reference pointers to rrddim; * fix jump on uninitialized value in dictionary; remove double free of cache_dir * addressed codacy findings * removed debugging code * use the private refcount on dictionaries * make dictionary item desctructors work on dictionary destruction; strictier control on dictionary API; proper cleanup sequence on rrddim; * more dictionary statistics * global statistics about dictionary operations, memory, items, callbacks * dictionary support for views - missing the public API * removed warning about unused parameter * chart and context name for cloud * chart and context name for cloud, again * dictionary statistics fixed; first implementation of dictionary views - not currently used * only the master can globally delete an item * context needs netdata prefix * fix context and chart it of spins * fix for host variables when health is not enabled * run garbage collector on item insert too * Fix info message; remove extra "using" * update dict unittest for new placement of garbage collector * we need RRDHOST->rrdvars for maintaining custom host variables * Health initialization needs the host->host_uuid * split STRING to its own files; no code changes other than that * initialize health unconditionally * unit tests do not pollute the global scope with their variables * Skip initialization when creating archived hosts on startup. When a child connects it will initialize properly Co-authored-by: Stelios Fragkakis <52996999+stelfrag@users.noreply.github.com> Co-authored-by: Vladimir Kobal <vlad@prokk.net>
272 lines
10 KiB
C
272 lines
10 KiB
C
// SPDX-License-Identifier: GPL-3.0-or-later
|
|
|
|
#include "rrd.h"
|
|
|
|
typedef struct rrddimvar {
|
|
struct rrddim *rrddim;
|
|
|
|
STRING *prefix;
|
|
STRING *suffix;
|
|
void *value;
|
|
|
|
const RRDVAR_ACQUIRED *rrdvar_local_dim_id;
|
|
const RRDVAR_ACQUIRED *rrdvar_local_dim_name;
|
|
|
|
const RRDVAR_ACQUIRED *rrdvar_family_id;
|
|
const RRDVAR_ACQUIRED *rrdvar_family_name;
|
|
const RRDVAR_ACQUIRED *rrdvar_family_context_dim_id;
|
|
const RRDVAR_ACQUIRED *rrdvar_family_context_dim_name;
|
|
|
|
const RRDVAR_ACQUIRED *rrdvar_host_chart_id_dim_id;
|
|
const RRDVAR_ACQUIRED *rrdvar_host_chart_id_dim_name;
|
|
const RRDVAR_ACQUIRED *rrdvar_host_chart_name_dim_id;
|
|
const RRDVAR_ACQUIRED *rrdvar_host_chart_name_dim_name;
|
|
|
|
RRDVAR_FLAGS flags:24;
|
|
RRDVAR_TYPE type:8;
|
|
} RRDDIMVAR;
|
|
|
|
// ----------------------------------------------------------------------------
|
|
// RRDDIMVAR management
|
|
// DIMENSION VARIABLES
|
|
|
|
#define RRDDIMVAR_ID_MAX 1024
|
|
|
|
static inline void rrddimvar_free_variables_unsafe(RRDDIMVAR *rs) {
|
|
RRDDIM *rd = rs->rrddim;
|
|
RRDSET *st = rd->rrdset;
|
|
RRDHOST *host = st->rrdhost;
|
|
|
|
// CHART VARIABLES FOR THIS DIMENSION
|
|
|
|
if(st->rrdvars) {
|
|
rrdvar_release_and_del(st->rrdvars, rs->rrdvar_local_dim_id);
|
|
rs->rrdvar_local_dim_id = NULL;
|
|
|
|
rrdvar_release_and_del(st->rrdvars, rs->rrdvar_local_dim_name);
|
|
rs->rrdvar_local_dim_name = NULL;
|
|
}
|
|
|
|
// FAMILY VARIABLES FOR THIS DIMENSION
|
|
|
|
if(st->rrdfamily) {
|
|
rrdvar_release_and_del(rrdfamily_rrdvars_dict(st->rrdfamily), rs->rrdvar_family_id);
|
|
rs->rrdvar_family_id = NULL;
|
|
|
|
rrdvar_release_and_del(rrdfamily_rrdvars_dict(st->rrdfamily), rs->rrdvar_family_name);
|
|
rs->rrdvar_family_name = NULL;
|
|
|
|
rrdvar_release_and_del(rrdfamily_rrdvars_dict(st->rrdfamily), rs->rrdvar_family_context_dim_id);
|
|
rs->rrdvar_family_context_dim_id = NULL;
|
|
|
|
rrdvar_release_and_del(rrdfamily_rrdvars_dict(st->rrdfamily), rs->rrdvar_family_context_dim_name);
|
|
rs->rrdvar_family_context_dim_name = NULL;
|
|
}
|
|
|
|
// HOST VARIABLES FOR THIS DIMENSION
|
|
|
|
if(host->rrdvars && host->health_enabled) {
|
|
rrdvar_release_and_del(host->rrdvars, rs->rrdvar_host_chart_id_dim_id);
|
|
rs->rrdvar_host_chart_id_dim_id = NULL;
|
|
|
|
rrdvar_release_and_del(host->rrdvars, rs->rrdvar_host_chart_id_dim_name);
|
|
rs->rrdvar_host_chart_id_dim_name = NULL;
|
|
|
|
rrdvar_release_and_del(host->rrdvars, rs->rrdvar_host_chart_name_dim_id);
|
|
rs->rrdvar_host_chart_name_dim_id = NULL;
|
|
|
|
rrdvar_release_and_del(host->rrdvars, rs->rrdvar_host_chart_name_dim_name);
|
|
rs->rrdvar_host_chart_name_dim_name = NULL;
|
|
}
|
|
}
|
|
|
|
static inline void rrddimvar_update_variables_unsafe(RRDDIMVAR *rs) {
|
|
rrddimvar_free_variables_unsafe(rs);
|
|
|
|
RRDDIM *rd = rs->rrddim;
|
|
RRDSET *st = rd->rrdset;
|
|
RRDHOST *host = st->rrdhost;
|
|
|
|
char buffer[RRDDIMVAR_ID_MAX + 1];
|
|
|
|
// KEYS
|
|
|
|
snprintfz(buffer, RRDDIMVAR_ID_MAX, "%s%s%s", string2str(rs->prefix), rrddim_id(rd), string2str(rs->suffix));
|
|
STRING *key_dim_id = string_strdupz(buffer);
|
|
|
|
snprintfz(buffer, RRDDIMVAR_ID_MAX, "%s%s%s", string2str(rs->prefix), rrddim_name(rd), string2str(rs->suffix));
|
|
STRING *key_dim_name = string_strdupz(buffer);
|
|
|
|
snprintfz(buffer, RRDDIMVAR_ID_MAX, "%s.%s", rrdset_id(st), string2str(key_dim_id));
|
|
STRING *key_chart_id_dim_id = string_strdupz(buffer);
|
|
|
|
snprintfz(buffer, RRDDIMVAR_ID_MAX, "%s.%s", rrdset_id(st), string2str(key_dim_name));
|
|
STRING *key_chart_id_dim_name = string_strdupz(buffer);
|
|
|
|
snprintfz(buffer, RRDDIMVAR_ID_MAX, "%s.%s", rrdset_context(st), string2str(key_dim_id));
|
|
STRING *key_context_dim_id = string_strdupz(buffer);
|
|
|
|
snprintfz(buffer, RRDDIMVAR_ID_MAX, "%s.%s", rrdset_context(st), string2str(key_dim_name));
|
|
STRING *key_context_dim_name = string_strdupz(buffer);
|
|
|
|
snprintfz(buffer, RRDDIMVAR_ID_MAX, "%s.%s", rrdset_name(st), string2str(key_dim_id));
|
|
STRING *key_chart_name_dim_id = string_strdupz(buffer);
|
|
|
|
snprintfz(buffer, RRDDIMVAR_ID_MAX, "%s.%s", rrdset_name(st), string2str(key_dim_name));
|
|
STRING *key_chart_name_dim_name = string_strdupz(buffer);
|
|
|
|
// CHART VARIABLES FOR THIS DIMENSION
|
|
// -----------------------------------
|
|
//
|
|
// dimensions are available as:
|
|
// - $id
|
|
// - $name
|
|
|
|
if(st->rrdvars) {
|
|
rs->rrdvar_local_dim_id = rrdvar_add_and_acquire("local", st->rrdvars, key_dim_id, rs->type, RRDVAR_FLAG_NONE, rs->value);
|
|
rs->rrdvar_local_dim_name = rrdvar_add_and_acquire("local", st->rrdvars, key_dim_name, rs->type, RRDVAR_FLAG_NONE, rs->value);
|
|
}
|
|
|
|
// FAMILY VARIABLES FOR THIS DIMENSION
|
|
// -----------------------------------
|
|
//
|
|
// dimensions are available as:
|
|
// - $id (only the first, when multiple overlap)
|
|
// - $name (only the first, when multiple overlap)
|
|
// - $chart-context.id
|
|
// - $chart-context.name
|
|
|
|
if(st->rrdfamily) {
|
|
rs->rrdvar_family_id = rrdvar_add_and_acquire("family", rrdfamily_rrdvars_dict(st->rrdfamily), key_dim_id, rs->type, RRDVAR_FLAG_NONE, rs->value);
|
|
rs->rrdvar_family_name = rrdvar_add_and_acquire("family", rrdfamily_rrdvars_dict(st->rrdfamily), key_dim_name, rs->type, RRDVAR_FLAG_NONE, rs->value);
|
|
rs->rrdvar_family_context_dim_id = rrdvar_add_and_acquire("family", rrdfamily_rrdvars_dict(st->rrdfamily), key_context_dim_id, rs->type, RRDVAR_FLAG_NONE, rs->value);
|
|
rs->rrdvar_family_context_dim_name = rrdvar_add_and_acquire("family", rrdfamily_rrdvars_dict(st->rrdfamily), key_context_dim_name, rs->type, RRDVAR_FLAG_NONE, rs->value);
|
|
}
|
|
|
|
// HOST VARIABLES FOR THIS DIMENSION
|
|
// -----------------------------------
|
|
//
|
|
// dimensions are available as:
|
|
// - $chart-id.id
|
|
// - $chart-id.name
|
|
// - $chart-name.id
|
|
// - $chart-name.name
|
|
|
|
if(host->rrdvars && host->health_enabled) {
|
|
rs->rrdvar_host_chart_id_dim_id = rrdvar_add_and_acquire("host", host->rrdvars, key_chart_id_dim_id, rs->type, RRDVAR_FLAG_NONE, rs->value);
|
|
rs->rrdvar_host_chart_id_dim_name = rrdvar_add_and_acquire("host", host->rrdvars, key_chart_id_dim_name, rs->type, RRDVAR_FLAG_NONE, rs->value);
|
|
rs->rrdvar_host_chart_name_dim_id = rrdvar_add_and_acquire("host", host->rrdvars, key_chart_name_dim_id, rs->type, RRDVAR_FLAG_NONE, rs->value);
|
|
rs->rrdvar_host_chart_name_dim_name = rrdvar_add_and_acquire("host", host->rrdvars, key_chart_name_dim_name, rs->type, RRDVAR_FLAG_NONE, rs->value);
|
|
}
|
|
|
|
// free the keys
|
|
|
|
string_freez(key_dim_id);
|
|
string_freez(key_dim_name);
|
|
string_freez(key_chart_id_dim_id);
|
|
string_freez(key_chart_id_dim_name);
|
|
string_freez(key_context_dim_id);
|
|
string_freez(key_context_dim_name);
|
|
string_freez(key_chart_name_dim_id);
|
|
string_freez(key_chart_name_dim_name);
|
|
}
|
|
|
|
struct rrddimvar_constructor {
|
|
RRDDIM *rrddim;
|
|
const char *prefix;
|
|
const char *suffix;
|
|
void *value;
|
|
RRDVAR_FLAGS flags :16;
|
|
RRDVAR_TYPE type:8;
|
|
};
|
|
|
|
static void rrddimvar_insert_callback(const DICTIONARY_ITEM *item __maybe_unused, void *rrddimvar, void *constructor_data) {
|
|
RRDDIMVAR *rs = rrddimvar;
|
|
struct rrddimvar_constructor *ctr = constructor_data;
|
|
|
|
if(!ctr->prefix) ctr->prefix = "";
|
|
if(!ctr->suffix) ctr->suffix = "";
|
|
|
|
rs->prefix = string_strdupz(ctr->prefix);
|
|
rs->suffix = string_strdupz(ctr->suffix);
|
|
|
|
rs->type = ctr->type;
|
|
rs->value = ctr->value;
|
|
rs->flags = ctr->flags;
|
|
rs->rrddim = ctr->rrddim;
|
|
|
|
rrddimvar_update_variables_unsafe(rs);
|
|
}
|
|
|
|
static bool rrddimvar_conflict_callback(const DICTIONARY_ITEM *item __maybe_unused, void *rrddimvar, void *new_rrddimvar __maybe_unused, void *constructor_data __maybe_unused) {
|
|
RRDDIMVAR *rs = rrddimvar;
|
|
rrddimvar_update_variables_unsafe(rs);
|
|
|
|
return true;
|
|
}
|
|
|
|
static void rrddimvar_delete_callback(const DICTIONARY_ITEM *item __maybe_unused, void *rrddimvar, void *rrdset __maybe_unused) {
|
|
RRDDIMVAR *rs = rrddimvar;
|
|
rrddimvar_free_variables_unsafe(rs);
|
|
string_freez(rs->prefix);
|
|
string_freez(rs->suffix);
|
|
}
|
|
|
|
void rrddimvar_index_init(RRDSET *st) {
|
|
if(!st->rrddimvar_root_index) {
|
|
st->rrddimvar_root_index = dictionary_create(DICT_OPTION_DONT_OVERWRITE_VALUE);
|
|
|
|
dictionary_register_insert_callback(st->rrddimvar_root_index, rrddimvar_insert_callback, NULL);
|
|
dictionary_register_conflict_callback(st->rrddimvar_root_index, rrddimvar_conflict_callback, NULL);
|
|
dictionary_register_delete_callback(st->rrddimvar_root_index, rrddimvar_delete_callback, st);
|
|
}
|
|
}
|
|
|
|
void rrddimvar_index_destroy(RRDSET *st) {
|
|
dictionary_destroy(st->rrddimvar_root_index);
|
|
st->rrddimvar_root_index = NULL;
|
|
}
|
|
|
|
void rrddimvar_add_and_leave_released(RRDDIM *rd, RRDVAR_TYPE type, const char *prefix, const char *suffix, void *value, RRDVAR_FLAGS flags) {
|
|
if(!prefix) prefix = "";
|
|
if(!suffix) suffix = "";
|
|
|
|
char key[RRDDIMVAR_ID_MAX + 1];
|
|
size_t key_len = snprintfz(key, RRDDIMVAR_ID_MAX, "%s_%s_%s", prefix, rrddim_id(rd), suffix);
|
|
|
|
struct rrddimvar_constructor tmp = {
|
|
.suffix = suffix,
|
|
.prefix = prefix,
|
|
.type = type,
|
|
.flags = flags,
|
|
.value = value,
|
|
.rrddim = rd
|
|
};
|
|
dictionary_set_advanced(rd->rrdset->rrddimvar_root_index, key, (ssize_t)(key_len + 1), NULL, sizeof(RRDDIMVAR), &tmp);
|
|
}
|
|
|
|
void rrddimvar_rename_all(RRDDIM *rd) {
|
|
RRDSET *st = rd->rrdset;
|
|
|
|
debug(D_VARIABLES, "RRDDIMVAR rename for chart id '%s' name '%s', dimension id '%s', name '%s'", rrdset_id(st), rrdset_name(st), rrddim_id(rd), rrddim_name(rd));
|
|
|
|
RRDDIMVAR *rs;
|
|
dfe_start_write(st->rrddimvar_root_index, rs) {
|
|
if(unlikely(rs->rrddim == rd))
|
|
rrddimvar_update_variables_unsafe(rs);
|
|
}
|
|
dfe_done(rs);
|
|
}
|
|
|
|
void rrddimvar_delete_all(RRDDIM *rd) {
|
|
RRDSET *st = rd->rrdset;
|
|
|
|
debug(D_VARIABLES, "RRDDIMVAR delete for chart id '%s' name '%s', dimension id '%s', name '%s'", rrdset_id(st), rrdset_name(st), rrddim_id(rd), rrddim_name(rd));
|
|
|
|
RRDDIMVAR *rs;
|
|
dfe_start_write(st->rrddimvar_root_index, rs) {
|
|
if(unlikely(rs->rrddim == rd))
|
|
dictionary_del(st->rrddimvar_root_index, rs_dfe.name);
|
|
}
|
|
dfe_done(rs);
|
|
}
|