mirror of
https://github.com/netdata/netdata.git
synced 2025-04-05 22:15:32 +00:00

* rrdset - in progress * rrdset optimal constructor; rrdset conflict * rrdset final touches * re-organization of rrdset object members * prevent use-after-free * dictionary dfe supports also counting of iterations * rrddim managed by dictionary * rrd.h cleanup * DICTIONARY_ITEM now is referencing actual dictionary items in the code * removed rrdset linked list * Revert "removed rrdset linked list" This reverts commit 690d6a588b4b99619c2c5e10f84e8f868ae6def5. * removed rrdset linked list * added comments * Switch chart uuid to static allocation in rrdset Remove unused functions * rrdset_archive() and friends... * always create rrdfamily * enable ml_free_dimension * rrddim_foreach done with dfe * most custom rrddim loops replaced with rrddim_foreach * removed accesses to rrddim->dimensions * removed locks that are no longer needed * rrdsetvar is now managed by the dictionary * set rrdset is rrdsetvar, fixes https://github.com/netdata/netdata/pull/13646#issuecomment-1242574853 * conflict callback of rrdsetvar now properly checks if it has to reset the variable * dictionary registered callbacks accept as first parameter the DICTIONARY_ITEM * dictionary dfe now uses internal counter to report; avoided excess variables defined with dfe * dictionary walkthrough callbacks get dictionary acquired items * dictionary reference counters that can be dupped from zero * added advanced functions for get and del * rrdvar managed by dictionaries * thread safety for rrdsetvar * faster rrdvar initialization * rrdvar string lengths should match in all add, del, get functions * rrdvar internals hidden from the rest of the world * rrdvar is now acquired throughout netdata * hide the internal structures of rrdsetvar * rrdsetvar is now acquired through out netdata * rrddimvar managed by dictionary; rrddimvar linked list removed; rrddimvar structures hidden from the rest of netdata * better error handling * dont create variables if not initialized for health * dont create variables if not initialized for health again * rrdfamily is now managed by dictionaries; references of it are acquired dictionary items * type checking on acquired objects * rrdcalc renaming of functions * type checking for rrdfamily_acquired * rrdcalc managed by dictionaries * rrdcalc double free fix * host rrdvars is always needed * attempt to fix deadlock 1 * attempt to fix deadlock 2 * Remove unused variable * attempt to fix deadlock 3 * snprintfz * rrdcalc index in rrdset fix * Stop storing active charts and computing chart hashes * Remove store active chart function * Remove compute chart hash function * Remove sql_store_chart_hash function * Remove store_active_dimension function * dictionary delayed destruction * formatting and cleanup * zero dictionary base on rrdsetvar * added internal error to log delayed destructions of dictionaries * typo in rrddimvar * added debugging info to dictionary * debug info * fix for rrdcalc keys being empty * remove forgotten unlock * remove deadlock * Switch to metadata version 5 and drop chart_hash chart_hash_map chart_active dimension_active v_chart_hash * SQL cosmetic changes * do not busy wait while destroying a referenced dictionary * remove deadlock * code cleanup; re-organization; * fast cleanup and flushing of dictionaries * number formatting fixes * do not delete configured alerts when archiving a chart * rrddim obsolete linked list management outside dictionaries * removed duplicate contexts call * fix crash when rrdfamily is not initialized * dont keep rrddimvar referenced * properly cleanup rrdvar * removed some locks * Do not attempt to cleanup chart_hash / chart_hash_map * rrdcalctemplate managed by dictionary * register callbacks on the right dictionary * removed some more locks * rrdcalc secondary index replaced with linked-list; rrdcalc labels updates are now executed by health thread * when looking up for an alarm look using both chart id and chart name * host initialization a bit more modular * init rrdlabels on host update * preparation for dictionary views * improved comment * unused variables without internal checks * service threads isolation and worker info * more worker info in service thread * thread cancelability debugging with internal checks * strings data races addressed; fixes https://github.com/netdata/netdata/issues/13647 * dictionary modularization * Remove unused SQL statement definition * unit-tested thread safety of dictionaries; removed data race conditions on dictionaries and strings; dictionaries now can detect if the caller is holds a write lock and automatically all the calls become their unsafe versions; all direct calls to unsafe version is eliminated * remove worker_is_idle() from the exit of service functions, because we lose the lock time between loops * rewritten dictionary to have 2 separate locks, one for indexing and another for traversal * Update collectors/cgroups.plugin/sys_fs_cgroup.c Co-authored-by: Vladimir Kobal <vlad@prokk.net> * Update collectors/cgroups.plugin/sys_fs_cgroup.c Co-authored-by: Vladimir Kobal <vlad@prokk.net> * Update collectors/proc.plugin/proc_net_dev.c Co-authored-by: Vladimir Kobal <vlad@prokk.net> * fix memory leak in rrdset cache_dir * minor dictionary changes * dont use index locks in single threaded * obsolete dict option * rrddim options and flags separation; rrdset_done() optimization to keep array of reference pointers to rrddim; * fix jump on uninitialized value in dictionary; remove double free of cache_dir * addressed codacy findings * removed debugging code * use the private refcount on dictionaries * make dictionary item desctructors work on dictionary destruction; strictier control on dictionary API; proper cleanup sequence on rrddim; * more dictionary statistics * global statistics about dictionary operations, memory, items, callbacks * dictionary support for views - missing the public API * removed warning about unused parameter * chart and context name for cloud * chart and context name for cloud, again * dictionary statistics fixed; first implementation of dictionary views - not currently used * only the master can globally delete an item * context needs netdata prefix * fix context and chart it of spins * fix for host variables when health is not enabled * run garbage collector on item insert too * Fix info message; remove extra "using" * update dict unittest for new placement of garbage collector * we need RRDHOST->rrdvars for maintaining custom host variables * Health initialization needs the host->host_uuid * split STRING to its own files; no code changes other than that * initialize health unconditionally * unit tests do not pollute the global scope with their variables * Skip initialization when creating archived hosts on startup. When a child connects it will initialize properly Co-authored-by: Stelios Fragkakis <52996999+stelfrag@users.noreply.github.com> Co-authored-by: Vladimir Kobal <vlad@prokk.net>
203 lines
6.3 KiB
C
203 lines
6.3 KiB
C
// SPDX-License-Identifier: GPL-3.0-or-later
|
|
|
|
#include "sqlite_db_migration.h"
|
|
|
|
static int return_int_cb(void *data, int argc, char **argv, char **column)
|
|
{
|
|
int *status = data;
|
|
UNUSED(argc);
|
|
UNUSED(column);
|
|
*status = str2uint32_t(argv[0]);
|
|
return 0;
|
|
}
|
|
|
|
|
|
static int table_exists_in_database(const char *table)
|
|
{
|
|
char *err_msg = NULL;
|
|
char sql[128];
|
|
|
|
int exists = 0;
|
|
|
|
snprintf(sql, 127, "select 1 from sqlite_schema where type = 'table' and name = '%s';", table);
|
|
|
|
int rc = sqlite3_exec_monitored(db_meta, sql, return_int_cb, (void *) &exists, &err_msg);
|
|
if (rc != SQLITE_OK) {
|
|
info("Error checking table existence; %s", err_msg);
|
|
sqlite3_free(err_msg);
|
|
}
|
|
|
|
return exists;
|
|
}
|
|
|
|
static int column_exists_in_table(const char *table, const char *column)
|
|
{
|
|
char *err_msg = NULL;
|
|
char sql[128];
|
|
|
|
int exists = 0;
|
|
|
|
snprintf(sql, 127, "SELECT 1 FROM pragma_table_info('%s') where name = '%s';", table, column);
|
|
|
|
int rc = sqlite3_exec_monitored(db_meta, sql, return_int_cb, (void *) &exists, &err_msg);
|
|
if (rc != SQLITE_OK) {
|
|
info("Error checking column existence; %s", err_msg);
|
|
sqlite3_free(err_msg);
|
|
}
|
|
|
|
return exists;
|
|
}
|
|
|
|
const char *database_migrate_v1_v2[] = {
|
|
"ALTER TABLE host ADD hops INTEGER;",
|
|
NULL
|
|
};
|
|
|
|
const char *database_migrate_v2_v3[] = {
|
|
"ALTER TABLE host ADD memory_mode INT NOT NULL DEFAULT 0;",
|
|
"ALTER TABLE host ADD abbrev_timezone TEXT NOT NULL DEFAULT '';",
|
|
"ALTER TABLE host ADD utc_offset INT NOT NULL DEFAULT 0;",
|
|
"ALTER TABLE host ADD program_name TEXT NOT NULL DEFAULT 'unknown';",
|
|
"ALTER TABLE host ADD program_version TEXT NOT NULL DEFAULT 'unknown';",
|
|
"ALTER TABLE host ADD entries INT NOT NULL DEFAULT 0;",
|
|
"ALTER TABLE host ADD health_enabled INT NOT NULL DEFAULT 0;",
|
|
NULL
|
|
};
|
|
|
|
const char *database_migrate_v4_v5[] = {
|
|
"DROP TABLE IF EXISTS chart_active;",
|
|
"DROP TABLE IF EXISTS dimension_active;",
|
|
"DROP TABLE IF EXISTS chart_hash;",
|
|
"DROP TABLE IF EXISTS chart_hash_map;",
|
|
"DROP VIEW IF EXISTS v_chart_hash;",
|
|
NULL
|
|
};
|
|
|
|
static int do_migration_v1_v2(sqlite3 *database, const char *name)
|
|
{
|
|
UNUSED(name);
|
|
info("Running \"%s\" database migration", name);
|
|
|
|
if (table_exists_in_database("host") && !column_exists_in_table("host", "hops"))
|
|
return init_database_batch(database, DB_CHECK_NONE, 0, &database_migrate_v1_v2[0]);
|
|
return 0;
|
|
}
|
|
|
|
static int do_migration_v2_v3(sqlite3 *database, const char *name)
|
|
{
|
|
UNUSED(name);
|
|
info("Running \"%s\" database migration", name);
|
|
|
|
if (table_exists_in_database("host") && !column_exists_in_table("host", "memory_mode"))
|
|
return init_database_batch(database, DB_CHECK_NONE, 0, &database_migrate_v2_v3[0]);
|
|
return 0;
|
|
}
|
|
|
|
static int do_migration_v3_v4(sqlite3 *database, const char *name)
|
|
{
|
|
UNUSED(name);
|
|
info("Running database migration %s", name);
|
|
|
|
char sql[256];
|
|
|
|
int rc;
|
|
sqlite3_stmt *res = NULL;
|
|
snprintfz(sql, 255, "SELECT name FROM sqlite_schema WHERE type ='table' AND name LIKE 'health_log_%%';");
|
|
rc = sqlite3_prepare_v2(database, sql, -1, &res, 0);
|
|
if (rc != SQLITE_OK) {
|
|
error_report("Failed to prepare statement to alter health_log tables");
|
|
return 1;
|
|
}
|
|
|
|
while (sqlite3_step_monitored(res) == SQLITE_ROW) {
|
|
char *table = strdupz((char *) sqlite3_column_text(res, 0));
|
|
if (!column_exists_in_table(table, "chart_context")) {
|
|
snprintfz(sql, 255, "ALTER TABLE %s ADD chart_context text", table);
|
|
sqlite3_exec_monitored(database, sql, 0, 0, NULL);
|
|
}
|
|
freez(table);
|
|
}
|
|
|
|
rc = sqlite3_finalize(res);
|
|
if (unlikely(rc != SQLITE_OK))
|
|
error_report("Failed to finalize statement when altering health_log tables, rc = %d", rc);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int do_migration_v4_v5(sqlite3 *database, const char *name)
|
|
{
|
|
UNUSED(name);
|
|
info("Running \"%s\" database migration", name);
|
|
|
|
return init_database_batch(database, DB_CHECK_NONE, 0, &database_migrate_v4_v5[0]);
|
|
}
|
|
|
|
static int do_migration_noop(sqlite3 *database, const char *name)
|
|
{
|
|
UNUSED(database);
|
|
UNUSED(name);
|
|
info("Running database migration %s", name);
|
|
return 0;
|
|
}
|
|
|
|
typedef struct database_func_migration_list {
|
|
char *name;
|
|
int (*func)(sqlite3 *database, const char *name);
|
|
} DATABASE_FUNC_MIGRATION_LIST;
|
|
|
|
|
|
static int migrate_database(sqlite3 *database, int target_version, char *db_name, DATABASE_FUNC_MIGRATION_LIST *migration_list)
|
|
{
|
|
int user_version = 0;
|
|
char *err_msg = NULL;
|
|
|
|
int rc = sqlite3_exec_monitored(database, "PRAGMA user_version;", return_int_cb, (void *) &user_version, &err_msg);
|
|
if (rc != SQLITE_OK) {
|
|
info("Error checking the %s database version; %s", db_name, err_msg);
|
|
sqlite3_free(err_msg);
|
|
}
|
|
|
|
if (likely(user_version == target_version)) {
|
|
info("%s database version is %d (no migration needed)", db_name, target_version);
|
|
return target_version;
|
|
}
|
|
|
|
info("Database version is %d, current version is %d. Running migration for %s ...", user_version, target_version, db_name);
|
|
for (int i = user_version; i < target_version && migration_list[i].func; i++) {
|
|
rc = (migration_list[i].func)(database, migration_list[i].name);
|
|
if (unlikely(rc)) {
|
|
error_report("Database %s migration from version %d to version %d failed", db_name, i, i + 1);
|
|
return i;
|
|
}
|
|
}
|
|
return target_version;
|
|
|
|
}
|
|
|
|
DATABASE_FUNC_MIGRATION_LIST migration_action[] = {
|
|
{.name = "v0 to v1", .func = do_migration_noop},
|
|
{.name = "v1 to v2", .func = do_migration_v1_v2},
|
|
{.name = "v2 to v3", .func = do_migration_v2_v3},
|
|
{.name = "v3 to v4", .func = do_migration_v3_v4},
|
|
{.name = "v4 to v5", .func = do_migration_v4_v5},
|
|
// the terminator of this array
|
|
{.name = NULL, .func = NULL}
|
|
};
|
|
|
|
DATABASE_FUNC_MIGRATION_LIST context_migration_action[] = {
|
|
{.name = "v0 to v1", .func = do_migration_noop},
|
|
// the terminator of this array
|
|
{.name = NULL, .func = NULL}
|
|
};
|
|
|
|
|
|
int perform_database_migration(sqlite3 *database, int target_version)
|
|
{
|
|
return migrate_database(database, target_version, "metadata", migration_action);
|
|
}
|
|
|
|
int perform_context_database_migration(sqlite3 *database, int target_version)
|
|
{
|
|
return migrate_database(database, target_version, "context", context_migration_action);
|
|
}
|