mirror of
https://github.com/netdata/netdata.git
synced 2025-04-14 09:38:34 +00:00

* rrdset - in progress * rrdset optimal constructor; rrdset conflict * rrdset final touches * re-organization of rrdset object members * prevent use-after-free * dictionary dfe supports also counting of iterations * rrddim managed by dictionary * rrd.h cleanup * DICTIONARY_ITEM now is referencing actual dictionary items in the code * removed rrdset linked list * Revert "removed rrdset linked list" This reverts commit 690d6a588b4b99619c2c5e10f84e8f868ae6def5. * removed rrdset linked list * added comments * Switch chart uuid to static allocation in rrdset Remove unused functions * rrdset_archive() and friends... * always create rrdfamily * enable ml_free_dimension * rrddim_foreach done with dfe * most custom rrddim loops replaced with rrddim_foreach * removed accesses to rrddim->dimensions * removed locks that are no longer needed * rrdsetvar is now managed by the dictionary * set rrdset is rrdsetvar, fixes https://github.com/netdata/netdata/pull/13646#issuecomment-1242574853 * conflict callback of rrdsetvar now properly checks if it has to reset the variable * dictionary registered callbacks accept as first parameter the DICTIONARY_ITEM * dictionary dfe now uses internal counter to report; avoided excess variables defined with dfe * dictionary walkthrough callbacks get dictionary acquired items * dictionary reference counters that can be dupped from zero * added advanced functions for get and del * rrdvar managed by dictionaries * thread safety for rrdsetvar * faster rrdvar initialization * rrdvar string lengths should match in all add, del, get functions * rrdvar internals hidden from the rest of the world * rrdvar is now acquired throughout netdata * hide the internal structures of rrdsetvar * rrdsetvar is now acquired through out netdata * rrddimvar managed by dictionary; rrddimvar linked list removed; rrddimvar structures hidden from the rest of netdata * better error handling * dont create variables if not initialized for health * dont create variables if not initialized for health again * rrdfamily is now managed by dictionaries; references of it are acquired dictionary items * type checking on acquired objects * rrdcalc renaming of functions * type checking for rrdfamily_acquired * rrdcalc managed by dictionaries * rrdcalc double free fix * host rrdvars is always needed * attempt to fix deadlock 1 * attempt to fix deadlock 2 * Remove unused variable * attempt to fix deadlock 3 * snprintfz * rrdcalc index in rrdset fix * Stop storing active charts and computing chart hashes * Remove store active chart function * Remove compute chart hash function * Remove sql_store_chart_hash function * Remove store_active_dimension function * dictionary delayed destruction * formatting and cleanup * zero dictionary base on rrdsetvar * added internal error to log delayed destructions of dictionaries * typo in rrddimvar * added debugging info to dictionary * debug info * fix for rrdcalc keys being empty * remove forgotten unlock * remove deadlock * Switch to metadata version 5 and drop chart_hash chart_hash_map chart_active dimension_active v_chart_hash * SQL cosmetic changes * do not busy wait while destroying a referenced dictionary * remove deadlock * code cleanup; re-organization; * fast cleanup and flushing of dictionaries * number formatting fixes * do not delete configured alerts when archiving a chart * rrddim obsolete linked list management outside dictionaries * removed duplicate contexts call * fix crash when rrdfamily is not initialized * dont keep rrddimvar referenced * properly cleanup rrdvar * removed some locks * Do not attempt to cleanup chart_hash / chart_hash_map * rrdcalctemplate managed by dictionary * register callbacks on the right dictionary * removed some more locks * rrdcalc secondary index replaced with linked-list; rrdcalc labels updates are now executed by health thread * when looking up for an alarm look using both chart id and chart name * host initialization a bit more modular * init rrdlabels on host update * preparation for dictionary views * improved comment * unused variables without internal checks * service threads isolation and worker info * more worker info in service thread * thread cancelability debugging with internal checks * strings data races addressed; fixes https://github.com/netdata/netdata/issues/13647 * dictionary modularization * Remove unused SQL statement definition * unit-tested thread safety of dictionaries; removed data race conditions on dictionaries and strings; dictionaries now can detect if the caller is holds a write lock and automatically all the calls become their unsafe versions; all direct calls to unsafe version is eliminated * remove worker_is_idle() from the exit of service functions, because we lose the lock time between loops * rewritten dictionary to have 2 separate locks, one for indexing and another for traversal * Update collectors/cgroups.plugin/sys_fs_cgroup.c Co-authored-by: Vladimir Kobal <vlad@prokk.net> * Update collectors/cgroups.plugin/sys_fs_cgroup.c Co-authored-by: Vladimir Kobal <vlad@prokk.net> * Update collectors/proc.plugin/proc_net_dev.c Co-authored-by: Vladimir Kobal <vlad@prokk.net> * fix memory leak in rrdset cache_dir * minor dictionary changes * dont use index locks in single threaded * obsolete dict option * rrddim options and flags separation; rrdset_done() optimization to keep array of reference pointers to rrddim; * fix jump on uninitialized value in dictionary; remove double free of cache_dir * addressed codacy findings * removed debugging code * use the private refcount on dictionaries * make dictionary item desctructors work on dictionary destruction; strictier control on dictionary API; proper cleanup sequence on rrddim; * more dictionary statistics * global statistics about dictionary operations, memory, items, callbacks * dictionary support for views - missing the public API * removed warning about unused parameter * chart and context name for cloud * chart and context name for cloud, again * dictionary statistics fixed; first implementation of dictionary views - not currently used * only the master can globally delete an item * context needs netdata prefix * fix context and chart it of spins * fix for host variables when health is not enabled * run garbage collector on item insert too * Fix info message; remove extra "using" * update dict unittest for new placement of garbage collector * we need RRDHOST->rrdvars for maintaining custom host variables * Health initialization needs the host->host_uuid * split STRING to its own files; no code changes other than that * initialize health unconditionally * unit tests do not pollute the global scope with their variables * Skip initialization when creating archived hosts on startup. When a child connects it will initialize properly Co-authored-by: Stelios Fragkakis <52996999+stelfrag@users.noreply.github.com> Co-authored-by: Vladimir Kobal <vlad@prokk.net>
130 lines
5.6 KiB
C
130 lines
5.6 KiB
C
/* SPDX-License-Identifier: GPL-3.0-or-later */
|
|
/*
|
|
* 1. build netdata (as normally)
|
|
* 2. cd tests/profile/
|
|
* 3. compile with:
|
|
* gcc -O3 -Wall -Wextra -I ../../src/ -I ../../ -o benchmark-dictionary benchmark-dictionary.c ../../src/dictionary.o ../../src/log.o ../../src/avl.o ../../src/common.o -pthread
|
|
*
|
|
*/
|
|
|
|
#include "config.h"
|
|
#include "libnetdata/libnetdata.h"
|
|
|
|
struct myvalue {
|
|
int i;
|
|
};
|
|
|
|
void netdata_cleanup_and_exit(int ret) { exit(ret); }
|
|
|
|
int main(int argc, char **argv) {
|
|
if(argc || argv) {;}
|
|
|
|
// DICTIONARY *dict = dictionary_create(DICT_OPTION_SINGLE_THREADED|DICT_OPTION_WITH_STATISTICS);
|
|
DICTIONARY *dict = dictionary_create(DICT_OPTION_STATS);
|
|
if(!dict) fatal("Cannot create dictionary.");
|
|
|
|
struct rusage start, end;
|
|
unsigned long long dt;
|
|
char buf[100 + 1];
|
|
struct myvalue value, *v;
|
|
int i, max = 30000000, max2;
|
|
|
|
// ------------------------------------------------------------------------
|
|
|
|
getrusage(RUSAGE_SELF, &start);
|
|
dict->stats->inserts = dict->stats->deletes = dict->stats->searches = 0ULL;
|
|
fprintf(stderr, "Inserting %d entries in the dictionary\n", max);
|
|
for(i = 0; i < max; i++) {
|
|
value.i = i;
|
|
snprintf(buf, 100, "%d", i);
|
|
|
|
dictionary_set(dict, buf, &value, sizeof(struct myvalue));
|
|
}
|
|
getrusage(RUSAGE_SELF, &end);
|
|
dt = (end.ru_utime.tv_sec * 1000000ULL + end.ru_utime.tv_usec) - (start.ru_utime.tv_sec * 1000000ULL + start.ru_utime.tv_usec);
|
|
fprintf(stderr, "Added %d entries in %llu nanoseconds: %llu inserts per second\n", max, dt, max * 1000000ULL / dt);
|
|
fprintf(stderr, " > Dictionary: %llu inserts, %llu deletes, %llu searches\n\n", dict->stats->inserts, dict->stats->deletes, dict->stats->searches);
|
|
|
|
// ------------------------------------------------------------------------
|
|
|
|
getrusage(RUSAGE_SELF, &start);
|
|
dict->stats->inserts = dict->stats->deletes = dict->stats->searches = 0ULL;
|
|
fprintf(stderr, "Retrieving %d entries from the dictionary\n", max);
|
|
for(i = 0; i < max; i++) {
|
|
value.i = i;
|
|
snprintf(buf, 100, "%d", i);
|
|
|
|
v = dictionary_get(dict, buf);
|
|
if(!v)
|
|
fprintf(stderr, "ERROR: cannot get value %d from the dictionary\n", i);
|
|
else if(v->i != i)
|
|
fprintf(stderr, "ERROR: expected %d but got %d\n", i, v->i);
|
|
}
|
|
getrusage(RUSAGE_SELF, &end);
|
|
dt = (end.ru_utime.tv_sec * 1000000ULL + end.ru_utime.tv_usec) - (start.ru_utime.tv_sec * 1000000ULL + start.ru_utime.tv_usec);
|
|
fprintf(stderr, "Read %d entries in %llu nanoseconds: %llu searches per second\n", max, dt, max * 1000000ULL / dt);
|
|
fprintf(stderr, " > Dictionary: %llu inserts, %llu deletes, %llu searches\n\n", dict->stats->inserts, dict->stats->deletes, dict->stats->searches);
|
|
|
|
// ------------------------------------------------------------------------
|
|
|
|
getrusage(RUSAGE_SELF, &start);
|
|
dict->stats->inserts = dict->stats->deletes = dict->stats->searches = 0ULL;
|
|
fprintf(stderr, "Resetting %d entries in the dictionary\n", max);
|
|
for(i = 0; i < max; i++) {
|
|
value.i = i;
|
|
snprintf(buf, 100, "%d", i);
|
|
|
|
dictionary_set(dict, buf, &value, sizeof(struct myvalue));
|
|
}
|
|
getrusage(RUSAGE_SELF, &end);
|
|
dt = (end.ru_utime.tv_sec * 1000000ULL + end.ru_utime.tv_usec) - (start.ru_utime.tv_sec * 1000000ULL + start.ru_utime.tv_usec);
|
|
fprintf(stderr, "Reset %d entries in %llu nanoseconds: %llu resets per second\n", max, dt, max * 1000000ULL / dt);
|
|
fprintf(stderr, " > Dictionary: %llu inserts, %llu deletes, %llu searches\n\n", dict->stats->inserts, dict->stats->deletes, dict->stats->searches);
|
|
|
|
// ------------------------------------------------------------------------
|
|
|
|
getrusage(RUSAGE_SELF, &start);
|
|
dict->stats->inserts = dict->stats->deletes = dict->stats->searches = 0ULL;
|
|
fprintf(stderr, "Searching %d non-existing entries in the dictionary\n", max);
|
|
max2 = max * 2;
|
|
for(i = max; i < max2; i++) {
|
|
value.i = i;
|
|
snprintf(buf, 100, "%d", i);
|
|
|
|
v = dictionary_get(dict, buf);
|
|
if(v)
|
|
fprintf(stderr, "ERROR: cannot got non-existing value %d from the dictionary\n", i);
|
|
}
|
|
getrusage(RUSAGE_SELF, &end);
|
|
dt = (end.ru_utime.tv_sec * 1000000ULL + end.ru_utime.tv_usec) - (start.ru_utime.tv_sec * 1000000ULL + start.ru_utime.tv_usec);
|
|
fprintf(stderr, "Searched %d non-existing entries in %llu nanoseconds: %llu not found searches per second\n", max, dt, max * 1000000ULL / dt);
|
|
fprintf(stderr, " > Dictionary: %llu inserts, %llu deletes, %llu searches\n\n", dict->stats->inserts, dict->stats->deletes, dict->stats->searches);
|
|
|
|
// ------------------------------------------------------------------------
|
|
|
|
getrusage(RUSAGE_SELF, &start);
|
|
dict->stats->inserts = dict->stats->deletes = dict->stats->searches = 0ULL;
|
|
fprintf(stderr, "Deleting %d entries from the dictionary\n", max);
|
|
for(i = 0; i < max; i++) {
|
|
value.i = i;
|
|
snprintf(buf, 100, "%d", i);
|
|
|
|
dictionary_del(dict, buf);
|
|
}
|
|
getrusage(RUSAGE_SELF, &end);
|
|
dt = (end.ru_utime.tv_sec * 1000000ULL + end.ru_utime.tv_usec) - (start.ru_utime.tv_sec * 1000000ULL + start.ru_utime.tv_usec);
|
|
fprintf(stderr, "Deleted %d entries in %llu nanoseconds: %llu deletes per second\n", max, dt, max * 1000000ULL / dt);
|
|
fprintf(stderr, " > Dictionary: %llu inserts, %llu deletes, %llu searches\n\n", dict->stats->inserts, dict->stats->deletes, dict->stats->searches);
|
|
|
|
// ------------------------------------------------------------------------
|
|
|
|
getrusage(RUSAGE_SELF, &start);
|
|
dict->stats->inserts = dict->stats->deletes = dict->stats->searches = 0ULL;
|
|
fprintf(stderr, "Destroying dictionary\n");
|
|
dictionary_destroy(dict);
|
|
getrusage(RUSAGE_SELF, &end);
|
|
dt = (end.ru_utime.tv_sec * 1000000ULL + end.ru_utime.tv_usec) - (start.ru_utime.tv_sec * 1000000ULL + start.ru_utime.tv_usec);
|
|
fprintf(stderr, "Destroyed in %llu nanoseconds\n", dt);
|
|
|
|
return 0;
|
|
}
|