archive/nextcloud_server
0
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2025-03-16 17:24:10 +00:00
Code Issues Projects Releases Wiki Activity

Throw if creation date is read before inserting into database

Browse source 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
This commit is contained in:
Côme Chilliet 2023-06-20 12:14:57 +02:00
parent 77355a8a79
commit 7aa97dcc23
No known key found for this signature in database
GPG key ID: A3E2F658B28C760A
2 changed files with 8 additions and 2 deletions
lib/private/Comments
Comment.phpManager.php

6
lib/private/Comments/Comment.php
View file

@ -304,9 +304,13 @@ class Comment implements IComment {
*
* If not explicitly set, it shall default to the time of initialization.
* @since 9.0.0
* @throw \LogicException if creation date time is not set yet
*/
public function getCreationDateTime(): \DateTime {
return $this->data['creationDT'] ?? new \DateTime();
if (!isset($this->data['creationDT'])) {
throw new \LogicException('Cannot get creation date before setting one or writting to database');
}
return $this->data['creationDT'];
}
/**

4
lib/private/Comments/Manager.php
View file

@ -154,7 +154,9 @@ class Manager implements ICommentsManager {
$comment->setLatestChildDateTime(null);
}
if (is_null($comment->getCreationDateTime())) {
try {
$comment->getCreationDateTime();
} catch(\LogicException $e) {
$comment->setCreationDateTime(new \DateTime());
}