archive/nextcloud_server
0
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2025-03-12 23:47:25 +00:00
Code Issues Projects Releases Wiki Activity
79087 commits 478 branches 1087 tags 3.3 GiB
Commit graph

1731 commits

Author SHA1 Message Date
Luka Trovic
6343839d71 fix(files_sharing): skip expiration notify for invalid share record 
Signed-off-by: Luka Trovic <luka@nextcloud.com>
 2025-01-29 15:44:53 +01:00
Ferdinand Thiessen
b48ee2e924
fix: Harden files scanner for invalid null access 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-28 20:08:46 +01:00
Ferdinand Thiessen
253f4345f1
fix(files_sharing): Respect permissions passed when creating link shares 
Given:
User creates a link or email share with permissions=4 (create only = file drop).

Problem:
Currently the permissions are automatically extended to permissions = 5
(READ + CREATE). Work around was to create the share and directly update
it.

Solution:
Respect what the user is requesting, create a file drop share.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-28 16:40:50 +01:00
Ferdinand Thiessen
305e1bb260
fix: Ensure label is always a string 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-26 20:41:31 +01:00
Anna
d9a7124592
Merge pull request from nextcloud/fix/noid/no-emails-for-user-shares 
fix(sharing): send share emails for internal users too
 2025-01-16 18:50:30 +01:00
Christopher Ng
0eb39d7b9c feat(sharing): Respect admin custom tokens setting 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2025-01-15 15:50:43 -08:00
Christopher Ng
4d78de497f feat(sharing): Add custom_tokens capability 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2025-01-15 15:50:43 -08:00
Christopher Ng
beffb26266 feat(sharing): Fetch a unique generated token 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2025-01-15 15:49:19 -08:00
Christopher Ng
f92875cf6a feat(sharing): Allow updating share token 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2025-01-15 15:49:19 -08:00
provokateurin
90c608bdc7
fix(files_sharing): Fix sharee search result types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-01-13 15:21:21 +01:00
provokateurin
9f59204148
fix(files_sharing): Gracefully handle fetching non-existent share 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-01-13 15:21:20 +01:00
provokateurin
4dfa02c29d
fix(files_sharing): Handle null userId 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-01-13 15:19:54 +01:00
Anna Larch
236e084fbb fix(sharing): send share emails for internal users too 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2025-01-13 14:13:02 +01:00
skjnldsv
5c359e424f feat(federatedfilesharing): auto-accept shares from trusted servers 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2025-01-09 12:54:51 +01:00
provokateurin
085d4c9364
refactor(OpenAPI): Adjust scopes to match previous behavior 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-01-06 14:30:40 +01:00
skjnldsv
bc0ad5efbf fix(federatedfilesharing): get share by token fallback 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-12-28 09:27:30 +01:00
skjnldsv
8089de5fcf fix(activity): make emails for link share uploads true by default 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-12-06 12:34:52 +01:00
Maxence Lange
4591430c9c feat(ocm): signing ocm requests 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-12-04 09:30:55 -01:00
Stephan Orbaugh
e87ed9b5fb
Merge pull request from nextcloud/shared-watcher-perf 
perf: improve performance of SharedStorage::getWatcher
 2024-12-03 09:57:56 +01:00
Robin Appelman
bc53a8ab87
perf: improve performance of SharedStorage::getWatcher 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-11-29 18:10:30 +01:00
Benjamin Gaussorgues
5581f0c7bf
chore: remove legacy action to test remote endpoint 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-11-29 11:14:37 +01:00
Benjamin Gaussorgues
ae1c3b372e
chore: stricter access to testremote endpoint 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-11-28 11:22:15 +01:00
Côme Chilliet
ae7f9cb3c1
Merge pull request from nextcloud/bugfix/error-on-reshare-after-transfer-ownership 
fix: update re-share if shared-by user has been revoked
 2024-11-25 18:20:29 +01:00
provokateurin
715e7143f0
fix(files_sharing,files): Do not validate shares before adjusting the owner 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-11-25 10:27:31 +01:00
provokateurin
beea8854ca
feat(files_sharing): Allow users with share permission to manage shares on IShareOwnerlessMount 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-11-25 10:27:31 +01:00
provokateurin
b658ab7a86
fix(files_sharing): Remove duplicate link/email edit share logic 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-11-25 10:27:31 +01:00
Côme Chilliet
f44a192613
fix(files_sharing): Fix error messages from password policy 
Exceptions thrown from password_policy may bubble up in share creation
 or update when a password is used. Their message is meant to be shown
 to the user. This always the case for HintException so we catch that
 instead of the subclass GenericShareException.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-11-19 09:40:26 +01:00
Luka Trovic
2ca51919db fix(sharing): add command to fix broken shares after ownership transferring 
Signed-off-by: Luka Trovic <luka@nextcloud.com>
 2024-11-18 21:24:23 +01:00
skjnldsv
4d9d617c84 feat(files_sharing): use share node or label as page title 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-11-08 14:20:58 +01:00
provokateurin
77114fb327
fix(OpenAPI): Adjust array syntax to avoid ambiguities 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-11-05 09:58:11 +01:00
Ferdinand Thiessen
c84c256261
fix: Adjust preview for view-only shares 
Previously there was a different behavior for public shares (link-shares) and internal shares,
if the user disabled the view permission.
The legacy UI for public shares simply "disabled" the context menu and hided all download actions.
With Nextcloud 31 all share types use the consistent permissions attributes,
which simplifies code, but caused a regression: Images can no longer been viewed.

Because on 30 and before the attribute was not set, previews for view-only files
were still allowed. Now with 31 we need a new way to allow "viewing" shares.

So this is allowing previews for those files, but only for internal usage.
This is done by settin a special header, which only works with custom requests,
and not by opening the URL directly.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-28 15:52:27 +01:00
Kate
8b5e1bac90
Merge pull request from nextcloud/fix/files_sharing/cleanup-error-messages 2024-10-28 12:47:12 +01:00
Kate
5efb175665
Merge pull request from nextcloud/refactor/storage/constructors 2024-10-28 10:19:41 +01:00
provokateurin
aacb3ddc1e
fix(files_sharing): Cleanup error messages 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-28 09:07:41 +01:00
fenn-cs
227b8462d8 refactor(ShareApiController): Check for null and empty strings with empty() 
Proactive measure to avoid warnings in higher php versions as well possible type errors

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-10-24 18:37:42 +01:00
fenn-cs
e2d2a17810 fix(ShareAPI): Send mails for mail shares by default 
It looks like, the frontend it needs to provide the `sendMail` param
for the backend to decide wether mails would be sent.

Our UI does not have that at the moment so it should default to sending
emails always for mail shares.

Not exactly sure how this was handled earlier but this is a good starting point.

Resolves : https://github.com/nextcloud/server/issues/48012

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-10-24 14:41:07 +01:00
provokateurin
0de4843b73 refactor(Storage): Align all Storage constructors 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-23 13:24:18 +02:00
provokateurin
381077028a
refactor(apps): Use constructor property promotion when possible 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-21 12:37:59 +02:00
Joas Schilling
5262bc6be3
fix(activity): Fix download activity parameters 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-10-19 22:50:44 +02:00
dependabot[bot]
bb598c8451
chore(deps): Bump nextcloud/coding-standard in /vendor-bin/cs-fixer 
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v1.3.1...v1.3.2)

---
updated-dependencies:
- dependency-name: nextcloud/coding-standard
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-19 07:57:35 +02:00
Git'Fellow
a1681b0756 chore(db): Apply query prepared statements 
Fix: psalm

fix: bad file

fix: bug

chore: add batch

chore: add batch

chore: add batch

fix: psalm
 2024-10-17 20:30:47 +02:00
Git'Fellow
c254855222 chore(db): Correctly apply query types 
fix: psalm

fix: error

fix: add batch

fix: fatal error

fix: add batch

chore: add batch

chore: add batch

fix: psalm

fix: typo

fix: psalm

fix: return bool

fix: revert Manager
 2024-10-17 09:21:07 +02:00
Côme Chilliet
1580c8612b
chore(apps): Apply new rector configuration to autouse classes 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-10-15 10:40:25 +02:00
Ferdinand Thiessen
64dd4ce0ee
revert: "fix(files_sharing): Make share labels nullable" 
This reverts commit 01c4fa3ba8.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-14 15:16:25 +02:00
Kate
614d8c23a0
Merge pull request from nextcloud/refactor/storage/strong-param-types 2024-10-08 15:20:17 +02:00
provokateurin
54ec472d9a
fix(BackgroundJobs): Adjust intervals and time sensitivities 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-08 11:26:53 +02:00
provokateurin
1642a34e8a
refactor(files_sharing): Add Storage parameter strong types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-07 15:00:07 +02:00
Ferdinand Thiessen
e9d590674d
feat(files_sharing): Make ShareController download route use the DAV ZipFolderPlugin 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-28 13:18:34 +02:00
provokateurin
376d5665bb
fix(files_sharing): Fix all IStorage return types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-26 17:29:47 +02:00
provokateurin
13d1cb730f
fix(files_sharing): Check if propfind response is valid before accessing share permission props 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-26 14:35:31 +02:00