archive/nextcloud_server
0
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2025-03-13 16:03:55 +00:00
Code Issues Projects Releases Wiki Activity
67992 commits 481 branches 1090 tags 3.3 GiB
Commit graph

70 commits

Author SHA1 Message Date
Christopher Ng
f1ce5d4a22 fix(trashbin): Truncate long filenames 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2023-06-01 10:04:59 +00:00
Julius Härtl
7f913dec03
fix(files_trashbin): Remove unnecessary scanner logic when getting versions from trash 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-02-02 17:23:05 +01:00
luz paz
9d26671f05 Fix typos in apps/ subdirectory 
Found via `codespell -q 3 -S l10n,./apps/files_external/3rdparty -L adn,ba,boxs,keypair,jus,optionel,ressource,tabel ./apps/`

Signed-off-by: luz paz <luzpaz@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
 2022-09-05 12:59:54 +00:00
Carl Schwan
458c2fa297
Remove OCP\App and OCP\BackgroundJob 
Both deprecated since NC 23

IAppManager is the replacement for OCP\App unfortunately it can't be
dependency injected in classes used by the installed otherwise the
database connection is initialised too early

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-08-01 09:46:40 +02:00
Robin Appelman
9188fad190
use size from cache to determine whether to skip the trashbin 
this way large folders also get skipped

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-06-29 18:24:34 +02:00
Carl Schwan
53169890d6 Fix psalm errors fron the end of the baseline file 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-16 10:58:26 +02:00
Côme Chilliet
ea23523c70
Adapt more code to migration to LoggerInterface 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-24 16:21:25 +01:00
Sven Strickroth
1c736abc35 Don't die with LockedException when removing/restoring multiple files from trash 
fixes issue 

Signed-off-by: Sven Strickroth <email@cs-ware.de>
 2021-08-19 16:43:44 +02:00
Robin Appelman
e198dc1b20
rework search api to allow searching on multiple caches at once 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-06-14 16:11:22 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-06-04 22:02:41 +02:00
Christoph Wurst
8196420063
Drop \OCP\User 
Inlines and remaining usages and drops the deprecated public API.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-05-21 15:00:34 +02:00
Christoph Wurst
99f2fa73d1
Fix usage of rename executeUpdate 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-05-05 10:35:25 +02:00
Roeland Jago Douma
8008b33b8d Cleanp execute usage in the trashbin 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-03-11 15:39:42 +01:00
Christoph Wurst
d89a75be0b
Update all license headers for Nextcloud 21 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-16 18:48:22 +01:00
Joas Schilling
8027dcbc6f
Don't leave cursors open when tests fail 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-09 12:28:17 +01:00
Joas Schilling
e52925c5fb
Use query builder instead of OC_DB in trashbin 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-06 22:33:59 +01:00
Julius Härtl
2616a784c9
Restrict query when searching for versions of trashbin files 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-10-14 16:38:30 +02:00
Robin Appelman
e0d688c365
dont hold a transaction during the move to trash 
because moving to trash can take a long time, keeping a transaction active for the duration can lead to issues

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-09-30 14:30:54 +02:00
Julius Härtl
3c47aaa2b1
Delete files that exceed trashbin size immediately 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-09-23 16:58:18 +02:00
Christoph Wurst
1f7f93a695
Update license headers for Nextcloud 20 (again) 
There are still lots of outdated headers, so time for another round of
updates.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-09-07 14:37:44 +02:00
Daniel Kesselberg
2513b64602
Change free space calculation 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-08-31 23:11:10 +02:00
blizzz
a3d30bf4a2
Merge pull request from nextcloud/techdebt/noid/bootstrap-files_trashbin 
Use IBootstrap for the files_trashbin app
 2020-08-07 11:12:09 +00:00
Robin Appelman
c2c9a6a0e1
fix object store trashbin handling 
object stores are "special" given how they interact with the cache on their own

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-30 16:31:56 +02:00
Morris Jobke
e84504c4d6
Use IBootstrap for the files_trashbin app 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-23 22:03:14 +02:00
Robin Appelman
fcad692b4a
rollback cache rename if trashbin move fails 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-23 15:24:48 +02:00
Robin Appelman
5949849322
fix moving files from external storage to object store trashbin 
having the "cache rename" after the "storage move" caused the target
to get the fileid from the source file, without taking care that the object
is stored under the original file id.

By doing the "cache rename" first, we trigger the "update existing file"
logic while moving the file to the object store and the object gets stored for the
correct file id

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-23 15:24:44 +02:00
Robin Appelman
050e2fe346
allow admin to configure the max trashbin size 
this allows an admin to configure the max trashbin size instead of always relying on the users quota.

The trashbin size can be configured using the `occ trash:size` command and can be set both globally and per-user

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-07 14:45:08 +02:00
Robin Appelman
614acc9419
add locking to resolve concurent move to trashbin conflicts 
uses a lock to prevent two requests from moving a file to the trashbin concurrently
(causing sql duplicate key errors)

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-05-06 20:36:55 +02:00
Christoph Wurst
28f8eb5dba
Add visibility to all constants 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 16:54:27 +02:00
Christoph Wurst
caff1023ea
Format control structures, classes, methods and function 
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 14:19:56 +02:00
Christoph Wurst
14c996d982
Use elseif instead of else if 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 10:35:09 +02:00
Christoph Wurst
afbd9c4e6e
Unify function spacing to PSR2 recommendation 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 13:54:22 +02:00
Christoph Wurst
b80ebc9674
Use the short array syntax, everywhere 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-26 16:34:56 +01:00
Christoph Wurst
5bf3d1bb38
Update license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-12-05 15:38:45 +01:00
Robin Appelman
964dc0a955
set retention obligation on existing expiration in tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2019-11-04 16:54:22 +01:00
Christoph Wurst
543190f8b3
Do not create Application instances directly 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-10-11 08:33:09 +02:00
Robin Appelman
9bf8ee701f
Update apps/files_trashbin/lib/Trashbin.php 
Co-Authored-By: Morris Jobke <hey@morrisjobke.de>
 2019-09-04 13:06:07 +02:00
Robin Appelman
fafce34aa0
dont try to copy trash items to user if the user has not enough free space 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2019-07-29 14:05:49 +02:00
Robin Appelman
62a969f056
dont try to restore a trashbin item to a readonly target 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2019-03-14 16:18:43 +01:00
Morris Jobke
4704e719ed
Only fetch size of this storage without mount points - ref 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2019-03-01 12:05:18 +01:00
Morris Jobke
f6967a974f
Revert "Fix for issue 10862: calculation of free space ignores external storage (doesn't count towards quota)" 
This reverts commit e806aa658c.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2019-03-01 12:03:33 +01:00
Felix Nieuwenhuizen
e806aa658c Fix for issue 10862: calculation of free space ignores external storage (doesn't count towards quota) 
Signed-off-by: Felix Nieuwenhuizen <felix@tdlrali.com>
 2019-01-26 17:23:23 +01:00
Robin Appelman
4adac445dc
fix select statement 
fix select statement
Make trashbin api modules

Apps can register trashbin backends for specific storages,
allowing them to modify trashbin behavior for storages

The old trashbin implementation has been wrapped in a "legacy" backend,
for future work this can be replaced with a new backend that better handles
shares while still keeping the legacy backend around to keep existing trash
from being accessible

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2018-10-17 14:56:45 +02:00
Lars Knickrehm
436c4f8954
Improved logging statement 2018-06-24 13:41:16 +02:00
Lars Knickrehm
e360885eb0
Workaround for interrupting expired files deletion 
Workaround avoiding "Error while running background job (class: OCA\Files_Trashbin\BackgroundJob\ExpireTrash, arguments: ): {"Exception":"OCP\\Files\\NotPermittedException","Message":"","Code":0,"Trace":" \/var\/www\/cloud\/apps\/files_trashbin\/lib\/Trashbin.php(590): OC\\Files\\Node\\File->delete() [...]"
 2018-05-28 00:59:20 +02:00
Morris Jobke
dd34cb7540
Less deprecated calls to OCP\Util::writeLog 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-04-22 20:41:49 +02:00
Roeland Jago Douma
83873e3da1
Remove deprecated URL functions for OCP\Util 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-03-13 22:04:08 +01:00
Morris Jobke
a661f043e1
Remove unneeded semicolon and parentheses 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-26 23:46:40 +01:00
Morris Jobke
c005fc6755
Cleanup unused code 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-26 15:25:19 +01:00
Morris Jobke
31c5c2a592
Change @georgehrke's email 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-11-06 20:38:59 +01:00