mirror of
https://github.com/nextcloud/server.git
synced 2025-02-23 00:19:14 +00:00
bbbc931766
Address book and calendar sync tokens have a created_at column in 26+ and we need to assign a current timestamp to the existing data at upgrade so the data isn't cleaned up immediately. Updating the full table is expensive and fails on clustered setups that limit transaction size. We don't need a timestamp for the oldest rows so we can skip updating them. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
111 lines
3.6 KiB
PHP
111 lines
3.6 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
/**
|
|
* @copyright Copyright (c) 2024 Christoph Wurst <christoph@winzerhof-wurst.at>
|
|
*
|
|
* @author Christoph Wurst <christoph@winzerhof-wurst.at>
|
|
*
|
|
* @license GNU AGPL version 3 or any later version
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as
|
|
* published by the Free Software Foundation, either version 3 of the
|
|
* License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Affero General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Affero General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
namespace OCA\DAV\Migration;
|
|
|
|
use Closure;
|
|
use OCP\AppFramework\Services\IAppConfig;
|
|
use OCP\DB\ISchemaWrapper;
|
|
use OCP\DB\QueryBuilder\IQueryBuilder;
|
|
use OCP\DB\Types;
|
|
use OCP\IDBConnection;
|
|
use OCP\Migration\IOutput;
|
|
use OCP\Migration\SimpleMigrationStep;
|
|
|
|
class Version1025Date20240308063933 extends SimpleMigrationStep {
|
|
|
|
private IAppConfig $appConfig;
|
|
private IDBConnection $db;
|
|
|
|
public function __construct(IAppConfig $appConfig,
|
|
IDBConnection $db) {
|
|
$this->db = $db;
|
|
$this->appConfig = $appConfig;
|
|
}
|
|
|
|
/**
|
|
* @param IOutput $output
|
|
* @param Closure(): ISchemaWrapper $schemaClosure
|
|
* @param array $options
|
|
* @return null|ISchemaWrapper
|
|
*/
|
|
public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
|
|
/** @var ISchemaWrapper $schema */
|
|
$schema = $schemaClosure();
|
|
|
|
foreach (['addressbookchanges', 'calendarchanges'] as $tableName) {
|
|
$table = $schema->getTable($tableName);
|
|
if (!$table->hasColumn('created_at')) {
|
|
$table->addColumn('created_at', Types::INTEGER, [
|
|
'notnull' => true,
|
|
'length' => 4,
|
|
'default' => 0,
|
|
]);
|
|
}
|
|
}
|
|
|
|
return $schema;
|
|
}
|
|
|
|
public function postSchemaChange(IOutput $output, \Closure $schemaClosure, array $options): void {
|
|
// The threshold is higher than the default of \OCA\DAV\BackgroundJob\PruneOutdatedSyncTokensJob
|
|
// but small enough to fit into a cluster transaction size.
|
|
// For a 50k users instance that would still keep 10 changes on average.
|
|
$limit = max(1, (int) $this->appConfig->getAppValue('totalNumberOfSyncTokensToKeep', '500000'));
|
|
|
|
foreach (['addressbookchanges', 'calendarchanges'] as $tableName) {
|
|
$thresholdSelect = $this->db->getQueryBuilder();
|
|
$thresholdSelect->select('id')
|
|
->from($tableName)
|
|
->orderBy('id', 'desc')
|
|
->setFirstResult($limit)
|
|
->setMaxResults(1);
|
|
$oldestIdResult = $thresholdSelect->executeQuery();
|
|
$oldestId = $oldestIdResult->fetchColumn();
|
|
$oldestIdResult->closeCursor();
|
|
|
|
$qb = $this->db->getQueryBuilder();
|
|
|
|
$update = $qb->update($tableName)
|
|
->set('created_at', $qb->createNamedParameter(time(), IQueryBuilder::PARAM_INT))
|
|
->where(
|
|
$qb->expr()->eq('created_at', $qb->createNamedParameter(0, IQueryBuilder::PARAM_INT)),
|
|
);
|
|
|
|
// If there is a lot of data we only set timestamp for the most recent rows
|
|
// because the rest will be deleted by \OCA\DAV\BackgroundJob\PruneOutdatedSyncTokensJob
|
|
// anyway.
|
|
if ($oldestId !== false) {
|
|
$update->andWhere($qb->expr()->gt('id', $qb->createNamedParameter($oldestId, IQueryBuilder::PARAM_INT), IQueryBuilder::PARAM_INT));
|
|
}
|
|
|
|
$updated = $update->executeStatement();
|
|
|
|
$output->debug('Added a default creation timestamp to ' . $updated . ' rows in ' . $tableName);
|
|
}
|
|
}
|
|
|
|
}
|