0
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2025-01-30 22:37:01 +00:00
nextcloud_server/apps/updatenotification/lib/Controller/APIController.php
Ferdinand Thiessen e212f337a2
fix(updatenotification): Parse pre-release version of apps
The notitication is correctly created, but the changelog is not show.
We need to make sure the version passed to the manager is in the allowed
format (major.minor.patch).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-21 16:43:20 +01:00

194 lines
5.5 KiB
PHP

<?php
declare(strict_types=1);
/**
* SPDX-FileCopyrightText: 2017 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
namespace OCA\UpdateNotification\Controller;
use OC\App\AppStore\Fetcher\AppFetcher;
use OCA\UpdateNotification\Manager;
use OCA\UpdateNotification\ResponseDefinitions;
use OCP\App\AppPathNotFoundException;
use OCP\App\IAppManager;
use OCP\AppFramework\Http;
use OCP\AppFramework\Http\DataResponse;
use OCP\AppFramework\OCSController;
use OCP\IConfig;
use OCP\IRequest;
use OCP\IUserSession;
use OCP\L10N\IFactory;
/**
* @psalm-import-type UpdateNotificationApp from ResponseDefinitions
*/
class APIController extends OCSController {
/** @var string */
protected $language;
/**
* List of apps that were in the appstore but are now shipped and don't have
* a compatible update available.
*
* @var array<string, int>
*/
protected array $appsShippedInFutureVersion = [
'bruteforcesettings' => 25,
'suspicious_login' => 25,
'twofactor_totp' => 25,
'files_downloadlimit' => 29,
'twofactor_nextcloud_notification' => 30,
'app_api' => 30,
];
public function __construct(
string $appName,
IRequest $request,
protected IConfig $config,
protected IAppManager $appManager,
protected AppFetcher $appFetcher,
protected IFactory $l10nFactory,
protected IUserSession $userSession,
protected Manager $manager,
) {
parent::__construct($appName, $request);
}
/**
* List available updates for apps
*
* @param string $newVersion Server version to check updates for
*
* @return DataResponse<Http::STATUS_OK, array{missing: list<UpdateNotificationApp>, available: list<UpdateNotificationApp>}, array{}>|DataResponse<Http::STATUS_NOT_FOUND, array{appstore_disabled: bool, already_on_latest?: bool}, array{}>
*
* 200: Apps returned
* 404: New versions not found
*/
public function getAppList(string $newVersion): DataResponse {
if (!$this->config->getSystemValue('appstoreenabled', true)) {
return new DataResponse([
'appstore_disabled' => true,
], Http::STATUS_NOT_FOUND);
}
// Get list of installed custom apps
$installedApps = $this->appManager->getInstalledApps();
$installedApps = array_filter($installedApps, function ($app) {
try {
$this->appManager->getAppPath($app);
} catch (AppPathNotFoundException $e) {
return false;
}
return !$this->appManager->isShipped($app) && !isset($this->appsShippedInFutureVersion[$app]);
});
if (empty($installedApps)) {
return new DataResponse([
'missing' => [],
'available' => [],
]);
}
$this->appFetcher->setVersion($newVersion, 'future-apps.json', false);
// Apps available on the app store for that version
$availableApps = array_map(static function (array $app) {
return $app['id'];
}, $this->appFetcher->get());
if (empty($availableApps)) {
return new DataResponse([
'appstore_disabled' => false,
'already_on_latest' => false,
], Http::STATUS_NOT_FOUND);
}
$this->language = $this->l10nFactory->getUserLanguage($this->userSession->getUser());
// Ignore apps that are deployed from git
$installedApps = array_filter($installedApps, function (string $appId) {
try {
return !file_exists($this->appManager->getAppPath($appId) . '/.git');
} catch (AppPathNotFoundException $e) {
return true;
}
});
$missing = array_diff($installedApps, $availableApps);
$missing = array_map([$this, 'getAppDetails'], $missing);
sort($missing);
$available = array_intersect($installedApps, $availableApps);
$available = array_map([$this, 'getAppDetails'], $available);
sort($available);
return new DataResponse([
'missing' => $missing,
'available' => $available,
]);
}
/**
* Get translated app name
*
* @param string $appId
* @return UpdateNotificationApp
*/
protected function getAppDetails(string $appId): array {
$app = $this->appManager->getAppInfo($appId, false, $this->language);
/** @var ?string $name */
$name = $app['name'];
return [
'appId' => $appId,
'appName' => $name ?? $appId,
];
}
/**
* Get changelog entry for an app
*
* @param string $appId App to search changelog entry for
* @param string|null $version The version to search the changelog entry for (defaults to the latest installed)
*
* @return DataResponse<Http::STATUS_OK, array{appName: string, content: string, version: string}, array{}>|DataResponse<Http::STATUS_NOT_FOUND, array{}, array{}>|DataResponse<Http::STATUS_BAD_REQUEST, array{}, array{}>
*
* 200: Changelog entry returned
* 400: The `version` parameter is not a valid version format
* 404: No changelog found
*/
public function getAppChangelogEntry(string $appId, ?string $version = null): DataResponse {
$version = $version ?? $this->appManager->getAppVersion($appId);
// handle pre-release versions
$matches = [];
$result = preg_match('/^(\d+\.\d+(\.\d+)?)/', $version, $matches);
if ($result === false || $result === 0) {
return new DataResponse([], Http::STATUS_BAD_REQUEST);
}
$shortVersion = $matches[0];
$changes = $this->manager->getChangelog($appId, $shortVersion);
if ($changes === null) {
return new DataResponse([], Http::STATUS_NOT_FOUND);
}
// Remove version headline
/** @var string[] */
$changes = explode("\n", $changes, 2);
$changes = trim(end($changes));
// Get app info for localized app name
$info = $this->appManager->getAppInfo($appId) ?? [];
/** @var string */
$appName = $info['name'] ?? $appId;
return new DataResponse([
'appName' => $appName,
'content' => $changes,
'version' => $version,
]);
}
}