mirror of
https://github.com/nextcloud/server.git
synced 2025-03-04 03:57:28 +00:00

Previously if a server status got set to failure, it stayed that way until an addressbook-sync found changes. Now the server status is set to OK after each successful sync check (if that's not the case already), regardless of addressbook changes. This change also includes two new logging statements, which could help next time someone debugs this. Signed-off-by: Pablo Zimdahl <pablo@nextcloud.com>
185 lines
5.3 KiB
PHP
185 lines
5.3 KiB
PHP
<?php
|
|
|
|
/**
|
|
* SPDX-FileCopyrightText: 2017-2024 Nextcloud GmbH and Nextcloud contributors
|
|
* SPDX-FileCopyrightText: 2016 ownCloud, Inc.
|
|
* SPDX-License-Identifier: AGPL-3.0-only
|
|
*/
|
|
namespace OCA\Federation\BackgroundJob;
|
|
|
|
use GuzzleHttp\Exception\ClientException;
|
|
use GuzzleHttp\Exception\RequestException;
|
|
use OCA\Federation\TrustedServers;
|
|
use OCP\AppFramework\Http;
|
|
use OCP\AppFramework\Utility\ITimeFactory;
|
|
use OCP\BackgroundJob\IJobList;
|
|
use OCP\BackgroundJob\Job;
|
|
use OCP\Http\Client\IClient;
|
|
use OCP\Http\Client\IClientService;
|
|
use OCP\Http\Client\IResponse;
|
|
use OCP\IURLGenerator;
|
|
use OCP\OCS\IDiscoveryService;
|
|
use Psr\Log\LoggerInterface;
|
|
|
|
/**
|
|
* Class GetSharedSecret
|
|
*
|
|
* Request shared secret from remote Nextcloud
|
|
*
|
|
* @package OCA\Federation\Backgroundjob
|
|
*/
|
|
class GetSharedSecret extends Job {
|
|
private IClient $httpClient;
|
|
private IJobList $jobList;
|
|
private IURLGenerator $urlGenerator;
|
|
private TrustedServers $trustedServers;
|
|
private IDiscoveryService $ocsDiscoveryService;
|
|
private LoggerInterface $logger;
|
|
protected bool $retainJob = false;
|
|
private string $defaultEndPoint = '/ocs/v2.php/apps/federation/api/v1/shared-secret';
|
|
/** 30 day = 2592000sec */
|
|
private int $maxLifespan = 2592000;
|
|
|
|
public function __construct(
|
|
IClientService $httpClientService,
|
|
IURLGenerator $urlGenerator,
|
|
IJobList $jobList,
|
|
TrustedServers $trustedServers,
|
|
LoggerInterface $logger,
|
|
IDiscoveryService $ocsDiscoveryService,
|
|
ITimeFactory $timeFactory
|
|
) {
|
|
parent::__construct($timeFactory);
|
|
$this->logger = $logger;
|
|
$this->httpClient = $httpClientService->newClient();
|
|
$this->jobList = $jobList;
|
|
$this->urlGenerator = $urlGenerator;
|
|
$this->ocsDiscoveryService = $ocsDiscoveryService;
|
|
$this->trustedServers = $trustedServers;
|
|
}
|
|
|
|
/**
|
|
* Run the job, then remove it from the joblist
|
|
*/
|
|
public function start(IJobList $jobList): void {
|
|
$target = $this->argument['url'];
|
|
// only execute if target is still in the list of trusted domains
|
|
if ($this->trustedServers->isTrustedServer($target)) {
|
|
$this->parentStart($jobList);
|
|
}
|
|
|
|
$jobList->remove($this, $this->argument);
|
|
|
|
if ($this->retainJob) {
|
|
$this->reAddJob($this->argument);
|
|
}
|
|
}
|
|
|
|
protected function parentStart(IJobList $jobList): void {
|
|
parent::start($jobList);
|
|
}
|
|
|
|
protected function run($argument) {
|
|
$target = $argument['url'];
|
|
$created = isset($argument['created']) ? (int)$argument['created'] : $this->time->getTime();
|
|
$currentTime = $this->time->getTime();
|
|
$source = $this->urlGenerator->getAbsoluteURL('/');
|
|
$source = rtrim($source, '/');
|
|
$token = $argument['token'];
|
|
|
|
// kill job after 30 days of trying
|
|
$deadline = $currentTime - $this->maxLifespan;
|
|
if ($created < $deadline) {
|
|
$this->logger->warning("The job to get the shared secret job is too old and gets stopped now without retention. Setting server status of '{$target}' to failure.");
|
|
$this->retainJob = false;
|
|
$this->trustedServers->setServerStatus($target, TrustedServers::STATUS_FAILURE);
|
|
return;
|
|
}
|
|
|
|
$endPoints = $this->ocsDiscoveryService->discover($target, 'FEDERATED_SHARING');
|
|
$endPoint = $endPoints['shared-secret'] ?? $this->defaultEndPoint;
|
|
|
|
// make sure that we have a well formatted url
|
|
$url = rtrim($target, '/') . '/' . trim($endPoint, '/');
|
|
|
|
$result = null;
|
|
try {
|
|
$result = $this->httpClient->get(
|
|
$url,
|
|
[
|
|
'query' =>
|
|
[
|
|
'url' => $source,
|
|
'token' => $token,
|
|
'format' => 'json',
|
|
],
|
|
'timeout' => 3,
|
|
'connect_timeout' => 3,
|
|
]
|
|
);
|
|
|
|
$status = $result->getStatusCode();
|
|
} catch (ClientException $e) {
|
|
$status = $e->getCode();
|
|
if ($status === Http::STATUS_FORBIDDEN) {
|
|
$this->logger->info($target . ' refused to exchange a shared secret with you.', ['app' => 'federation']);
|
|
} else {
|
|
$this->logger->info($target . ' responded with a ' . $status . ' containing: ' . $e->getMessage(), ['app' => 'federation']);
|
|
}
|
|
} catch (RequestException $e) {
|
|
$status = -1; // There is no status code if we could not connect
|
|
$this->logger->info('Could not connect to ' . $target, [
|
|
'exception' => $e,
|
|
]);
|
|
} catch (\Throwable $e) {
|
|
$status = Http::STATUS_INTERNAL_SERVER_ERROR;
|
|
$this->logger->error($e->getMessage(), [
|
|
'exception' => $e,
|
|
]);
|
|
}
|
|
|
|
// if we received a unexpected response we try again later
|
|
if (
|
|
$status !== Http::STATUS_OK
|
|
&& $status !== Http::STATUS_FORBIDDEN
|
|
) {
|
|
$this->retainJob = true;
|
|
}
|
|
|
|
if ($status === Http::STATUS_OK && $result instanceof IResponse) {
|
|
$body = $result->getBody();
|
|
$result = json_decode($body, true);
|
|
if (isset($result['ocs']['data']['sharedSecret'])) {
|
|
$this->trustedServers->addSharedSecret(
|
|
$target,
|
|
$result['ocs']['data']['sharedSecret']
|
|
);
|
|
} else {
|
|
$this->logger->error(
|
|
'remote server "' . $target . '"" does not return a valid shared secret. Received data: ' . $body,
|
|
['app' => 'federation']
|
|
);
|
|
$this->trustedServers->setServerStatus($target, TrustedServers::STATUS_FAILURE);
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Re-add background job
|
|
*
|
|
* @param array $argument
|
|
*/
|
|
protected function reAddJob(array $argument): void {
|
|
$url = $argument['url'];
|
|
$created = $argument['created'] ?? $this->time->getTime();
|
|
$token = $argument['token'];
|
|
$this->jobList->add(
|
|
GetSharedSecret::class,
|
|
[
|
|
'url' => $url,
|
|
'token' => $token,
|
|
'created' => $created
|
|
]
|
|
);
|
|
}
|
|
}
|