mwalbeck/email2pdf
1
0
Fork 0
forked from archive/andrewferrier_email2pdf
Code Pull requests Activity

Fix hardcoded and inaccurate image URLs.

Browse source
This commit is contained in:
Andrew Ferrier 2014-12-24 23:46:19 +00:00
parent 2d0f99401c
commit 49c78914b9
2 changed files with 7 additions and 4 deletions

3
tests/BaseTestClasses.py
View file

@ -27,6 +27,9 @@ class Email2PDFTestCase(unittest.TestCase):
isOnline = None
examineDir = None
NONEXIST_IMG = 'http://www.andrewferrier.com/nonexist.jpg'
EXIST_IMG = 'https://raw.githubusercontent.com/andrewferrier/email2pdf/master/tests/basi2c16.png'
def setUp(self):
self.workingDir = tempfile.mkdtemp(dir='/tmp')
self.command = os.path.normpath(os.path.join(os.getcwd(), 'email2pdf'))

8
tests/test_MIME.py
View file

@ -102,7 +102,7 @@ class TestMIME(BaseTestClasses.Email2PDFTestCase):
if self.isOnline:
path = os.path.join(self.examineDir, "remoteImageDoesExist.pdf")
self.addHeaders()
self.attachHTML('<img src="https://raw.githubusercontent.com/andrewferrier/email2pdf/master/basi2c16.png">')
self.attachHTML('<img src="' + self.EXIST_IMG + '">')
(rc, output, error) = self.invokeAsSubprocess(outputFile=path)
self.assertEqual(0, rc)
self.assertEqual('', error)
@ -114,7 +114,7 @@ class TestMIME(BaseTestClasses.Email2PDFTestCase):
if self.isOnline:
path = os.path.join(self.examineDir, "remoteImageDoesntExist.pdf")
self.addHeaders()
self.attachHTML('<img src="http://abc.por/blah.jpg">')
self.attachHTML('<img src="' + self.NONEXIST_IMG + '">')
(rc, output, error) = self.invokeAsSubprocess(outputFile=path)
self.assertEqual(0, rc)
self.assertTrue(os.path.exists(path))
@ -125,7 +125,7 @@ class TestMIME(BaseTestClasses.Email2PDFTestCase):
def test_remoteImageDoesntExistWithPDF(self):
if self.isOnline:
self.addHeaders()
self.attachHTML('<img src="http://abc.por/blah.jpg">')
self.attachHTML('<img src="' + self.NONEXIST_IMG + '">')
filename = self.attachPDF("Some PDF content")
(rc, output, error) = self.invokeAsSubprocess()
self.assertEqual(0, rc)
@ -202,7 +202,7 @@ class TestMIME(BaseTestClasses.Email2PDFTestCase):
if self.isOnline:
self.addHeaders()
imageFilename = self.attachImage('myid')
self.attachHTML('<p><img src="https://raw.githubusercontent.com/andrewferrier/email2pdf/master/basi2c16.png">' +
self.attachHTML('<p><img src="' + self.EXIST_IMG + '">' +
'<li></li><img src="cid:myid"></p>')
(rc, output, error) = self.invokeAsSubprocess()
self.assertEqual(0, rc)