Added validation to site with barebones error reporting to users

app/Http/Controllers/GroupController.php

@@ -5,6 +5,7 @@ namespace App\Http\Controllers;
 use Illuminate\Http\Request;
 
 use App\Http\Requests;
+use App\Http\Requests\StoreGroup;
 use App\Group;
 
 class GroupController extends Controller
@@ -25,10 +26,10 @@ class GroupController extends Controller
         return view('groups.new');
     }
 
-    public function addGroup()
+    public function addGroup(StoreGroup $request)
     {
         $group = new Group;
-        $group->addGroup(request()->all());
+        $group->addGroup($request->all());
         return redirect('/admin/groups');
     }
 
@@ -37,9 +38,9 @@ class GroupController extends Controller
         return view('groups.edit', compact('group'));
     }
 
-    public function updateGroup(Group $group)
+    public function updateGroup(Group $group, StoreGroup $request)
     {
-        $group->updateGroup(request()->all());
+        $group->updateGroup($request->all());
         return redirect("/admin/groups");
     }
 

app/Http/Controllers/HomeController.php

@@ -41,17 +41,24 @@ class HomeController extends Controller
         return view('users.settings', compact('user'));
     }
 
-    public function updatePassword()
+    public function updatePassword(Request $request)
     {
+        $this->validate($request, [
+            "password1_new" => "required|string|alpha_dash|min:8",
+            "password2_new" => "required|string|alpha_dash|min:8"
+        ]);
         $user = Auth::user();
-        $user->updatePassword(request()->all());
+        $user->updatePassword($request->all());
         return redirect('/settings');
     }
 
-    public function updateEmail()
+    public function updateEmail(Request $request)
     {
+        $this->validate($request, [
+            "email" => "required|email"
+        ]);
         $user = Auth::user();
-        $user->updateEmail(request()->all());
+        $user->updateEmail($request->all());
         return redirect('/settings');
     }
 }

app/Http/Controllers/TestController.php

@@ -11,6 +11,7 @@ use App\Question;
 use App\Option;
 use App\Group;
 use App\Http\Requests\StoreTest;
+use App\Http\Requests\StoreQuestion;
 
 class TestController extends Controller
 {
@@ -40,13 +41,13 @@ class TestController extends Controller
         return view('tests.index', compact('question'), compact('options'));
     }
 
-    public function answerQuestion()
+    public function answerQuestion(Request $request)
     {
         $question = session('questions')->get(session('question_counter')-1);
         $options = session('options');
         $answers = collect([]);
         foreach ($options as $option) {
-            if (array_key_exists("answer{$option->id}", request()->all())) {
+            if (array_key_exists("answer{$option->id}", $request->all())) {
                 $answers->push($option);
             }
         }
@@ -201,7 +202,7 @@ class TestController extends Controller
         return view('tests.edit', compact('test'));
     }   
 
-    public function addQuestion(Test $test, Request $request)
+    public function addQuestion(Test $test, StoreQuestion $request)
     {
         $question = new Question;
         $question->addQuestion($test, $request);
@@ -216,7 +217,7 @@ class TestController extends Controller
         return redirect("/admin/tests/$test->id");
     }
 
-    public function updateQuestion(Question $question, Request $request)
+    public function updateQuestion(Question $question, StoreQuestion $request)
     {
         $test = $question->test;
         $question->updateQuestion($request);

app/Http/Controllers/UserController.php

@@ -5,6 +5,7 @@ namespace App\Http\Controllers;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Auth;
 use App\Http\Requests;
+use App\Http\Requests\StoreUser;
 use App\User;
 use App\Group;
 
@@ -31,10 +32,10 @@ class UserController extends Controller
         return redirect('/admin/users');
     }
 
-    public function addUser()
+    public function addUser(StoreUser $request)
     {
         $user = new User;
-        $user->addUser(request()->all());
+        $user->addUser($request->all());
         return redirect('/admin/users');
     }