Move getCustomStyling to own controller so we don't call getUID when no user is active.

CHANGELOG.md

@@ -5,6 +5,7 @@
 ### Fixed
 
 -   [#213](https://github.com/mwalbeck/nextcloud-breeze-dark/issues/213) Deck: Use light icon for .icon-reply
+-   Move getCustomStyling to own controller so we don't call getUID when no user is active
 
 ## 20.0.5 - 2021-02-20
 

appinfo/routes.php

@@ -29,6 +29,6 @@ return [
         ['name' => 'Settings#personal', 'url' => '/settings', 'verb' => 'POST'],
         ['name' => 'Settings#admin', 'url' => '/settings/admin', 'verb' => 'POST'],
         ['name' => 'Settings#customStyling', 'url' => '/settings/custom-styling', 'verb' => 'POST'],
-        ['name' => 'Settings#getCustomStyling', 'url' => '/custom-styling', 'verb' => 'GET'],
+        ['name' => 'Theming#getCustomStyling', 'url' => '/custom-styling', 'verb' => 'GET'],
     ],
 ];

lib/AppInfo/Application.php

@@ -95,7 +95,7 @@ class Application extends App implements IBootstrap {
         }
 
         $linkToCustomStyling = $urlGenerator->linkToRoute(
-			'breezedark.Settings.getCustomStyling', 
+			'breezedark.Theming.getCustomStyling', 
             ['v' => $cachebuster,]
 		);
 		Util::addHeader(

lib/Controller/ThemingController.php

@@ -0,0 +1,70 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * Breeze Dark theme for Nextcloud
+ * 
+ * @copyright Copyright (C) 2021  Magnus Walbeck <mw@mwalbeck.org>
+ * 
+ * @author Magnus Walbeck <mw@mwalbeck.org>
+ * 
+ * @license GNU AGPL version 3 or any later version
+ * 
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ * 
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ * 
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ * 
+ */
+
+namespace OCA\BreezeDark\Controller;
+
+use OCP\AppFramework\Controller;
+use OCP\AppFramework\Http;
+use OCP\AppFramework\Http\DataDisplayResponse;
+use OCP\IConfig;
+use OCP\IRequest;
+
+class ThemingController extends Controller {
+
+    /** @var string */
+    protected $appName;
+
+    /** @var IConfig */
+    private $config;
+
+    /**
+     * @param string $appName
+     * @param IConfig $config
+     * @param IRequest $request
+     */
+    public function __construct(string $appName,
+                                IConfig $config,
+                                IRequest $request) {
+        parent::__construct($appName, $request);
+        $this->config = $config;
+    }
+
+    /**
+	 * @NoCSRFRequired
+	 * @PublicPage
+	 * @NoSameSiteCookieRequired
+	 *
+	 * @return DataDisplayResponse|NotFoundResponse
+	 */
+    public function getCustomStyling(): DataDisplayResponse {
+        $customStyling = $this->config->getAppValue($this->appName, 'theme_custom_styling', '');
+        $response = new DataDisplayResponse($customStyling, Http::STATUS_OK, ['Content-Type' => 'text/css']);
+		$response->cacheFor(86400);
+        return $response;
+    }
+}