mirror of
https://gitlab.com/bramw/baserow.git
synced 2025-04-26 13:44:41 +00:00
Merge branch '1927-boolean-filtertype-breaks-comparing-null-values' into 'develop'
Resolve "Boolean filterType breaks comparing null values" Closes #1927 and #1534 See merge request baserow/baserow!1611
This commit is contained in:
commit
17c83c77e0
2 changed files with 13 additions and 1 deletions
changelog/entries/unreleased/bug
web-frontend/modules/database
|
@ -0,0 +1,7 @@
|
||||||
|
{
|
||||||
|
"type": "bug",
|
||||||
|
"message": "BooleanViewFilterType breaks comparing null values causing the frontend to crash.",
|
||||||
|
"issue_number": 1927,
|
||||||
|
"bullet_points": [],
|
||||||
|
"created_at": "2023-08-25"
|
||||||
|
}
|
|
@ -1566,7 +1566,12 @@ export class BooleanViewFilterType extends ViewFilterType {
|
||||||
filterValue = trueString.includes(
|
filterValue = trueString.includes(
|
||||||
filterValue.toString().toLowerCase().trim()
|
filterValue.toString().toLowerCase().trim()
|
||||||
)
|
)
|
||||||
|
|
||||||
|
if (rowValue === null) {
|
||||||
|
rowValue = false
|
||||||
|
} else {
|
||||||
rowValue = trueString.includes(rowValue.toString().toLowerCase().trim())
|
rowValue = trueString.includes(rowValue.toString().toLowerCase().trim())
|
||||||
|
}
|
||||||
return filterValue ? rowValue : !rowValue
|
return filterValue ? rowValue : !rowValue
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue