Resolve "this.getFormulaType is not a function"

premium/web-frontend/modules/baserow_premium/fieldTypes.js

@@ -137,11 +137,11 @@ export class AIFieldType extends FieldType {
       .toHumanReadableString(field, value)
   }
 
-  getSortIndicator(field, registry) {
+  getSortIndicator(field) {
     return this.app.$registry
       .get('aiFieldOutputType', field.ai_output_type)
       .getBaserowFieldType()
-      .getSortIndicator(field, registry)
+      .getSortIndicator(field)
   }
 
   canRepresentDate(field) {
@@ -207,13 +207,6 @@ export class AIFieldType extends FieldType {
       .getGroupByComponent(field)
   }
 
-  getGroupByIndicator(field, registry) {
-    return this.app.$registry
-      .get('aiFieldOutputType', field.ai_output_type)
-      .getBaserowFieldType()
-      .getGroupByIndicator(field, registry)
-  }
-
   getRowValueFromGroupValue(field, value) {
     return this.app.$registry
       .get('aiFieldOutputType', field.ai_output_type)

web-frontend/modules/database/components/view/ViewGroupByContext.vue

@@ -205,7 +205,7 @@ export default {
         const sortType = values.type || groupBy.type
         const field = this.getField(values.field)
         const fieldType = this.getFieldType(field)
-        const sortTypes = fieldType.getSortTypes(field, this.$registry)
+        const sortTypes = fieldType.getSortTypes(field)
         if (!Object.prototype.hasOwnProperty.call(sortTypes, sortType)) {
           values.type = DEFAULT_SORT_TYPE_KEY
         }
@@ -222,13 +222,8 @@ export default {
         notifyIf(error, 'view')
       }
     },
-    getGroupByIndicator(field, index) {
-      return this.$registry
-        .get('field', field.type)
-        .getGroupByIndicator(field, this.$registry)[index]
-    },
     getSortTypes(field) {
-      return this.getFieldType(field).getSortTypes(field, this.$registry)
+      return this.getFieldType(field).getSortTypes(field)
     },
   },
 }

web-frontend/modules/database/components/view/ViewSortContext.vue

@@ -199,7 +199,7 @@ export default {
         const sortType = values.type || sort.type
         const field = this.getField(values.field)
         const fieldType = this.getFieldType(field)
-        const sortTypes = fieldType.getSortTypes(field, this.$registry)
+        const sortTypes = fieldType.getSortTypes(field)
         if (!Object.prototype.hasOwnProperty.call(sortTypes, sortType)) {
           values.type = DEFAULT_SORT_TYPE_KEY
         }
@@ -217,7 +217,7 @@ export default {
       }
     },
     getSortTypes(field) {
-      return this.getFieldType(field).getSortTypes(field, this.$registry)
+      return this.getFieldType(field).getSortTypes(field)
     },
   },
 }

web-frontend/modules/database/components/view/grid/GridViewFieldType.vue

@@ -281,6 +281,7 @@ import InsertFieldContext from '@baserow/modules/database/components/field/Inser
 import DuplicateFieldModal from '@baserow/modules/database/components/field/DuplicateFieldModal'
 import HorizontalResize from '@baserow/modules/core/components/HorizontalResize'
 import gridViewHelpers from '@baserow/modules/database/mixins/gridViewHelpers'
+import { DEFAULT_SORT_TYPE_KEY } from '@baserow/modules/database/constants'
 
 export default {
   name: 'GridViewFieldType',
@@ -455,7 +456,7 @@ export default {
           await this.$store.dispatch('view/createSort', {
             view,
             field,
-            values,
+            values: { ...values, type: DEFAULT_SORT_TYPE_KEY },
           })
         } else {
           await this.$store.dispatch('view/updateSort', {
@@ -492,9 +493,9 @@ export default {
       this.$emit('dragging', { field, event })
     },
     getSortIndicator(field, index) {
-      return this.$registry
-        .get('field', field.type)
-        .getSortIndicator(field, this.$registry)[index]
+      return this.$registry.get('field', field.type).getSortIndicator(field)[
+        index
+      ]
     },
     getCanSortInView(field) {
       return this.$registry.get('field', field.type).getCanSortInView(field)

web-frontend/modules/database/fieldTypes.js

@@ -385,10 +385,6 @@ export class FieldType extends Registerable {
     return false
   }
 
-  getGroupByIndicator(field, registry) {
-    return this.getSortIndicator(field, registry)
-  }
-
   /**
    * In some cases, the group by value can not be directly compared to a row value
    * because the format is different for technical reasons in the backend. This
@@ -532,11 +528,11 @@ export class FieldType extends Registerable {
    * type. It always returns the default type, which uses the `getSort` and
    * `getSortIndicator` by default.
    */
-  getSortTypes(field, registry) {
+  getSortTypes(field) {
     return {
       [DEFAULT_SORT_TYPE_KEY]: {
         function: this.getSort,
-        indicator: this.getSortIndicator(field, registry),
+        indicator: this.getSortIndicator(field),
       },
     }
   }
@@ -3313,8 +3309,8 @@ export class SingleSelectFieldType extends SelectOptionBaseFieldType {
     }
   }
 
-  getSortTypes(field, registry) {
-    const defaultTypes = super.getSortTypes()
+  getSortTypes(field) {
+    const defaultTypes = super.getSortTypes(field)
     defaultTypes.order = {
       function: this.getSortByOptionOrder,
       indicator: ['text', 'First', 'Last'],
@@ -3968,6 +3964,10 @@ export class FormulaFieldType extends mix(
     return this.getFormulaType(field)?.getSort(name, order, field)
   }
 
+  getSortTypes(field) {
+    return this.getFormulaType(field)?.getSortTypes(field)
+  }
+
   getEmptyValue(field) {
     return null
   }

web-frontend/modules/database/formula/formulaTypes.js

@@ -73,6 +73,7 @@ import {
 } from '@baserow/modules/database/utils/fieldFilters'
 import ViewFilterTypeDuration from '@baserow/modules/database/components/view/ViewFilterTypeDuration.vue'
 import ViewFilterTypeMultipleSelectOptions from '@baserow/modules/database/components/view/ViewFilterTypeMultipleSelectOptions.vue'
+import { DEFAULT_SORT_TYPE_KEY } from '@baserow/modules/database/constants'
 
 export class BaserowFormulaTypeDefinition extends Registerable {
   getIconClass() {
@@ -196,6 +197,19 @@ export class BaserowFormulaTypeDefinition extends Registerable {
     return underlyingFieldType.getSort(name, order, field)
   }
 
+  getSortTypes(field) {
+    const underlyingFieldType = this.app.$registry.get(
+      'field',
+      this.getFieldType()
+    )
+    const fieldSortTypes = underlyingFieldType.getSortTypes(field)
+    // Only the default sort type is supported for formulas at the moment because
+    // there is no way to configure different types in the backend.
+    return {
+      [DEFAULT_SORT_TYPE_KEY]: fieldSortTypes[DEFAULT_SORT_TYPE_KEY],
+    }
+  }
+
   _mapFormulaTypeToFieldType(formulaType) {
     return this.app.$registry.get('formula_type', formulaType).getFieldType()
   }

web-frontend/modules/database/store/view.js

@@ -1369,7 +1369,7 @@ export const actions = {
       view.sortings
         .filter((sort) => sort.field === field.id)
         .forEach((sort) => {
-          const sortTypes = fieldType.getSortTypes(field, this.$registry)
+          const sortTypes = fieldType.getSortTypes(field)
           const compatible =
             fieldType.getCanSortInView(field) &&
             Object.prototype.hasOwnProperty.call(sortTypes, sort.type)
@@ -1382,7 +1382,7 @@ export const actions = {
       view.group_bys
         .filter((groupBy) => groupBy.field === field.id)
         .forEach((groupBy) => {
-          const sortTypes = fieldType.getSortTypes(field, this.$registry)
+          const sortTypes = fieldType.getSortTypes(field)
           const compatible =
             fieldType.getCanSortInView(field) &&
             Object.prototype.hasOwnProperty.call(sortTypes, groupBy.type)

web-frontend/modules/database/utils/view.js

@@ -21,7 +21,7 @@ export function getRowSortFunction($registry, sortings, fields, groupBys = []) {
     if (field !== undefined) {
       const fieldName = `field_${field.id}`
       const fieldType = $registry.get('field', field.type)
-      const sortTypes = fieldType.getSortTypes(field, $registry)
+      const sortTypes = fieldType.getSortTypes(field)
       const fieldSortFunction = sortTypes[sort.type].function(
         fieldName,
         sort.order,

web-frontend/modules/integrations/localBaserow/components/services/LocalBaserowTableServiceSortForm.vue

@@ -237,9 +237,7 @@ export default {
       this.$emit('input', newSortings)
     },
     getSortIndicator(field, index) {
-      return this.getFieldType(field).getSortIndicator(field, this.$registry)[
-        index
-      ]
+      return this.getFieldType(field).getSortIndicator(field)[index]
     },
   },
 }