1
0
Fork 0
mirror of https://gitlab.com/bramw/baserow.git synced 2025-04-06 22:08:52 +00:00

fix: skip null values in URL query param resolution

This commit is contained in:
Evren Ozkan 2025-02-18 14:23:01 +00:00
parent d026df644a
commit a5f191ce2b
3 changed files with 10 additions and 1 deletions
changelog/entries/unreleased/bug
e2e-tests/tests/builder
web-frontend/modules/builder/utils

View file

@ -0,0 +1,7 @@
{
"type": "bug",
"message": "Fixed null check for query parameters in link URL generation",
"issue_number": 3444,
"bullet_points": [],
"created_at": "2025-02-17"
}

View file

@ -110,6 +110,7 @@ test.describe("Builder page test suite", () => {
await expect(page.locator(".box__title").getByText("Page")).toBeHidden();
await page.getByText('Click to create an element').click();
await page.getByText('Link A link to page/URL').click();
await page.getByLabel('my_param=').fill("foo")
await page.getByRole('complementary').getByRole('textbox').click();
await page.getByRole('complementary').getByRole('textbox').locator('div').first().fill('linkim');
await page.locator('a').filter({hasText: 'Make a choice'}).click();
@ -120,7 +121,7 @@ test.describe("Builder page test suite", () => {
await page.getByText('my_param', { exact: true }).first().click();
await page.click('body')
await expect(page.getByRole('link', {name: 'linkim'})).toHaveAttribute(
'href', /\?my_param=null/);
'href', /\?my_param=foo/);
});
});

View file

@ -67,6 +67,7 @@ export default function resolveElementUrl(
.map(({ name, value }) => {
if (!value) return null
const resolvedValue = resolveFormula(value)
if (!resolvedValue && String(resolvedValue) !== '0') return null
return `${encodeURIComponent(name)}=${encodeURIComponent(
resolvedValue
)}`